Skip to contentSkip to conversation

staging: rtl8723bs: replace msleep with usleep_range

PATCH In review Ethan Lam 2 participants 2 messages Feb 9 Staging

lore
Share & tools
lore

Ethan Lam

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: replace msleep with usleep_range

checkpatch.pl says that msleep < 20ms can sleep for longer than expected. The documentation says we should "Use uslee_range*()
whenever accuracy of *sleep() is not sufficient)

Replaced msleep(10) with usleep_range(10000, 11000) so the delay is more accurate and percise

---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +1 -1
index ef2d92b5588a..97c923015279 100644
@@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		usleep_range(10000, 11000);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 29 lines · Ethan Lam

checkpatch.pl says that msleep < 20ms can sleep for longer than expected. The documentation says we should "Use uslee_range*()
whenever accuracy of *sleep() is not sufficient)

Replaced msleep(10) with usleep_range(10000, 11000) so the delay is more accurate and percise

---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +1 -1
index ef2d92b5588a..97c923015279 100644
@@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		usleep_range(10000, 11000);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
Signature · 1 line
2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot