Skip to contentSkip to conversation

client: Add mgmt.exp-iso command

PATCH Applied Luiz Augusto von Dentz 3 participants 4 messages Feb 10 – Feb 11 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/2 client: Add mgmt.exp-iso command

From: Luiz Augusto von Dentz <[email protected]>

This adds mgmt.exp-iso command which can be used to toggle ISO socket support:

@ MGMT Command: Set Experimental Feature (0x004a) plen 17
UUID: BlueZ Experimental ISO Socket
Action: Enabled (0x01)
@ MGMT Event: Command Complete (0x0001) plen 23

      Set Experimental Feature (0x004a) plen 20
        Status: Success (0x00)
        UUID: BlueZ Experimental ISO Socket
        Flags: 0x00000001
          Active

@ MGMT Event: Experimental Feature Changed (0x0027) plen 20
UUID: BlueZ Experimental ISO Socket
Flags: 0x00000001
Active

---
 client/mgmt.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
client/mgmt.c +38 -0
index 968efdbca5b0..4e68547ed33c 100644
@@ -2751,6 +2751,42 @@ static void cmd_exp_offload_codecs(int argc, char **argv)
 	}
 }
 
+static void exp_iso_rsp(uint8_t status, uint16_t len, const void *param,
+							void *user_data)
+{
+	if (status != 0)
+		error("Set ISO Socket failed with status 0x%02x (%s)", status,
+					mgmt_errstr(status));
+	else
+		print("ISO Socket successfully set");
+
+	bt_shell_noninteractive_quit(EXIT_SUCCESS);
+}
+
+static void cmd_exp_iso(int argc, char **argv)
+{
+	/* 6fbaf188-05e0-496a-9885-d6ddfdb4e03e */
+	static const uint8_t uuid[16] = {
+		0x3e, 0xe0, 0xb4, 0xfd, 0xdd, 0xd6, 0x85, 0x98,
+		0x6a, 0x49, 0xe0, 0x05, 0x88, 0xf1, 0xba, 0x6f
+	};
+	struct mgmt_cp_set_exp_feature cp;
+	uint8_t val;
+
+	if (parse_setting(argc, argv, &val) == false)
+		return bt_shell_noninteractive_quit(EXIT_FAILURE);
+
+	memset(&cp, 0, sizeof(cp));
+	memcpy(cp.uuid, uuid, 16);
+	cp.action = val;
+
+	if (mgmt_send(mgmt, MGMT_OP_SET_EXP_FEATURE, MGMT_INDEX_NONE,
+			sizeof(cp), &cp, exp_iso_rsp, NULL, NULL) == 0) {
+		error("Unable to set ISO Socket experimental feature");
+		return bt_shell_noninteractive_quit(EXIT_FAILURE);
+	}
+}
+
 static void class_rsp(uint16_t op, uint16_t id, uint8_t status, uint16_t len,
 							const void *param)
 {
@@ -6166,6 +6202,8 @@ static const struct bt_shell_menu mgmt_menu = {
 		"Set bluetooth quality report feature"			},
 	{ "exp-offload",		"<on/off>",
 		cmd_exp_offload_codecs,	"Toggle codec support"		},
+	{ "exp-iso",		"<on/off>",
+		cmd_exp_iso,	"Toggle ISO support"		},
 	{ "read-sysconfig",	NULL,
 		cmd_read_sysconfig,	"Read System Configuration"	},
 	{ "set-sysconfig",	"<-v|-h> [options...]",
Signature · 1 line
2.52.0
author maintainer
#1 lore raw

PATCH 2/2 bluetoothctl-mgmt: Add documentation to exp-iso command

From: Luiz Augusto von Dentz <[email protected]>

---
 doc/bluetoothctl-mgmt.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
doc/bluetoothctl-mgmt.rst +12 -0
index 0ff16e4d268e..646c2dcb4365 100644
@@ -1189,6 +1189,18 @@ Toggle codec support
 :Example Disable experimental codec offload support:
 	| **> exp-offload off**
 
+exp-iso
+-------
+
+Toggle ISO Socket support
+
+:Usage: **> exp-iso <on/off>**
+:<on/off>: Experimental ISO Socket support - "on" to enable ISO Socket support, "off" to disable
+:Example Enable experimental ISO Socket support:
+	| **> exp-offload on**
+:Example Disable experimental ISO Socket support:
+	| **> exp-offload off**
+
 read-sysconfig
 --------------
 
Signature · 1 line
2.52.0
#2 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1052893

---Test result---

Test Summary:

CheckPatch                    PENDING   0.45 seconds
GitLint                       PENDING   0.42 seconds
BuildEll                      PASS      18.45 seconds
BluezMake                     PASS      635.78 seconds
MakeCheck                     PASS      18.38 seconds
MakeDistcheck                 PASS      224.14 seconds
CheckValgrind                 PASS      282.82 seconds
CheckSmatch                   PASS      318.02 seconds
bluezmakeextell               PASS      170.38 seconds
IncrementalBuild              PENDING   0.43 seconds
ScanBuild                     PASS      936.86 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Luiz Augusto von Dentz
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 14 lines · On Tue, 10 Feb 2026 15:58:58 -0500 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

This adds mgmt.exp-iso command which can be used to toggle ISO socket support:

@ MGMT Command: Set Experimental Feature (0x004a) plen 17
UUID: BlueZ Experimental ISO Socket
Action: Enabled (0x01)
@ MGMT Event: Command Complete (0x0001) plen 23

      Set Experimental Feature (0x004a) plen 20
        Status: Success (0x00)
        UUID: BlueZ Experimental ISO Socket
        Flags: 0x00000001
          Active
Quoted 6 lines

@ MGMT Event: Experimental Feature Changed (0x0027) plen 20
UUID: BlueZ Experimental ISO Socket
Flags: 0x00000001
Active

[...]

Here is the summary with links:
- [BlueZ,v1,1/2] client: Add mgmt.exp-iso command

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6b2a732b434f
  - [BlueZ,v1,2/2] bluetoothctl-mgmt: Add documentation to exp-iso command
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=30acac54935c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html