Skip to contentSkip to conversation

selftests/bpf: Rename do_filp_open() to do_file_open()

PATCH Applied Ihor Solodrai 2 participants 2 messages Feb 10 – Feb 11

Subsystems (3)
lore
Share & tools
lore

Ihor Solodrai

author reviewer
#0 lore raw

PATCH 1/1 selftests/bpf: Rename do_filp_open() to do_file_open()

do_filp_open() was renamed (fixing typo) in commit 541003b576c3 ("rename do_filp_open() to do_file_open()")

This broke test_profiler, because it uses a kretprobe on that function. Fix it by renaming accordingly.

---
 tools/testing/selftests/bpf/progs/profiler.h     | 2 +-
 tools/testing/selftests/bpf/progs/profiler.inc.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/progs/profiler.h +1 -1
index 3bac4fdd4bdf..637fbf2c2652 100644
@@ -169,7 +169,7 @@ enum bpf_function_id {
 	profiler_bpf_sched_process_exec,
 	profiler_bpf_sched_process_exit,
 	profiler_bpf_sys_enter_kill,
-	profiler_bpf_do_filp_open_ret,
+	profiler_bpf_do_file_open_ret,
 	profiler_bpf_sched_process_fork,
 	profiler_bpf_vfs_link,
 	profiler_bpf_vfs_symlink,
tools/testing/selftests/bpf/progs/profiler.inc.h +3 -3
index 813143b4985d..9044dd8aff11 100644
@@ -751,11 +751,11 @@ int raw_tracepoint__sched_process_exec(struct bpf_raw_tracepoint_args* ctx)
 	return 0;
 }
 
-SEC("kretprobe/do_filp_open")
-int kprobe_ret__do_filp_open(struct pt_regs* ctx)
+SEC("kretprobe/do_file_open")
+int kprobe_ret__do_file_open(struct pt_regs *ctx)
 {
 	struct bpf_func_stats_ctx stats_ctx;
-	bpf_stats_enter(&stats_ctx, profiler_bpf_do_filp_open_ret);
+	bpf_stats_enter(&stats_ctx, profiler_bpf_do_file_open_ret);
 
 	struct file* filp = (struct file*)PT_REGS_RC_CORE(ctx);
 
Signature · 1 line
2.53.0
#1 lore raw
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:

Quoted 6 lines · On Tue, 10 Feb 2026 15:58:55 -0800 you wrote:

do_filp_open() was renamed (fixing typo) in commit 541003b576c3 ("rename do_filp_open() to do_file_open()")

This broke test_profiler, because it uses a kretprobe on that function. Fix it by renaming accordingly.

Quoted 6 lines

[...]

Here is the summary with links:
- [bpf,v1] selftests/bpf: Rename do_filp_open() to do_file_open()

    https://git.kernel.org/bpf/bpf/c/1a7eb7a3d740

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html