Skip to contentSkip to conversation

arm64: dts: qcom: sm8550: Add UART15

PATCH Superseded Aaron Kling 2 participants 4 messages Feb 11 – Feb 12

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: sm8550: Add UART15

From: Xilin Wu <[email protected]>

Add uart15 node for UART bus present on sm8550 SoC.

---
This patch was originally submitted as part of a series to support the AYN Odin 2 [0]. That series stalled, so submitting separately.

[0] https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Use QCOM_ICC_TAG_ define in interconnect paths phandle third argument
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +24 -0
index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..a54f375f7f041a193a4396e4aa911abb42e3e6dc 100644
@@ -1251,6 +1251,22 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				#size-cells = <0>;
 				status = "disabled";
 			};
+
+			uart15: serial@89c000 {
+				compatible = "qcom,geni-uart";
+				reg = <0 0x89c000 0 0x4000>;
+				clock-names = "se";
+				clocks = <&gcc GCC_QUPV3_WRAP2_S7_CLK>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&qup_uart15_default>;
+				interrupts = <GIC_SPI 462 IRQ_TYPE_LEVEL_HIGH 0>;
+				interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
+						 &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
+						<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+						 &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
+				interconnect-names = "qup-core", "qup-config";
+				status = "disabled";
+			};
 		};
 
 		i2c_master_hub_0: geniqup@9c0000 {
@@ -5095,6 +5111,14 @@ qup_uart14_cts_rts: qup-uart14-cts-rts-state {
 				bias-pull-down;
 			};
 
+			qup_uart15_default: qup-uart15-default-state {
+				/* TX, RX */
+				pins = "gpio74", "gpio75";
+				function = "qup2_se7";
+				drive-strength = <2>;
+				bias-pull-up;
+			};
+
 			sdc2_sleep: sdc2-sleep-state {
 				clk-pins {
 					pins = "sdc2_clk";

---
base-commit: 9845cf73f7db6094c0d8419d6adb848028f4a921
change-id: 20260207-sm8550-uart15-9b7bd48e747d

Best regards,

Signature · 1 line
Aaron Kling <[email protected]>
#1 lore raw
Quoted 26 lines · On 2/11/26 11:35 PM, Aaron Kling via B4 Relay wrote:

From: Xilin Wu <[email protected]>

Add uart15 node for UART bus present on sm8550 SoC.

---
This patch was originally submitted as part of a series to support the AYN Odin 2 [0]. That series stalled, so submitting separately.

[0] https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Use QCOM_ICC_TAG_ define in interconnect paths phandle third argument
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +0 -0
index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..a54f375f7f041a193a4396e4aa911abb42e3e6dc 100644

arch/arm64/boot/dts/qcom/sm8550.dtsi &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>, · line 1255

Quoted 5 lines
arch/arm64/boot/dts/qcom/sm8550.dtsi +2 -0
@@ -1251,6 +1251,22 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				#size-cells = <0>;
 				status = "disabled";
 			};
+
+			uart15: serial@89c000 {

This should be uart23 (see other nodes at this base addr have that index)

arch/arm64/boot/dts/qcom/sm8550.dtsi &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>, · line 1257

Quoted 2 lines
arch/arm64/boot/dts/qcom/sm8550.dtsi +2 -0
+				compatible = "qcom,geni-uart";
+				reg = <0 0x89c000 0 0x4000>;

Please pad the address to 8 hex digits with leading zeroes

[...]

arch/arm64/boot/dts/qcom/sm8550.dtsi qup_uart14_cts_rts: qup-uart14-cts-rts-state { · line 5114

Quoted 1 line
arch/arm64/boot/dts/qcom/sm8550.dtsi +1 -0
+			qup_uart15_default: qup-uart15-default-state {

And let's also update the name here

Konrad

#2 lore raw
Quoted 23 lines · Konrad Dybcio
Quoted 21 lines · On 2/11/26 11:35 PM, Aaron Kling via B4 Relay wrote:

From: Xilin Wu <[email protected]>

Add uart15 node for UART bus present on sm8550 SoC.

---
This patch was originally submitted as part of a series to support the AYN Odin 2 [0]. That series stalled, so submitting separately.

[0] https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Use QCOM_ICC_TAG_ define in interconnect paths phandle third argument
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
Quoted 12 lines

arch/arm64/boot/dts/qcom/sm8550.dtsi &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>, · line 1255

Quoted 10 lines
arch/arm64/boot/dts/qcom/sm8550.dtsi +2 -0
index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..a54f375f7f041a193a4396e4aa911abb42e3e6dc 100644
@@ -1251,6 +1251,22 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
                              #size-cells = <0>;
                              status = "disabled";
                      };
+
+                     uart15: serial@89c000 {

This should be uart23 (see other nodes at this base addr have that index)

Am I missing something here? For sm8550 [0], I see i2c@89c000 and spi@89c000 labelled as i2c15 and spi15 respectively.

Quoted 4 lines

arch/arm64/boot/dts/qcom/sm8550.dtsi &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>, · line 1257

Quoted 2 lines
arch/arm64/boot/dts/qcom/sm8550.dtsi +2 -0
+                             compatible = "qcom,geni-uart";
+                             reg = <0 0x89c000 0 0x4000>;

Please pad the address to 8 hex digits with leading zeroes

Ack.

Quoted 6 lines

[...]

Quoted 1 line

+ qup_uart15_default: qup-uart15-default-state {

And let's also update the name here

Konrad

Aaron

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8550.dtsi?h=v6.19#n1205

#3 lore raw
Quoted 38 lines · Aaron Kling
Quoted 23 lines · Konrad Dybcio
Quoted 21 lines · On 2/11/26 11:35 PM, Aaron Kling via B4 Relay wrote:

From: Xilin Wu <[email protected]>

Add uart15 node for UART bus present on sm8550 SoC.

---
This patch was originally submitted as part of a series to support the AYN Odin 2 [0]. That series stalled, so submitting separately.

[0] https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Use QCOM_ICC_TAG_ define in interconnect paths phandle third argument
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
Quoted 12 lines

arch/arm64/boot/dts/qcom/sm8550.dtsi &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>, · line 1255

Quoted 10 lines
arch/arm64/boot/dts/qcom/sm8550.dtsi +2 -0
index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..a54f375f7f041a193a4396e4aa911abb42e3e6dc 100644
@@ -1251,6 +1251,22 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
                              #size-cells = <0>;
                              status = "disabled";
                      };
+
+                     uart15: serial@89c000 {

This should be uart23 (see other nodes at this base addr have that index)

Quoted 2 lines

Am I missing something here? For sm8550 [0], I see i2c@89c000 and spi@89c000 labelled as i2c15 and spi15 respectively.

Well, it seems like I implicitly upgraded your device in my brain.. what I said is true for x elite..

Konrad