package/log4cxx: fix ENABLE_ESMTP flag
PATCH v2 1/1 package/log4cxx: fix ENABLE_ESMTP flag
commit cf686670b99ae0388b27867db64516c09b2de91f introduced a patch that was later included in a release which made the usage of libesmtp configurable. Later the switch was moved to the main CMakeLists.mk [0].
while the patch introduced the build flag LOG4CXX_ENABLE_ESMTP the change to the .mk file used LOG4CXX_ENABLE_LIBESMTP.
So correct this.
Fixes:
CMake Warning:
Manually-specified variables were not used by the project:
LOG4CXX_ENABLE_LIBESMTP
[0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
---
V2:
- use correct param name in commit message
- add reference to current CMakeLists.mk
--- package/log4cxx/log4cxx.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/log4cxx/log4cxx.mk +2 -2
@@ -23,10 +23,10 @@ LOG4CXX_DEPENDENCIES += boost endif ifeq ($(BR2_PACKAGE_LIBESMTP),y) -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=ON +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=ON LOG4CXX_DEPENDENCIES += libesmtp else -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=OFF +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=OFF endif ifeq ($(BR2_PACKAGE_UNIXODBC),y)
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 9 lines · Michael Nosthoff via buildroot
commit
cf686670b99ae0388b27867db64516c09b2de91fintroduced a patch that was later included in a release which made the usage of libesmtp configurable. Later the switch was moved to the main CMakeLists.mk [0].while the patch introduced the build flag
LOG4CXX_ENABLE_ESMTPthe change to the .mk file usedLOG4CXX_ENABLE_LIBESMTP.So correct this.
Quoted 8 lines
Fixes:
CMake Warning:
Manually-specified variables were not used by the project:
LOG4CXX_ENABLE_LIBESMTP[0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
Signed-off-by Michael Nosthoff <[email protected]>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Perale via buildroot
AppliedIn reply of:
Quoted 9 lines
commit
cf686670b99ae0388b27867db64516c09b2de91fintroduced a patch that was later included in a release which made the usage of libesmtp configurable. Later the switch was moved to the main CMakeLists.mk [0].while the patch introduced the build flag
LOG4CXX_ENABLE_ESMTPthe change to the .mk file usedLOG4CXX_ENABLE_LIBESMTP.So correct this.
Quoted 9 lines
Fixes:
CMake Warning:
Manually-specified variables were not used by the project:
LOG4CXX_ENABLE_LIBESMTP[0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
Signed-off-by Michael Nosthoff <[email protected]>
Applied to 2025.02.x. Thanks
Quoted 33 lines
---
V2:
- use correct param name in commit message
- add reference to current CMakeLists.mk--- package/log4cxx/log4cxx.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/log4cxx/log4cxx.mk +2
-2@@ -23,10 +23,10 @@ LOG4CXX_DEPENDENCIES += boost endif ifeq ($(BR2_PACKAGE_LIBESMTP),y) -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=ON +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=ON LOG4CXX_DEPENDENCIES += libesmtp else -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=OFF +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=OFF endif ifeq ($(BR2_PACKAGE_UNIXODBC),y)Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot