Skip to contentSkip to conversation

drm/tyr: make SRAM supply optional like panthor

PATCH In review Onur Özkan 4 participants 16 messages Feb 12 – Feb 13

Subsystems (7)
lore
Share & tools
lore

Onur Özkan

author reviewer
#0 lore raw

v2 cover drm/tyr: make SRAM supply optional like panthor

Changes in v2:
- Add rust_helper_regulator_get_optional() to fix CONFIG_REGULATOR=n builds where regulator_get_optional() may be only a static inline.
- Update Regulator invariants documentation to mention both regulator_get() and regulator_get_optional().

Onur Özkan (1):
drm/tyr: make SRAM supply optional like panthor

 drivers/gpu/drm/tyr/driver.rs |  5 ++--
 rust/helpers/regulator.c      |  5 ++++
 rust/kernel/regulator.rs      | 45 +++++++++++++++++++++++++++++++++--
 3 files changed, 51 insertions(+), 4 deletions(-)
Signature · 1 line
2.51.2
author reviewer
#1 lore raw

PATCH v2 1/1 drm/tyr: make SRAM supply optional like panthor

On rk3588s, dmesg | grep 'tyr' logs:

tyr fb000000.gpu: supply SRAM not found, using dummy regulator

This happens because Tyr calls Regulator<Enabled>::get() for SRAM, which goes through the non-optional regulator_get() path. If the device tree doesn't provide sram-supply, regulator core falls back to a dummy regulator and writes that log.

Panthor handles SRAM as optional and tolerates missing sram-supply. This patch matches that behavior in Tyr by using optional regulator lookup and storing SRAM as Option<Regulator<Enabled>> which avoids dummy-regulator fallback/noise when SRAM is not described inside the device tree.

---
 drivers/gpu/drm/tyr/driver.rs |  5 ++--
 rust/helpers/regulator.c      |  5 ++++
 rust/kernel/regulator.rs      | 45 +++++++++++++++++++++++++++++++++--
 3 files changed, 51 insertions(+), 4 deletions(-)
drivers/gpu/drm/tyr/driver.rs +3 -2
index 0389c558c036..e0856deb83ec 100644
@@ -113,7 +113,8 @@ fn probe(
         coregroup_clk.prepare_enable()?;
 
         let mali_regulator = Regulator::<regulator::Enabled>::get(pdev.as_ref(), c_str!("mali"))?;
-        let sram_regulator = Regulator::<regulator::Enabled>::get(pdev.as_ref(), c_str!("sram"))?;
+        let sram_regulator =
+            Regulator::<regulator::Enabled>::get_optional(pdev.as_ref(), c_str!("sram"))?;
 
         let request = pdev.io_request_by_index(0).ok_or(ENODEV)?;
         let iomem = Arc::pin_init(request.iomap_sized::<SZ_2M>(), GFP_KERNEL)?;
@@ -201,5 +202,5 @@ struct Clocks {
 #[pin_data]
 struct Regulators {
     mali: Regulator<regulator::Enabled>,
-    sram: Regulator<regulator::Enabled>,
+    sram: Option<Regulator<regulator::Enabled>>,
 }
rust/helpers/regulator.c +5 -0
index 11bc332443bd..5ef45a8adf12 100644
@@ -25,6 +25,11 @@ struct regulator *rust_helper_regulator_get(struct device *dev, const char *id)
 	return regulator_get(dev, id);
 }
 
+struct regulator *rust_helper_regulator_get_optional(struct device *dev, const char *id)
+{
+	return regulator_get_optional(dev, id);
+}
+
 int rust_helper_regulator_enable(struct regulator *regulator)
 {
 	return regulator_enable(regulator);
rust/kernel/regulator.rs +43 -2

71 lines not on this page · raw message

Signature · 1 line
2.51.2
maintainer
#2 lore raw
Quoted 10 lines · Onur Özkan

On rk3588s, dmesg | grep 'tyr' logs:

tyr fb000000.gpu: supply SRAM not found, using dummy regulator

This happens because Tyr calls Regulator<Enabled>::get() for SRAM, which goes through the non-optional regulator_get() path. If the device tree doesn't provide sram-supply, regulator core falls back to a dummy regulator and writes that log.

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

author reviewer
#3 lore raw
Quoted 5 lines · On Thu, 12 Feb 2026 11:34:41 +0000 Mark Brown <[email protected]> wrote:
Quoted 4 lines · Onur Özkan

On rk3588s, dmesg | grep 'tyr' logs:

tyr fb000000.gpu: supply SRAM not found, using dummy regulator

Quoted 8 lines
Quoted 6 lines

This happens because Tyr calls Regulator<Enabled>::get() for SRAM, which goes through the non-optional regulator_get() path. If the device tree doesn't provide sram-supply, regulator core falls back to a dummy regulator and writes that log.

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

- Onur

maintainer
#4 lore raw
Quoted 11 lines · Onur Özkan
Quoted 5 lines · Mark Brown
Quoted 1 line · Onur Özkan

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

#5 lore raw
Quoted 13 lines · On Thu, 12 Feb 2026 12:21:07 +0000 Mark Brown <[email protected]> wrote:
Quoted 11 lines · Onur Özkan
Quoted 5 lines · Mark Brown
Quoted 1 line · Onur Özkan

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

Quoted 5 lines

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

maintainer
#6 lore raw
Quoted 6 lines · Boris Brezillon
Quoted 3 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Quoted 6 lines
Quoted 1 line

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

#7 lore raw
Quoted 14 lines · On Thu, 12 Feb 2026 13:13:31 +0000 Mark Brown <[email protected]> wrote:
Quoted 6 lines · Boris Brezillon
Quoted 3 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Quoted 6 lines
Quoted 1 line

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

Quoted 4 lines

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

Okay, I guess we need to fix panthor then...

author reviewer
#8 lore raw
Quoted 18 lines · On Thu, 12 Feb 2026 14:51:34 +0100 Boris Brezillon…
Quoted 15 lines · On Thu, 12 Feb 2026 13:13:31 +0000 Mark Brown <[email protected]> wrote:
Quoted 13 lines · Boris Brezillon
Quoted 5 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

Quoted 8 lines
Quoted 5 lines

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

Okay, I guess we need to fix panthor then...

That + updating the log to something like "sram-supply is missing in the DT" would be quite better I think. It would make the issue more obvious and convey that the DT file is expected to configure that field explicitly. With the current log message, not many people will understand the problem at a glance.

As for the bug I described in this patch, we can proceed with the alternative solution (updating the DT file) that I mentioned in the Zulip thread (the link is included in the patch). Which is this simple diff:

(quoted diff) +0 -0

b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi index dafad29f9854..a30339fd2c10 100644

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +2 -1
@@ -177,6 +177,7 @@ &gmac1_rgmii_clk
 
 &gpu {
        mali-supply = <&vdd_gpu_s0>;
+       sram-supply = <&vdd_gpu_mem_s0>;
        status = "okay";
 };
 
@@ -537,7 +538,7 @@ rk806_dvs3_null: dvs3-null-pins {
                };
 
                regulators {
-                       vdd_gpu_s0: dcdc-reg1 {
+                       vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {
                                regulator-name = "vdd_gpu_s0";
                                regulator-boot-on;
                                regulator-min-microvolt = <550000>;

Note that this only fixes the issue for the Orange Pi 5. If we want to go further, the same approach should be applied to many other boards as well. I can generate a list of the DT files (using a simple Python script) that need this update over the weekend.

If we want to go even further and fix all DT files to properly include sram-supply we could also enforce that DT files do not omit sram-supply in the future. I am not sure this is strictly necessary but it also doesn't seem consistent to leave things as they are. Right now, some DT files include sram-supply even when there is no separate SRAM rail, while others do not. As a result, some boards will continue to print that annoying log message.

It's not very clear which approach is best.

#9 lore raw
Quoted 55 lines · Onur Özkan
Quoted 18 lines · On Thu, 12 Feb 2026 14:51:34 +0100 Boris Brezillon…
Quoted 15 lines · On Thu, 12 Feb 2026 13:13:31 +0000 Mark Brown <[email protected]> wrote:
Quoted 13 lines · Boris Brezillon
Quoted 5 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

Quoted 8 lines
Quoted 5 lines

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

Okay, I guess we need to fix panthor then...

That + updating the log to something like "sram-supply is missing in the DT" would be quite better I think. It would make the issue more obvious and convey that the DT file is expected to configure that field explicitly. With the current log message, not many people will understand the problem at a glance.

As for the bug I described in this patch, we can proceed with the alternative solution (updating the DT file) that I mentioned in the Zulip thread (the link is included in the patch). Which is this simple diff:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -0
index dafad29f9854..a30339fd2c10 100644
@@ -177,6 +177,7 @@ &gmac1_rgmii_clk
 
 &gpu {
        mali-supply = <&vdd_gpu_s0>;
+       sram-supply = <&vdd_gpu_mem_s0>;
        status = "okay";
 };
 

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi rk806_dvs3_null: dvs3-null-pins { · line 541

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -1
@@ -537,7 +538,7 @@ rk806_dvs3_null: dvs3-null-pins {
                };
 
                regulators {
-                       vdd_gpu_s0: dcdc-reg1 {
+                       vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {

You don't need to define a new label, using the same supply for mali-supply and sram-supply should be fine.

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +0 -0
                                regulator-name = "vdd_gpu_s0";
                                regulator-boot-on;
                                regulator-min-microvolt = <550000>;

Note that this only fixes the issue for the Orange Pi 5. If we want to go further, the same approach should be applied to many other boards as well. I can generate a list of the DT files (using a simple Python script) that need this update over the weekend.

Yes, please, but bias the script towards using the same regulator as mali-supply.

Quoted 10 lines

If we want to go even further and fix all DT files to properly include sram-supply we could also enforce that DT files do not omit sram-supply in the future. I am not sure this is strictly necessary but it also doesn't seem consistent to leave things as they are. Right now, some DT files include sram-supply even when there is no separate SRAM rail, while others do not. As a result, some boards will continue to print that annoying log message.

It's not very clear which approach is best.

I'm in favor of the proposal here, where we make sram-supply mandatory for non-"mt8196-mali" SoCs and we patch the DTs to add the sram-supply for those.

Best regards,
Liviu

Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#10 lore raw

Hi,

Quoted 85 lines · On Fri, 13 Feb 2026 12:15:47 +0000 Liviu Dudau <[email protected]> wrote:
Quoted 55 lines · Onur Özkan
Quoted 18 lines · On Thu, 12 Feb 2026 14:51:34 +0100 Boris Brezillon…
Quoted 15 lines · On Thu, 12 Feb 2026 13:13:31 +0000 Mark Brown <[email protected]> wrote:
Quoted 13 lines · Boris Brezillon
Quoted 5 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

Quoted 8 lines
Quoted 5 lines

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

Okay, I guess we need to fix panthor then...

That + updating the log to something like "sram-supply is missing in the DT" would be quite better I think. It would make the issue more obvious and convey that the DT file is expected to configure that field explicitly. With the current log message, not many people will understand the problem at a glance.

As for the bug I described in this patch, we can proceed with the alternative solution (updating the DT file) that I mentioned in the Zulip thread (the link is included in the patch). Which is this simple diff:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -0
index dafad29f9854..a30339fd2c10 100644
@@ -177,6 +177,7 @@ &gmac1_rgmii_clk
 
 &gpu {
        mali-supply = <&vdd_gpu_s0>;
+       sram-supply = <&vdd_gpu_mem_s0>;
        status = "okay";
 };
 

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi rk806_dvs3_null: dvs3-null-pins { · line 541

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -1
@@ -537,7 +538,7 @@ rk806_dvs3_null: dvs3-null-pins {
                };
 
                regulators {
-                       vdd_gpu_s0: dcdc-reg1 {
+                       vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {  

You don't need to define a new label, using the same supply for mali-supply and sram-supply should be fine.

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +0 -0
                                regulator-name = "vdd_gpu_s0";
                                regulator-boot-on;
                                regulator-min-microvolt = <550000>;

Note that this only fixes the issue for the Orange Pi 5. If we want to go further, the same approach should be applied to many other boards as well. I can generate a list of the DT files (using a simple Python script) that need this update over the weekend.

Yes, please, but bias the script towards using the same regulator as mali-supply.

Quoted 9 lines

If we want to go even further and fix all DT files to properly include sram-supply we could also enforce that DT files do not omit sram-supply in the future. I am not sure this is strictly necessary but it also doesn't seem consistent to leave things as they are. Right now, some DT files include sram-supply even when there is no separate SRAM rail, while others do not. As a result, some boards will continue to print that annoying log message.

Quoted 4 lines
Quoted 1 line

It's not very clear which approach is best.

I'm in favor of the proposal here, where we make sram-supply mandatory for non-"mt8196-mali" SoCs and we patch the DTs to add the sram-supply for those.

Works for me. Thanks for chiming in Liviu.

Regards,

Boris

author reviewer
#11 lore raw
In reply to Liviu Dudau

Hi Liviu,

Thank you for reviewing this.

Quoted 59 lines · On Fri, 13 Feb 2026 12:15:47 +0000 Liviu Dudau <[email protected]> wrote:
Quoted 58 lines · Onur Özkan
Quoted 19 lines · On Thu, 12 Feb 2026 14:51:34 +0100 Boris Brezillon…
Quoted 16 lines · On Thu, 12 Feb 2026 13:13:31 +0000 Mark Brown <[email protected]> wrote:
Quoted 14 lines · Boris Brezillon
Quoted 6 lines · Mark Brown

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Trying to open code this just breaks the error handling.

Maybe, but the thing is, the DT bindings have been accepted already, and it's not something we can easily change. What we can do is make this sram-supply mandatory for new compatibles, but we can't force it on older/existing SoCs without breaking backward-DT compat.

Quoted 8 lines
Quoted 5 lines

In practice you can because we do sub in a dummy regulator for missing supplies, it produces a warning but works fine. If we didn't do this it'd be basically impossible to add regulator support to anything at any point after the original merge which is clearly not reasonable.

Okay, I guess we need to fix panthor then...

That + updating the log to something like "sram-supply is missing in the DT" would be quite better I think. It would make the issue more obvious and convey that the DT file is expected to configure that field explicitly. With the current log message, not many people will understand the problem at a glance.

As for the bug I described in this patch, we can proceed with the alternative solution (updating the DT file) that I mentioned in the Zulip thread (the link is included in the patch). Which is this simple diff:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -0
index dafad29f9854..a30339fd2c10 100644
@@ -177,6 +177,7 @@ &gmac1_rgmii_clk
 
 &gpu {
        mali-supply = <&vdd_gpu_s0>;
+       sram-supply = <&vdd_gpu_mem_s0>;
        status = "okay";
 };
 
@@ -537,7 +538,7 @@ rk806_dvs3_null: dvs3-null-pins {
                };
 
Quoted 7 lines

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi rk806_dvs3_null: dvs3-null-pins { · line 541

Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +1 -1
                regulators {
-                       vdd_gpu_s0: dcdc-reg1 {
+                       vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {

You don't need to define a new label, using the same supply for mali-supply and sram-supply should be fine.

That also works but I never seen that usage (sram-supply = <&vdd_gpu_s0>) anywhere in the tree and I wanted to follow the current standard.

Quoted 21 lines
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +0 -0
                                regulator-name = "vdd_gpu_s0";
                                regulator-boot-on;
                                regulator-min-microvolt = <550000>;

Note that this only fixes the issue for the Orange Pi 5. If we want to go further, the same approach should be applied to many other boards as well. I can generate a list of the DT files (using a simple Python script) that need this update over the weekend.

Yes, please, but bias the script towards using the same regulator as mali-supply.

Quoted 9 lines

If we want to go even further and fix all DT files to properly include sram-supply we could also enforce that DT files do not omit sram-supply in the future. I am not sure this is strictly necessary but it also doesn't seem consistent to leave things as they are. Right now, some DT files include sram-supply even when there is no separate SRAM rail, while others do not. As a result, some boards will continue to print that annoying log message.

Quoted 6 lines
Quoted 1 line

It's not very clear which approach is best.

I'm in favor of the proposal here, where we make sram-supply mandatory for non-"mt8196-mali" SoCs and we patch the DTs to add the sram-supply for those.

Cool!

Regards,
Onur

Quoted 4 lines

Best regards,
Liviu

#12 lore raw
In reply to Mark Brown
Quoted 8 lines · Mark Brown
Quoted 6 lines · Onur Özkan
Quoted 5 lines · Mark Brown
Quoted 1 line · Onur Özkan

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

Quoted 8 lines
Quoted 4 lines

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

The panthor driver is buggy here and should be fixed, the driver should treat the supply as mandatory and let the system integration work out how it's actually made available.

Please note that the sram supply is mandatory in all compatibles except for the "mt8196-mali". This was to work around the fact that MTK has decided to control some supplies via another method and not give Panthor control over those.

We should fix Panthor to check that we only treat the sram supply as optional for "mt8196-mali", but that doesn't alleviate Tyr's need to support optional regulators.

Best regards,
Liviu

Quoted 2 lines

Trying to open code this just breaks the error handling.

Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
maintainer
#13 lore raw
Quoted 8 lines · Liviu Dudau

Please note that the sram supply is mandatory in all compatibles except for the "mt8196-mali". This was to work around the fact that MTK has decided to control some supplies via another method and not give Panthor control over those.

We should fix Panthor to check that we only treat the sram supply as optional for "mt8196-mali", but that doesn't alleviate Tyr's need to support optional regulators.

If you know that the supply will never be present for that compatible then the driver shouldn't really be requesting it in the first place.

Reviewed-by
#14 lore raw
In reply to Onur Özkan
Quoted 13 lines · On Thu, 12 Feb 2026 15:16:44 +0300 Onur Özkan <[email protected]> wrote:
Quoted 10 lines · On Thu, 12 Feb 2026 11:34:41 +0000 Mark Brown <[email protected]> wrote:
Quoted 8 lines · Onur Özkan

On rk3588s, dmesg | grep 'tyr' logs:

tyr fb000000.gpu: supply SRAM not found, using dummy regulator

This happens because Tyr calls Regulator<Enabled>::get() for SRAM, which goes through the non-optional regulator_get() path. If the device tree doesn't provide sram-supply, regulator core falls back to a dummy regulator and writes that log.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Panthor handles SRAM as optional and tolerates missing sram-supply.

Does the RAM really work without power?

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

Yep, some SoC integration have just one power-rail for everything in the GPU, others have two. The sram-supply is documented as optional in the DT bindings, so I think that's the right thing to do.

Quoted 2 lines

- Onur

maintainer
#15 lore raw
Quoted 10 lines · Boris Brezillon
Quoted 4 lines · Onur Özkan

If the platform has no separate sram-supply (meaning that rail is coupled to mali), RAM should still be powered and work fine. Panthor already relies on this model by treating sram-supply as optional and as far as I can see there are no RAM issues on Panthor.

Yep, some SoC integration have just one power-rail for everything in the GPU, others have two. The sram-supply is documented as optional in the DT bindings, so I think that's the right thing to do.

This is expected to be handled through platform integration of the device, not through bodges like this.