staging: octeon: fix free_irq dev_id mismatch in cvm_oct_rx_shutdown
PATCH 1/1 staging: octeon: fix free_irq dev_id mismatch in cvm_oct_rx_shutdown
In cvm_oct_rx_initialize(), request_irq() is called with &oct_rx_group[i].napi as the dev_id:
request_irq(oct_rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &oct_rx_group[i].napi);
However, cvm_oct_rx_shutdown() passes cvm_oct_device (an array of struct net_device pointers) as the dev_id to free_irq():
free_irq(oct_rx_group[i].irq, cvm_oct_device);
Since __free_irq() matches the action to remove by comparing dev_id pointers, the mismatched cookie means the IRQ handler is never found, triggering a WARN and leaving the IRQ line permanently allocated. This prevents proper driver cleanup on module removal.
Fix the mismatch by passing &oct_rx_group[i].napi as the dev_id to free_irq(), matching what was used during request_irq().
Signed-off-by Yuvraj Singh Chauhan <[email protected]>
--- drivers/staging/octeon/ethernet-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/octeon/ethernet-rx.c +1 -1
@@ -535,7 +535,7 @@ void cvm_oct_rx_shutdown(void)cvmx_write_csr (CVMX_POW_WQ_INT_THRX (i),0 );/* Free the interrupt handler */ -free_irq (oct_rx_group[i].irq, cvm_oct_device); +free_irq (oct_rx_group[i].irq, &oct_rx_group[i].napi);netif_napi_del (&oct_rx_group[i].napi); }
Signature · 1 line
2.43.0