Skip to contentSkip to conversation

libbpf: Fix perm errors for LDIMM_64_FULL_RANGE_OFF use

PATCH Superseded Emil Tsalapatis 1 participant 3 messages Feb 13

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Emil Tsalapatis

author reviewer
#0 lore raw

cover libbpf: Fix perm errors for LDIMM_64_FULL_RANGE_OFF use

Commit 677755d502df ("libbpf: Add gating for arena globals relocation feature") adds a feature flag for testing whether the running kernel supports LDIMM64 instructions with large direct offsets. Fix two edge cases that can cause unexpected -EPERM errors in two ways:

1) The probe program used for the feature has type TRACEPOINT, but it's possible the caller does not have permission to load it, even if it is able to do so for generic BPF programs. Use the SOCKET_FILTER type instead that requires fewer permissions. This does not affect the check itself, which will always fail verification anyway.

2) The probe is triggered during bpf_object__collect_relos(), itself called in bpf_object_open(), to compute the arena relocation offsets of arena variables. However, the caller may not have permissions to load BPF programs. This is the case in some systems with the bpftool calls made by the BPF selftests during compilation, e.g., for skeleton generation. Move all uses of the feature check to bpf_object_prepare() time instead.

Fixes 677755d502df ("libbpf: Add gating for arena globals relocation feature")

Emil Tsalapatis (2):
libbpf: Do not use PROG_TYPE_TRACEPOINT program for feature gating
libbpf: Delay feature gate check until object prepare time

 tools/lib/bpf/features.c |  4 ++--
 tools/lib/bpf/libbpf.c   | 31 +++++++++++++++++++++++--------
 2 files changed, 25 insertions(+), 10 deletions(-)
Signature · 1 line
2.49.0
author reviewer
#1 lore raw

PATCH 1/2 libbpf: Do not use PROG_TYPE_TRACEPOINT program for feature gating

Commit 677755d502df uses a PROG_TYPE_TRACEPOINT BPF test program to check whether the running kernel supports large LDIMM64 offsets. The feature gate incorrectly assumes that the program will fail at verification time with one of two messages, depending on whether the feature is supported by the running kernel. However, PROG_TYPE_TRACEPOINT programs may fail to load before verification even starts, e.g., if the shell does not have the appropriate capabilities. Use a BPF_PROG_TYPE_SOCKET_FILTER program for the feature gate instead.

Also ensure the log buffer for the test is initialized: Failing program load before verification led to libbpf dumping uninitialized data to stdout.

Fixes 677755d502df ("libbpf: Add gating for arena globals relocation feature")
---
 tools/lib/bpf/features.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/lib/bpf/features.c +2 -2
index b65ab109e3ff..0d432072f46e 100644
@@ -508,7 +508,7 @@ static int probe_kern_arg_ctx_tag(int token_fd)
 
 static int probe_ldimm64_full_range_off(int token_fd)
 {
-	char log_buf[1024];
+	char log_buf[1024] = {};
 	int prog_fd, map_fd;
 	int ret;
 	LIBBPF_OPTS(bpf_map_create_opts, map_opts,
@@ -536,7 +536,7 @@ static int probe_ldimm64_full_range_off(int token_fd)
 	}
 	insns[0].imm = map_fd;
 
-	prog_fd = bpf_prog_load(BPF_PROG_TYPE_TRACEPOINT, "global_reloc", "GPL", insns, insn_cnt, &prog_opts);
+	prog_fd = bpf_prog_load(BPF_PROG_TYPE_SOCKET_FILTER, "global_reloc", "GPL", insns, insn_cnt, &prog_opts);
 	ret = -errno;
 
 	close(map_fd);
Signature · 1 line
2.49.0
author reviewer
#2 lore raw

PATCH 2/2 libbpf: Delay feature gate check until object prepare time

In reply to Emil Tsalapatis

Commit 677755d502df ("libbpf: Add gating for arena globals relocation feature") adds a feature gate check that loads a map and BPF program to
test the running kernel supports large direct offsets for LDIMM64 instructions. This check is currently used to calculate arena symbol offsets during bpf_object__collect_relos, itself called by bpf_object_open.

However, the program calling bpf_object_open may not have the permissions to load maps and programs. This is the case with the BPF selftests, where bpftool is invoked at compilation time during skeleton generation. This causes errors as the feature gate unexpectedly fails with -EPERM.

Avoid this by moving all uses of the FEAT_LDIMM64_FULL_RANGE_OFF feature gate to BPF object preparation time instead.

Fixes 677755d502df ("libbpf: Add gating for arena globals relocation feature")
---
 tools/lib/bpf/libbpf.c | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)
tools/lib/bpf/libbpf.c +23 -8
index 93e59ed8d9a1..ff38a9db1b13 100644
@@ -3009,11 +3009,11 @@ static int init_arena_map_data(struct bpf_object *obj, struct bpf_map *map,
 	memcpy(obj->arena_data, data, data_sz);
 	obj->arena_data_sz = data_sz;
 
-	/* place globals at the end of the arena (if supported) */
-	if (kernel_supports(obj, FEAT_LDIMM64_FULL_RANGE_OFF))
-		obj->arena_data_off = mmap_sz - data_alloc_sz;
-	else
-		obj->arena_data_off = 0;
+	/*
+	 * possible offset for arena globals into the arena,
+	 * if supported at load time
+	 */
+	obj->arena_data_off = mmap_sz - data_alloc_sz;
 
 	/* make bpf_map__init_value() work for ARENA maps */
 	map->mmaped = obj->arena_data;
@@ -4672,7 +4672,7 @@ static int bpf_program__record_reloc(struct bpf_program *prog,
 		reloc_desc->type = RELO_DATA;
 		reloc_desc->insn_idx = insn_idx;
 		reloc_desc->map_idx = obj->arena_map_idx;
-		reloc_desc->sym_off = sym->st_value + obj->arena_data_off;
+		reloc_desc->sym_off = sym->st_value;
 
 		map = &obj->maps[obj->arena_map_idx];
 		pr_debug("prog '%s': found arena map %d (%s, sec %d, off %zu) for insn %u\n",
@@ -5556,6 +5556,7 @@ bpf_object__create_maps(struct bpf_object *obj)
 {
 	struct bpf_map *map;
 	unsigned int i, j;
+	char *arena_globals;
 	int err;
 	bool retried;
 
@@ -5633,7 +5634,15 @@ bpf_object__create_maps(struct bpf_object *obj)
 					return err;
 				}
 				if (obj->arena_data) {
-					memcpy(map->mmaped + obj->arena_data_off, obj->arena_data,
+					/*
+					 * Only relocate the globals to the end of the arena
+					 * if the kernel supports it.
+					 */
+					arena_globals = map->mmaped;
+					if (kernel_supports(obj, FEAT_LDIMM64_FULL_RANGE_OFF))
+						arena_globals += obj->arena_data_off;
+
+					memcpy(arena_globals, obj->arena_data,
 						obj->arena_data_sz);
 					zfree(&obj->arena_data);
 				}
@@ -6386,6 +6395,12 @@ bpf_object__relocate_data(struct bpf_object *obj, struct bpf_program *prog)
 		case RELO_DATA:
 			map = &obj->maps[relo->map_idx];
 			insn[1].imm = insn[0].imm + relo->sym_off;
+
+			if (relo->map_idx == obj->arena_map_idx &&
+			    kernel_supports(obj, FEAT_LDIMM64_FULL_RANGE_OFF)) {
+				insn[1].imm += obj->arena_data_off;
+			}
+
 			if (obj->gen_loader) {
 				insn[0].src_reg = BPF_PSEUDO_MAP_IDX_VALUE;
 				insn[0].imm = relo->map_idx;
@@ -14456,7 +14471,7 @@ int bpf_object__load_skeleton(struct bpf_object_skeleton *s)
 		if (!map_skel->mmaped)
 			continue;
 
-		if (map->def.type == BPF_MAP_TYPE_ARENA)
+		if (map->def.type == BPF_MAP_TYPE_ARENA && kernel_supports(*s->obj, FEAT_LDIMM64_FULL_RANGE_OFF))
 			*map_skel->mmaped = map->mmaped + map->obj->arena_data_off;
 		else
 			*map_skel->mmaped = map->mmaped;
Signature · 1 line
2.49.0