Skip to contentSkip to conversation

staging: axis-fifo: remove unused header includes

PATCH In review Rajveer Chaudhari 2 participants 2 messages Feb 14 – Feb 23 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: axis-fifo: remove unused header includes

Remove unused header includes from axis-fifo.c to reduce unnecessary dependencies and improve compilation time.

Replaced kernel.h include with container_of.h to directly include dependency instead of using it indirectly via kernel.h .

---
 drivers/staging/axis-fifo/axis-fifo.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +1 -4
index 509d620d6ce7..c90bf2d841ce 100644
@@ -14,7 +14,7 @@
  * ----------------------------
  */
 
-#include <linux/kernel.h>
+#include <linux/container_of.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/wait.h>
@@ -27,9 +27,6 @@
 #include <linux/io.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>
-#include <linux/param.h>
-#include <linux/fs.h>
-#include <linux/types.h>
 #include <linux/uaccess.h>
 #include <linux/jiffies.h>
 #include <linux/miscdevice.h>
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 38 lines · Rajveer Chaudhari

Remove unused header includes from axis-fifo.c to reduce unnecessary dependencies and improve compilation time.

Replaced kernel.h include with container_of.h to directly include dependency instead of using it indirectly via kernel.h .

---
 drivers/staging/axis-fifo/axis-fifo.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +1 -4
index 509d620d6ce7..c90bf2d841ce 100644
@@ -14,7 +14,7 @@
  * ----------------------------
  */
 
-#include <linux/kernel.h>
+#include <linux/container_of.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/wait.h>
@@ -27,9 +27,6 @@
 #include <linux/io.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>
-#include <linux/param.h>
-#include <linux/fs.h>
-#include <linux/types.h>
 #include <linux/uaccess.h>
 #include <linux/jiffies.h>
 #include <linux/miscdevice.h>
Signature · 1 line
2.53.0

Does not apply to 7.0-rc1 :(