Skip to contentSkip to conversation

linux: make license option visible for _CUSTOM_VERSION as well

PATCH Applied Peter Korsgaard 2 participants 10 messages Feb 15 – Feb 26

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 linux: make license option visible for _CUSTOM_VERSION as well

Commit 50958bcdac ("linux: Add support for custom license files") added a default value for the license files and made the option visible (E.G. editable) when a custom VCS or tarball version is used, but it is also needed for users of an older _CUSTOM_VERSION (E.G. mainline release), as the referenced files were only added in Linux 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so change that.

---
 linux/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/Config.in +1 -1
index 9d96b346d5..c136084afd 100644
@@ -152,7 +152,7 @@ config BR2_LINUX_KERNEL_VERSION
 
 config BR2_LINUX_KERNEL_LICENSE_FILES
 	string "Kernel license files" if BR2_LINUX_KERNEL_CUSTOM_GIT || BR2_LINUX_KERNEL_CUSTOM_HG || \
-		BR2_LINUX_KERNEL_CUSTOM_SVN || BR2_LINUX_KERNEL_CUSTOM_TARBALL
+		BR2_LINUX_KERNEL_CUSTOM_SVN || BR2_LINUX_KERNEL_CUSTOM_VERSION || BR2_LINUX_KERNEL_CUSTOM_TARBALL
 	default "COPYING LICENSES/preferred/GPL-2.0 LICENSES/exceptions/Linux-syscall-note"
 	help
 	  A space-separated list of license files related to the Linux
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 sheevaplug_defconfig: specify Linux license file

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

make legal-info
..
cp: cannot stat '/path/to/output/build/linux-headers-4.14.336/LICENSES/preferred/GPL-2.0': No such file or directory

And add the sha256sum to the .hash file.

---
 board/sheevaplug/patches/linux/linux.hash | 1 +
 configs/sheevaplug_defconfig              | 1 +
 2 files changed, 2 insertions(+)
board/sheevaplug/patches/linux/linux.hash +1 -0
index b207306a2b..aa432012b0 100644
@@ -1,2 +1,3 @@
 # Locally calculated
 sha256  0820fdb7971c6974338081c11fbf2dc869870501e7bdcac4d0ed58ba1f57b61c  linux-4.14.336.tar.xz
+sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
configs/sheevaplug_defconfig +1 -0
index 855efedafa..a6a324213c 100644
@@ -7,6 +7,7 @@ BR2_SYSTEM_DHCP="eth0"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.336"
+BR2_LINUX_KERNEL_LICENSE_FILES="COPYING"
 BR2_LINUX_KERNEL_DEFCONFIG="mvebu_v5"
 BR2_LINUX_KERNEL_APPENDED_UIMAGE=y
 BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x8000"
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/3] sheevaplug_defconfig: specify Linux license file

In reply of:

Quoted 11 lines

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

make legal-info
..
cp: cannot stat '/path/to/output/build/linux-headers-4.14.336/LICENSES/preferred/GPL-2.0': No such file or directory

And add the sha256sum to the .hash file.

Applied to 2025.02.x & 2025.11.x. Thanks

Quoted 32 lines
---
 board/sheevaplug/patches/linux/linux.hash | 1 +
 configs/sheevaplug_defconfig              | 1 +
 2 files changed, 2 insertions(+)
board/sheevaplug/patches/linux/linux.hash +1 -0
index b207306a2b..aa432012b0 100644
@@ -1,2 +1,3 @@
 # Locally calculated
 sha256  0820fdb7971c6974338081c11fbf2dc869870501e7bdcac4d0ed58ba1f57b61c  linux-4.14.336.tar.xz
+sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
configs/sheevaplug_defconfig +1 -0
index 855efedafa..a6a324213c 100644
@@ -7,6 +7,7 @@ BR2_SYSTEM_DHCP="eth0"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.336"
+BR2_LINUX_KERNEL_LICENSE_FILES="COPYING"
 BR2_LINUX_KERNEL_DEFCONFIG="mvebu_v5"
 BR2_LINUX_KERNEL_APPENDED_UIMAGE=y
 BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x8000"
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

PATCH 3/3 openblocks_a6_defconfig: specify Linux license file

In reply to Peter Korsgaard

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

make legal-info
..
cp: cannot stat '/path/to/output/build/linux-headers-4.14.336/LICENSES/preferred/GPL-2.0': No such file or directory

And add the sha256sum to the .hash file.

---
 board/openblocks/a6/patches/linux/linux.hash | 1 +
 1 file changed, 1 insertion(+)
board/openblocks/a6/patches/linux/linux.hash +1 -0
index b207306a2b..aa432012b0 100644
@@ -1,2 +1,3 @@
 # Locally calculated
 sha256  0820fdb7971c6974338081c11fbf2dc869870501e7bdcac4d0ed58ba1f57b61c  linux-4.14.336.tar.xz
+sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 3/3] openblocks_a6_defconfig: specify Linux license file

Hello!

Quoted 3 lines · Peter Korsgaard

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

Note that there are three other defconfigs with kernels older than 4.16:

* s6lx9_microboard_defconfig (4.4.7)
* ts4900_defconfig (4.12)
* ts5500_defconfig (4.14)

Regards,

Edgar Bonet.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH 3/3] openblocks_a6_defconfig: specify Linux license file

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Edgar" == Edgar Bonet <[email protected]> writes:

Hello!

Quoted 3 lines · Peter Korsgaard

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

Quoted 5 lines

Note that there are three other defconfigs with kernels older than 4.16:

* s6lx9_microboard_defconfig (4.4.7)
* ts4900_defconfig (4.12)
* ts5500_defconfig (4.14)

True. I wonder if those defconfigs are still useful, given that they haven't been updated in a very long time:

- s6lx9_microboard_defconfig: When it was added in 2012.05
- ts4900_defconfig: 2017.11, no DEVELOPERS entry
- ts5500_defconfig: 2018.05

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#6 lore raw

Re: [Buildroot] [PATCH 3/3] openblocks_a6_defconfig: specify Linux license file

In reply to Peter Korsgaard

In reply of:

Quoted 11 lines

The used Linux kernel (4.14.336) does not contain the default license files as those were only added in 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so specify the correct license file to fix:

make legal-info
..
cp: cannot stat '/path/to/output/build/linux-headers-4.14.336/LICENSES/preferred/GPL-2.0': No such file or directory

And add the sha256sum to the .hash file.

Applied to 2025.02.x & 2025.11.x. Thanks

Quoted 19 lines
---
 board/openblocks/a6/patches/linux/linux.hash | 1 +
 1 file changed, 1 insertion(+)
board/openblocks/a6/patches/linux/linux.hash +1 -0
index b207306a2b..aa432012b0 100644
@@ -1,2 +1,3 @@
 # Locally calculated
 sha256  0820fdb7971c6974338081c11fbf2dc869870501e7bdcac4d0ed58ba1f57b61c  linux-4.14.336.tar.xz
+sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw
In reply to Peter Korsgaard
Quoted 8 lines · Peter Korsgaard

Commit 50958bcdac ("linux: Add support for custom license files") added a default value for the license files and made the option visible (E.G. editable) when a custom VCS or tarball version is used, but it is also needed for users of an older _CUSTOM_VERSION (E.G. mainline release), as the referenced files were only added in Linux 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so change that.

Applied to master. For info, I added the missing BR2_LINUX_KERNEL_LICENSE_FILES in openblocks_a6_defconfig.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#8 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Julien" == Julien Olivain <[email protected]> writes:

Hi,

Quoted 2 lines

Applied to master. For info, I added the missing BR2_LINUX_KERNEL_LICENSE_FILES in openblocks_a6_defconfig.

Argh, seems like I forgot to save after editing. Thanks for fixing it!

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#9 lore raw
In reply to Peter Korsgaard

In reply of:

Quoted 8 lines

Commit 50958bcdac ("linux: Add support for custom license files") added a default value for the license files and made the option visible (E.G. editable) when a custom VCS or tarball version is used, but it is also needed for users of an older _CUSTOM_VERSION (E.G. mainline release), as the referenced files were only added in Linux 4.16 with commit e00a844aca ("LICENSES: Add Linux syscall note exception"), so change that.

Applied to 2025.02.x & 2025.11.x. Thanks

Quoted 24 lines
---
 linux/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/Config.in +1 -1
index 9d96b346d5..c136084afd 100644
@@ -152,7 +152,7 @@ config BR2_LINUX_KERNEL_VERSION
 
 config BR2_LINUX_KERNEL_LICENSE_FILES
 	string "Kernel license files" if BR2_LINUX_KERNEL_CUSTOM_GIT || BR2_LINUX_KERNEL_CUSTOM_HG || \
-		BR2_LINUX_KERNEL_CUSTOM_SVN || BR2_LINUX_KERNEL_CUSTOM_TARBALL
+		BR2_LINUX_KERNEL_CUSTOM_SVN || BR2_LINUX_KERNEL_CUSTOM_VERSION || BR2_LINUX_KERNEL_CUSTOM_TARBALL
 	default "COPYING LICENSES/preferred/GPL-2.0 LICENSES/exceptions/Linux-syscall-note"
 	help
 	  A space-separated list of license files related to the Linux
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot