selftests/mm: skip migration tests if NUMA is unavailable
Subsystems (3)
PATCH 1/1 selftests/mm: skip migration tests if NUMA is unavailable
Currently, the migration test asserts that numa_available() returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.
Update the test to check the return value of numa_available(). If it is less than 0, skip the test gracefully instead of failing.
This aligns the behavior with other MM selftests (like rmap) that skip when NUMA support is missing.
--- tools/testing/selftests/mm/migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/mm/migration.c +2 -1
@@ -36,7 +36,8 @@ FIXTURE_SETUP(migration) {int n; -ASSERT_EQ (numa_available (),0 ); +if (numa_available () <0 ) +SKIP (return,"NUMA not available" ); self->nthreads =numa_num_task_cpus () -1 ; self->n1 =-1 ; self->n2 =-1 ;
Signature · 1 line
2.51.0
Quoted 5 lines · On Wed, 18 Feb 2026 11:39:41 -0500 AnishMulay <[email protected]> wrote:
Currently, the migration test asserts that
numa_available()returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.
Quoted 7 lines
Update the test to check the return value of
numa_available(). If it is less than 0, skip the test gracefully instead of failing.This aligns the behavior with other MM selftests (like rmap) that skip when NUMA support is missing.
Signed-off-by AnishMulay <[email protected]>
Thanks,
SJ
[...]
Quoted 5 lines · AnishMulay
Currently, the migration test asserts that
numa_available()returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.
Quoted 8 lines
Update the test to check the return value of
numa_available(). If it is less than 0, skip the test gracefully instead of failing.This aligns the behavior with other MM selftests (like rmap) that skip when NUMA support is missing.
Signed-off-by AnishMulay <[email protected]>---
Quoted 17 lines
tools/testing/selftests/mm/migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/mm/migration.c +2
-1@@ -36,7 +36,8 @@ FIXTURE_SETUP(migration) {int n; -ASSERT_EQ (numa_available (),0 ); +if (numa_available () <0 ) +SKIP (return,"NUMA not available" ); self->nthreads =numa_num_task_cpus () -1 ; self->n1 =-1 ; self->n2 =-1 ;
Quoted 21 lines · AnishMulay
Currently, the migration test asserts that
numa_available()returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.Update the test to check the return value of
numa_available(). If it is less than 0, skip the test gracefully instead of failing.This aligns the behavior with other MM selftests (like rmap) that skip when NUMA support is missing.
Signed-off-by AnishMulay <[email protected]>--- tools/testing/selftests/mm/migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/mm/migration.c +0
-0
tools/testing/selftests/mm/migration.c FIXTURE_SETUP(migration) · line 43
Quoted 9 lines
tools/testing/selftests/mm/migration.c +2
-1@@ -36,7 +36,8 @@ FIXTURE_SETUP(migration) {int n; -ASSERT_EQ (numa_available (),0 ); +if (numa_available () <0 ) +SKIP (return,"NUMA not available" ); self->nthreads =numa_num_task_cpus () -1 ; self->n1 =-1 ; self->n2 =-1 ;
Hi Anish,
Quoted 5 lines · AnishMulay
Currently, the migration test asserts that
numa_available()returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.
Quoted 7 lines
Update the test to check the return value of
numa_available(). If it is less than 0, skip the test gracefully instead of failing.This aligns the behavior with other MM selftests (like rmap) that skip when NUMA support is missing.
Signed-off-by AnishMulay <[email protected]>
I tested it on my system and its skipping the test if NUMA not available.
TAP version 13
1..6
# Starting 6 tests from 1 test cases.
# RUN migration.private_anon ...
# SKIP NUMA not available
# OK migration.private_anon
ok 1 migration.private_anon # SKIP NUMA not available
# RUN migration.shared_anon ...
# SKIP NUMA not available
# OK migration.shared_anon
ok 2 migration.shared_anon # SKIP NUMA not available
# RUN migration.private_anon_thp ...
# SKIP NUMA not available
# OK migration.private_anon_thp
ok 3 migration.private_anon_thp # SKIP NUMA not available
# RUN migration.shared_anon_thp ...
# SKIP NUMA not available
# OK migration.shared_anon_thp
ok 4 migration.shared_anon_thp # SKIP NUMA not available
# RUN migration.private_anon_htlb ...
# SKIP NUMA not available
# OK migration.private_anon_htlb
ok 5 migration.private_anon_htlb # SKIP NUMA not available
# RUN migration.shared_anon_htlb ...
# SKIP NUMA not available
# OK migration.shared_anon_htlb
ok 6 migration.shared_anon_htlb # SKIP NUMA not available
# PASSED: 6 / 6 tests passed.
# 6 skipped test(s) detected. Consider enabling relevant config options to improve c overage.
# Totals: pass:0 fail:0 xfail:0 xpass:0 skip:6 error:0
Thanks,
Sayali
Quoted 18 lines
--- tools/testing/selftests/mm/migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/mm/migration.c +2
-1@@ -36,7 +36,8 @@ FIXTURE_SETUP(migration) {int n; -ASSERT_EQ (numa_available (),0 ); +if (numa_available () <0 ) +SKIP (return,"NUMA not available" ); self->nthreads =numa_num_task_cpus () -1 ; self->n1 =-1 ; self->n2 =-1 ;
Quoted 4 lines · AnishMulay
Currently, the migration test asserts that
numa_available()returns 0. On systems where NUMA is not available (returning -1), such as certain ARM64 configurations or single-node systems, this assertion fails and crashes the test.
Single-node system (my notebook)
$ ./migration TAP version 13 1..6 # Starting 6 tests from 1 test cases. # RUN migration.private_anon ... # SKIP Not enough threads or NUMA nodes available # OK migration.private_anon ok 1 migration.private_anon # SKIP Not enough threads or NUMA nodes available # RUN migration.shared_anon ... # SKIP Not enough threads or NUMA nodes available # OK migration.shared_anon ok 2 migration.shared_anon # SKIP Not enough threads or NUMA nodes available # RUN migration.private_anon_thp ... # SKIP Not enough threads or NUMA nodes available # OK migration.private_anon_thp ok 3 migration.private_anon_thp # SKIP Not enough threads or NUMA nodes available # RUN migration.shared_anon_thp ... # SKIP Not enough threads or NUMA nodes available # OK migration.shared_anon_thp ok 4 migration.shared_anon_thp # SKIP Not enough threads or NUMA nodes available # RUN migration.private_anon_htlb ... # SKIP Not enough threads or NUMA nodes available # OK migration.private_anon_htlb ok 5 migration.private_anon_htlb # SKIP Not enough threads or NUMA nodes available # RUN migration.shared_anon_htlb ... # SKIP Not enough threads or NUMA nodes available # OK migration.shared_anon_htlb ok 6 migration.shared_anon_htlb # SKIP Not enough threads or NUMA nodes available # PASSED: 6 / 6 tests passed. # 6 skipped test(s) detected. Consider enabling relevant config options to improve coverage. # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:6 error:0
What numa_available() really checks is if the kernel supports NUMA by trying get_mempolicy(). If that fails with ENOSYS or EPERM.
That should mostly (cases we care about) be the case if the kernel is compiled without CONFIG_NUMA.
So a better description here would be "On kernels without CONFIG_NUMA, this assertion ..."
Given that tools/testing/selftests/mm/config does not include CONFIG_NUMA, I think we want to add here
Signature · 3 lines
Cheers, David