Skip to contentSkip to conversation

KVM: x86/mmu: Don't zero-allocate page table used for splitting a hugepage

PATCH Applied Sean Christopherson 3 participants 4 messages Feb 18 – Mar 5

Subsystems (3)
lore
Share & tools
lore

Sean Christopherson

author maintainer
#0 lore raw

PATCH 1/1 KVM: x86/mmu: Don't zero-allocate page table used for splitting a hugepage

When splitting hugepages in the TDP MMU, don't zero the new page table on allocation since tdp_mmu_split_huge_page() is guaranteed to write every entry and thus every byte.

Unless someone peeks at the memory between allocating the page table and writing the child SPTEs, no functional change intended.

---
 arch/x86/kvm/mmu/tdp_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu/tdp_mmu.c +1 -1
index 9c26038f6b77..7b1102d26f9c 100644
@@ -1507,7 +1507,7 @@ static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_split(void)
 	if (!sp)
 		return NULL;
 
-	sp->spt = (void *)get_zeroed_page(GFP_KERNEL_ACCOUNT);
+	sp->spt = (void *)__get_free_page(GFP_KERNEL_ACCOUNT);
 	if (!sp->spt) {
 		kmem_cache_free(mmu_page_header_cache, sp);
 		return NULL;

base-commit: 183bb0ce8c77b0fd1fb25874112bc8751a461e49

Signature · 1 line
2.53.0.345.g96ddfc5eaa-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Sean Christopherson

When splitting hugepages in the TDP MMU, don't zero the new page table on allocation since tdp_mmu_split_huge_page() is guaranteed to write every entry and thus every byte.

Unless someone peeks at the memory between allocating the page table and writing the child SPTEs

Didn't see any way for this to happen.

Quoted 6 lines

, no functional change intended.

---

Reviewed-by on v1 1/1
#2 lore raw
In reply to Sean Christopherson
Quoted 11 lines · Sean Christopherson

When splitting hugepages in the TDP MMU, don't zero the new page table on allocation since tdp_mmu_split_huge_page() is guaranteed to write every entry and thus every byte.

Unless someone peeks at the memory between allocating the page table and writing the child SPTEs, no functional change intended.

author maintainer Applied
#3 lore raw
In reply to Sean Christopherson
Quoted 8 lines · Sean Christopherson

When splitting hugepages in the TDP MMU, don't zero the new page table on allocation since tdp_mmu_split_huge_page() is guaranteed to write every entry and thus every byte.

Unless someone peeks at the memory between allocating the page table and writing the child SPTEs, no functional change intended.

[...]

Applied to kvm-x86 mmu, thanks!

[1/1] KVM: x86/mmu: Don't zero-allocate page table used for splitting a hugepage

      https://github.com/kvm-x86/linux/commit/ecb806293213

--
https://github.com/kvm-x86/linux/tree/next