Skip to contentSkip to conversation

arm64: dts: qcom: hamoa/x1: fix idle exit latency

PATCH Applied Daniel J Blueman 3 participants 3 messages Feb 20 – Feb 23

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: hamoa/x1: fix idle exit latency

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

Fix this to be 320us so the sum of the entry and exit latencies matches the downstream 500us exit latency, as directed by Maulik.

Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100.

Fixes 2e65616ef07f ("arm64: dts: qcom: x1e80100: Update C4/C5 residency/exit numbers")

---
Changelog:
v2:
- update exit latency

v1: https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/qcom/hamoa.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/hamoa.dtsi +1 -1
index a17900eacb20..b870f4dc9c42 100644
@@ -269,7 +269,7 @@ cluster_c4: cpu-sleep-0 {
 				idle-state-name = "ret";
 				arm,psci-suspend-param = <0x00000004>;
 				entry-latency-us = <180>;
-				exit-latency-us = <500>;
+				exit-latency-us = <320>;
 				min-residency-us = <600>;
 			};
 		};
Signature · 1 line
2.51.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Daniel J Blueman

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

Quoted 8 lines

Fix this to be 320us so the sum of the entry and exit latencies matches the downstream 500us exit latency, as directed by Maulik.

Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100.

Fixes 2e65616ef07f ("arm64: dts: qcom: x1e80100: Update C4/C5 residency/exit numbers")

---

Konrad

maintainer Applied
#2 lore raw
In reply to Daniel J Blueman
Quoted 10 lines · Daniel J Blueman

Designs based on the Qualcomm X1 Hamoa reference platform report:
driver: Idle state 1 target residency too low

This is because the declared X1 idle entry plus exit latency of 680us exceeds the declared minimum 600us residency time:
entry-latency-us = <180>;
exit-latency-us = <500>;
min-residency-us = <600>;

[...]

Applied, thanks!

[1/1] arm64: dts: qcom: hamoa/x1: fix idle exit latency

      commit: 3ecea84d2b90bbf934d5ca75514fa902fd71e03f

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>