nvme-core: do not pass empty queue_limits to blk_mq_alloc_queue()
PATCH 1/1 nvme-core: do not pass empty queue_limits to blk_mq_alloc_queue()
In nvme_alloc_admin_tag_set(), an empty queue_limits struct is currently allocated on the stack and passed by reference to blk_mq_alloc_queue().
This is redundant because blk_mq_alloc_queue() already handles a NULL limits pointer by internally substituting it with a default empty queue_limits struct.
Remove the unnecessary local variable and pass a NULL value.
--- drivers/nvme/host/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/nvme/host/core.c +1 -2
@@ -4845,7 +4845,6 @@ EXPORT_SYMBOL_GPL(nvme_complete_async_event);int nvme_alloc_admin_tag_set (struct nvme_ctrl *ctrl,struct blk_mq_tag_set *set,const struct blk_mq_ops *ops,unsigned int cmd_size) { -struct queue_limits lim = {};int ret;memset (set,0 ,sizeof (*set));
@@ -4865,7 +4864,7 @@ int nvme_alloc_admin_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,if (ret)return ret; - ctrl->admin_q =blk_mq_alloc_queue (set, &lim,NULL ); + ctrl->admin_q =blk_mq_alloc_queue (set,NULL ,NULL );if (IS_ERR (ctrl->admin_q)) { ret =PTR_ERR (ctrl->admin_q); goto out_free_tagset;
Signature · 1 line
2.53.0
Keith? Can you review this?
Thanks,
Maurizio
Quoted 35 lines · Maurizio Lombardi
In
nvme_alloc_admin_tag_set(), an emptyqueue_limitsstruct is currently allocated on the stack and passed by reference toblk_mq_alloc_queue().This is redundant because
blk_mq_alloc_queue()already handles a NULL limits pointer by internally substituting it with a default emptyqueue_limitsstruct.
Remove the unnecessary local variable and pass a NULL value.Signed-off-by Maurizio Lombardi <[email protected]>--- drivers/nvme/host/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/nvme/host/core.c +1
-2@@ -4845,7 +4845,6 @@ EXPORT_SYMBOL_GPL(nvme_complete_async_event);int nvme_alloc_admin_tag_set (struct nvme_ctrl *ctrl,struct blk_mq_tag_set *set,const struct blk_mq_ops *ops,unsigned int cmd_size) { -struct queue_limits lim = {};int ret;memset (set,0 ,sizeof (*set));@@ -4865,7 +4864,7 @@ int nvme_alloc_admin_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,if (ret)return ret; - ctrl->admin_q =blk_mq_alloc_queue (set, &lim,NULL ); + ctrl->admin_q =blk_mq_alloc_queue (set,NULL ,NULL );if (IS_ERR (ctrl->admin_q)) { ret =PTR_ERR (ctrl->admin_q); goto out_free_tagset;
Quoted 3 lines · Maurizio Lombardi
In
nvme_alloc_admin_tag_set(), an emptyqueue_limitsstruct is currently allocated on the stack and passed by reference toblk_mq_alloc_queue().
Thanks, applied.