ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
Subsystems (2)
PATCH v2 1/1 ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.
---
v2: dropped YAML and regmap.h (Niklas)
.../bindings/ata/baikal,bt1-ahci.yaml | 115 ------------------ drivers/ata/Kconfig | 1 - drivers/ata/ahci_dwc.c | 55 --------- 3 files changed, 171 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml deleted +0 -115
@@ -1,115 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/ata/baikal,bt1-ahci.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Baikal-T1 SoC AHCI SATA controller - -maintainers: - - Serge Semin <[email protected]> - -description: - AHCI SATA controller embedded into the Baikal-T1 SoC is based on the - DWC AHCI SATA v4.10a IP-core. - -allOf: - - $ref: snps,dwc-ahci-common.yaml# - -properties: - compatible: - const: baikal,bt1-ahci - - clocks: - items: - - description: Peripheral APB bus clock - - description: Application AXI BIU clock - - description: SATA Ports reference clock - - clock-names: - items: - - const: pclk - - const: aclk - - const: ref - - resets: - items: - - description: Application AXI BIU domain reset - - description: SATA Ports clock domain reset - - reset-names: - items: - - const: arst - - const: ref - - ports-implemented: - maximum: 0x3 - -patternProperties: - "^sata-port@[0-1]$": - $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port - - properties: - reg: - minimum: 0 - maximum: 1 - - snps,tx-ts-max: - $ref: /schemas/types.yaml#/definitions/uint32 - description: - Due to having AXI3 bus interface utilized the maximum Tx DMA - transaction size can't exceed 16 beats (AxLEN[3:0]). - enum: [ 1, 2, 4, 8, 16 ] - - snps,rx-ts-max: - $ref: /schemas/types.yaml#/definitions/uint32 - description: - Due to having AXI3 bus interface utilized the maximum Rx DMA - transaction size can't exceed 16 beats (AxLEN[3:0]). - enum: [ 1, 2, 4, 8, 16 ] - - unevaluatedProperties: false - -required: - - compatible - - reg - - interrupts - - clocks - - clock-names - - resets - -unevaluatedProperties: false - -examples: - - | - sata@1f050000 { - compatible = "baikal,bt1-ahci"; - reg = <0x1f050000 0x2000>; - #address-cells = <1>; - #size-cells = <0>; - - interrupts = <0 64 4>; - - clocks = <&ccu_sys 1>, <&ccu_axi 2>, <&sata_ref_clk>; - clock-names = "pclk", "aclk", "ref"; - - resets = <&ccu_axi 2>, <&ccu_sys 0>; - reset-names = "arst", "ref"; - - ports-implemented = <0x3>; - - sata-port@0 { - reg = <0>; - - snps,tx-ts-max = <4>; - snps,rx-ts-max = <4>; - }; - - sata-port@1 { - reg = <1>; - - snps,tx-ts-max = <4>; - snps,rx-ts-max = <4>; - }; - }; -...
drivers/ata/Kconfig +0 -1
@@ -194,7 +194,6 @@ config AHCI_DM816 config AHCI_DWC tristate "Synopsys DWC AHCI SATA support" select SATA_HOST - select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST) help This option enables support for the Synopsys DWC AHCI SATA controller implementation.
drivers/ata/ahci_dwc.c +0 -55
86 lines not on this page · raw message
Signature · 1 line
2.50.1
Quoted 10 lines · Andy Shevchenko
As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.
Signed-off-by Andy Shevchenko <[email protected]>---
v2: dropped YAML and
regmap.h(Niklas).../bindings/ata/baikal,bt1-ahci.yaml | 115 ------------------
Bindings are separate patches though anything only deleting lines is automatic ack. ;)
Looks like you missed a few more cases:
Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml Documentation/devicetree/bindings/cache/baikal,bt1-l2-ctl.yaml Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
Rob
Quoted 8 lines · Rob Herring
Quoted 7 lines · Andy Shevchenko
As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.
Signed-off-by Andy Shevchenko <[email protected]>---
Quoted 8 lines
Quoted 3 lines
v2: dropped YAML and
regmap.h(Niklas).../bindings/ata/baikal,bt1-ahci.yaml | 115 ------------------Bindings are separate patches though anything only deleting lines is automatic ack. ;)
Thank you!
Quoted 1 line
Looks like you missed a few more cases:
Not really, see below my answers.
Quoted 3 lines
Documentation/devicetree/bindings/bus/baikal,bt1-apb.yamlDocumentation/devicetree/bindings/bus/baikal,bt1-axi.yamlDocumentation/devicetree/bindings/cache/baikal,bt1-l2-ctl.yaml
These are not related to ATA subsystem.
Quoted 2 lines
Documentation/devicetree/bindings/i2c/snps,designware-i2c.yamlDocumentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
These were missed in the respective previous submissions. Hence for these will be two (or do you want a single? I think they will need different Fixes tags, perhaps) patch to remove.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.
Applied to libata/linux.git (for-7.1), thanks!
[1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
https://git.kernel.org/libata/linux/c/db1d3cfa
Kind regards,
Niklas