Skip to contentSkip to conversation

spi: cs42l43: Don't support sidecar properties on device tree systems

PATCH RESEND In review Charles Keepax 2 participants 2 messages Feb 23 – Feb 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 spi: cs42l43: Don't support sidecar properties on device tree systems

On some systems the cs42l43 has amplifiers attached to its SPI controller that are not properly defined in ACPI. However, this exists to provide compatibility with existing Windows ACPI.

On device tree systems this functionality should never be used, there is no reason not to specify the amplifiers properly through device tree. Make this more clear by only allowing the "sidecar" functionality to be used on non-DT systems.

---
 drivers/spi/spi-cs42l43.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-cs42l43.c +2 -2
index a4a650c8d7405..68f208ef1e01f 100644
@@ -367,10 +367,10 @@ static int cs42l43_spi_probe(struct platform_device *pdev)
 		ret = devm_add_action_or_reset(priv->dev, cs42l43_release_of_node, fwnode);
 		if (ret)
 			return ret;
+	} else {
+		fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars);
 	}
 
-	fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars);
-
 	/*
 	 * Depending on the value of nsidecars we either create a software node
 	 * or assign an fwnode. We don't want software node to be attached to
Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 10 lines · Charles Keepax

On some systems the cs42l43 has amplifiers attached to its SPI controller that are not properly defined in ACPI. However, this exists to provide compatibility with existing Windows ACPI.

On device tree systems this functionality should never be used, there is no reason not to specify the amplifiers properly through device tree. Make this more clear by only allowing the "sidecar" functionality to be used on non-DT systems.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cs42l43: Don't support sidecar properties on device tree systems

      commit: 20a88c156f37634fdd88b746fa34e3622f567130

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark