usb: misc: uss720: properly clean up reference in uss720_probe()
Greg Kroah-Hartman
maintainerPATCH v3 1/1 usb: misc: uss720: properly clean up reference in uss720_probe()
If get_1284_register() fails, the usb device reference count is incorrect and needs to be properly dropped before returning. That will happen when the kref is dropped in the call to destroy_priv(), so jump to that error path instead of returning directly.
Cc stable <[email protected]>
Assisted-by gkh_clanker_2000
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
v3: don't drop the reference count manually, it will be done in
destroy_priv() as pointed out by Oliver.
v2: properly clean up the previously allocated resources by jumping to
the error path and not just retrning directly
drivers/usb/misc/uss720.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/uss720.c +1 -1
@@ -736,7 +736,7 @@ static int uss720_probe(struct usb_interface *intf, ret =get_1284_register (pp,0 , ®,GFP_KERNEL );dev_dbg (&intf->dev,"reg: %7ph\n" , priv->reg);if (ret <0 ) -return ret; + goto probe_abort; ret =usb_find_last_int_in_endpoint (interface, &epd);if (!ret) {
Signature · 1 line
2.53.0