mm.git dashboard for patches and review status per subsystem
Subsystems (2)
SeongJae Park
maintainerHello,
I'm a super fan of mm.git. Huge thanks to Andrew for the effort on maintaining the repo.
I use it as not only the baseline of my works, but also a way to understand the status of ongoing works. From mm.git, I find which patches are in what stage on the road to the mainline, and what patches lack reviews and therefore I could help.
Nevertheless, because of the volume of the patches, it is not really easy to use mm.git with only manual git commands. Therefore I was using a few script for simplifying and filtering the information for DAMON and myself. And I recently further worked on making it more general for any git repos and Linux kernel subsystems. I named it 'summary_trees.py' [1].
The script shows the number of commits in given branches in a git repo, categorized by their review status. The review status is defined by who wrote the patch and who reviewed the patch. The actors are identified based on the MAINTAINERS file. It first finds subsystems of the patch based on their touching files, and then get the roles of the author/reviewers on the subsystems. As a result, below 12 review status categories are made.
Author Reviewer
------------------------
no-role nobody
no-role no-role
no-role reviewer
no-role maintainer
reviewer nobody
reviewer no-role
reviewer reviewer
reviewer maintainer
maintainer nobody
maintainer no-role
maintainer reviewer
maintainer maintainerFor example:
- baseline: v7.0-rc1
- mm-hotfixes-stable: 0 total, 0 (0) series, 0 non-series commits
- mm-hotfixes-unstable: 15 total, 1 (2) series, 13 non-series commits
- author/reviewer role stat
- no role, nobody: 5 commits
- no role, no role : 4 commits
- no role, reviewer: 1 commits
- no role, maintainer: 1 commits
- maintainer, nobody: 3 commits
- maintainer, maintainer: 1 commits
- mm-stable: 0 total, 0 (0) series, 0 non-series commits
- mm-unstable: 94 total, 9 (61) series, 33 non-series commits
- author/reviewer role stat
- no role, nobody: 9 commits
- no role, no role : 13 commits
- no role, reviewer: 9 commits
- no role, maintainer: 15 commits
- reviewer, nobody: 1 commits
- maintainer, nobody: 35 commits
- maintainer, maintainer: 12 commits
- mm-new: 7 total, 1 (3) series, 4 non-series commits
- author/reviewer role stat
- no role, nobody: 3 commits
- no role, no role : 1 commits
- no role, maintainer: 1 commits
- maintainer, nobody: 1 commits
- maintainer, maintainer: 1 commits
- mm-nonmm-stable: 0 total, 0 (0) series, 0 non-series commits
- mm-nonmm-unstable: 29 total, 3 (11) series, 18 non-series commits
- author/reviewer role stat
- no role, nobody: 14 commits
- no role, no role : 10 commits
- no role, maintainer: 4 commits
- maintainer, nobody: 1 commits
With some options, it can also show the full list of the patches in the categories per branch, like below:
- mm-hotfixes-unstable: 15 total, 1 (2) series, 13 non-series commits
- author/reviewer role stat
- no role, nobody: 5 commits
- no role, no role : 4 commits
- no role, reviewer: 1 commits
- no role, maintainer: 1 commits
- maintainer, nobody: 3 commits
- maintainer, maintainer: 1 commits
- full commits list
- bf16641da830 "mm: allow __GFP_RETRY_MAYFAIL in vmalloc"
- Authored by no role player, reviewed by no role player
- Link: https://lkml.kernel.org/r/[email protected]
Also, it can show the changes of the status, such as what patches are newly added to or dropped from what branch, what tags are added and dropped, like below:
- mm-hotfixes-unstable: 10 -> 15 commits
- series: 0 (0) -> 1 (2)
- no role, nobody: 2 -> 5 commits
- no role, no role : 2 -> 4 commits
- no role, reviewer: 1 -> 1 commits (no change)
- no role, maintainer: 1 -> 1 commits (no change)
- maintainer, nobody: 3 -> 3 commits (no change)
- maintainer, maintainer: 1 -> 1 commits (no change)
- new commits
- 7dd859e3fb0b "mm: fix NULL NODE_DATA dereference for memoryless nodes on boot"
- Link: https://lkml.kernel.org/r/[email protected]
- 3c0cda2b0dda "mailmap: add entry for Daniele Alessandrelli"
- Link: https://lkml.kernel.org/r/[email protected]
- a51c6f1008e4 "MAINTAINERS: update Yosry Ahmed's email address"
- Link: https://lkml.kernel.org/r/[email protected]
- series "mm: memfd_luo: fixes for folio flag preservation". (2)
- 76ec99cfed40 "mm: memfd_luo: always make all folios uptodate (0/2)"
- Link: https://lkml.kernel.org/r/[email protected]
- b6eb2bd40c1b "mm: memfd_luo: always dirty all folios (1/2)"
- Link: https://lkml.kernel.org/r/[email protected]
- changed commits
- bf16641da830 "mm: allow __GFP_RETRY_MAYFAIL in vmalloc"
- added "Acked-by: SeongJae Park <[email protected]>"
- added "Reviewed-by: Anshuman Khandual <[email protected]>"
- dropped "Cc: Christoph Hellwig <[email protected]>"
- dropped "Cc: SeongJae Park <[email protected]>"
- Link: https://lkml.kernel.org/r/[email protected]
The script can also make the outputs for only specific subsystems. For example, I can get the counts, lists of patches and daily changes for DAMON or 'MEMORY MANGEMENT - CORE' only.
Because I find that information is useful for me, I wrote a wrapper of the tool that speecialized for mm.git usage [2], namely mm_tree_snapshot.sh. The wrapper script runs the tool for mm.git branches (mm-hotfixes-stable, mm-hotfixes-unstable, mm-stable, mm-unstable, mm-new, mm-nonmm-stable, mm-nonmm-unstable) and a few mm subsystyems [3] I collected with my best knowledge and interests. I started running the wrapper and backing up the output on a public GitHub repo, mm_git_dashboard [4], from a few weeks ago.
So, from the repo, I can find per-branch per-review status patches counts summary [5], the counts summary with full list of the patches [6], and the changes made since last update of the dashboard [7]. Same data is available for each subsystems. For example, the data for DAMON is available at summary/subsystem/DAMON/ [8] of the repo.
I find this is useful for tracking DAMON patches that left my tree and merged into mm.git. I was able to easily understand their status and needed actions from my side. It was also useful for finding patches that I want to review for subsystems other than DAMON that I'm interested in. So I will keep updating the outputs backup repo unless I find it is no more useful.
The scripts are open source, and the output backup repo is a public GitHub repo. So, if you want, you can use the contents of the backup repo for mm.git info, or modify/use the tool in your way as you need.
I just wanted to share this for a case that someone is also looking for a similar things, as I was looking for this kind of things for a while. Any questions and/or comments on tools and backup will be appreciated.
[1] summary_trees: https://github.com/sjp38/lazybox/blob/master/linux_hack/summary_trees.py
[2] mm_tree_snapshot: https://github.com/sjp38/lazybox/blob/master/linux_hack/mm_tree_snapshot.sh
[3] https://github.com/sjp38/lazybox/blob/master/linux_hack/mm_tree_snapshot.sh#L77
[4] mm_git_dashboard: https://github.com/sjp38/mm_git_dashboard
[5] https://github.com/sjp38/mm_git_dashboard/blob/master/summary/summary.md
[6] https://github.com/sjp38/mm_git_dashboard/blob/master/summary/full_commits_list.md
[7] https://github.com/sjp38/mm_git_dashboard/blob/master/summary/changes_from_last_update.md
[8] https://github.com/sjp38/mm_git_dashboard/tree/master/summary/subsystem/DAMON
Thanks,
SJ