Skip to contentSkip to conversation

mtd: physmap: physmap-bt1-rom: Remove not-going-to-be-supported code for Baikal SoC

PATCH Superseded Andy Shevchenko 2 participants 3 messages Feb 24 – Feb 25 Memory technology devices (MTD)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: physmap: physmap-bt1-rom: Remove not-going-to-be-supported code for Baikal SoC

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

---
 drivers/mtd/maps/Kconfig           |  11 ---
 drivers/mtd/maps/Makefile          |   1 -
 drivers/mtd/maps/physmap-bt1-rom.c | 125 -----------------------------
 drivers/mtd/maps/physmap-bt1-rom.h |  17 ----
 4 files changed, 154 deletions(-)
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.c
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.h
drivers/mtd/maps/Kconfig +0 -11
index 8a8b19874e23..99d5ff9a1fbe 100644
@@ -75,17 +75,6 @@ config MTD_PHYSMAP_OF
 	  physically into the CPU's memory. The mapping description here is
 	  taken from OF device tree.
 
-config MTD_PHYSMAP_BT1_ROM
-	bool "Baikal-T1 Boot ROMs OF-based physical memory map handling"
-	depends on MTD_PHYSMAP_OF
-	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
-	select MTD_COMPLEX_MAPPINGS
-	select MULTIPLEXER
-	select MUX_MMIO
-	help
-	  This provides some extra DT physmap parsing for the Baikal-T1
-	  platforms, some detection and setting up ROMs-specific accessors.
-
 config MTD_PHYSMAP_VERSATILE
 	bool "ARM Versatile OF-based physical memory map handling"
 	depends on MTD_PHYSMAP_OF
drivers/mtd/maps/Makefile +0 -1
index 019f1e92cc41..51af1d2ebd52 100644
@@ -19,7 +19,6 @@ obj-$(CONFIG_MTD_TSUNAMI)	+= tsunami_flash.o
 obj-$(CONFIG_MTD_PXA2XX)	+= pxa2xx-flash.o
 obj-$(CONFIG_MTD_PHYSMAP)	+= physmap.o
 physmap-y			:= physmap-core.o
-physmap-$(CONFIG_MTD_PHYSMAP_BT1_ROM) += physmap-bt1-rom.o
 physmap-$(CONFIG_MTD_PHYSMAP_VERSATILE) += physmap-versatile.o
 physmap-$(CONFIG_MTD_PHYSMAP_GEMINI) += physmap-gemini.o
 physmap-$(CONFIG_MTD_PHYSMAP_IXP4XX) += physmap-ixp4xx.o
drivers/mtd/maps/physmap-bt1-rom.c deleted +0 -125

125 lines not on this page · raw message

drivers/mtd/maps/physmap-bt1-rom.h deleted +0 -17
deleted file mode 100644
index 6782899598a4..000000000000
@@ -1,17 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-#include <linux/mtd/map.h>
-#include <linux/of.h>
-
-#ifdef CONFIG_MTD_PHYSMAP_BT1_ROM
-int of_flash_probe_bt1_rom(struct platform_device *pdev,
-			   struct device_node *np,
-			   struct map_info *map);
-#else
-static inline
-int of_flash_probe_bt1_rom(struct platform_device *pdev,
-			   struct device_node *np,
-			   struct map_info *map)
-{
-	return 0;
-}
-#endif
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Andy,

Quoted 5 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

Quoted 8 lines
---
 drivers/mtd/maps/Kconfig           |  11 ---
 drivers/mtd/maps/Makefile          |   1 -
 drivers/mtd/maps/physmap-bt1-rom.c | 125 -----------------------------
 drivers/mtd/maps/physmap-bt1-rom.h |  17 ----
 4 files changed, 154 deletions(-)
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.c
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.h

There is also a small change in drivers/mtd/maps/physmap-core.c that is needed:

-#include "physmap-bt1-rom.h"

and then

thanks.

Signature · 1 line
~Randy
#2 lore raw
Quoted 15 lines · Randy Dunlap
Quoted 5 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

Quoted 8 lines
---
 drivers/mtd/maps/Kconfig           |  11 ---
 drivers/mtd/maps/Makefile          |   1 -
 drivers/mtd/maps/physmap-bt1-rom.c | 125 -----------------------------
 drivers/mtd/maps/physmap-bt1-rom.h |  17 ----
 4 files changed, 154 deletions(-)
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.c
 delete mode 100644 drivers/mtd/maps/physmap-bt1-rom.h
Quoted 4 lines

There is also a small change in drivers/mtd/maps/physmap-core.c that is needed:

-#include "physmap-bt1-rom.h"

I somehow missed that.

Quoted 2 lines

and then

Thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko