Skip to contentSkip to conversation

arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2

PATCH Applied Chaoyi Chen 3 participants 3 messages Feb 26 – Mar 2

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Chaoyi Chen

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2

From: Chaoyi Chen <[email protected]>

In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl. However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and remove sdmmc0_pwren to avoid conflicts.

Cc Shawn Lin <[email protected]>
Fixes 86a82f7a7eed ("arm64: dts: rockchip: Add rk3576 evb2 board")
Signed-off-by Chaoyi Chen <[email protected]>
---
 arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts +2 -0
index 6bdc232ab267..98d5d00d63b5 100644
@@ -951,6 +951,8 @@ &sdmmc {
 	disable-wp;
 	no-sdio;
 	no-mmc;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_det &sdmmc0_bus4>;
 	sd-uhs-sdr104;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd_s0>;
Signature · 1 line
2.51.1
#1 lore raw

Hello，

Quoted 10 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl. However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and remove sdmmc0_pwren to avoid conflicts.

Cc Shawn Lin <[email protected]>
Fixes 86a82f7a7eed ("arm64: dts: rockchip: Add rk3576 evb2 board")
Signed-off-by Chaoyi Chen <[email protected]>

Tested-by： Andy Yan <[email protected]>

Quoted 25 lines

---
arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts | 2 ++

1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts +2 -0
index 6bdc232ab267..98d5d00d63b5 100644
@@ -951,6 +951,8 @@ &sdmmc {
 	disable-wp;
 	no-sdio;
 	no-mmc;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_det &sdmmc0_bus4>;
 	sd-uhs-sdr104;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd_s0>;
Signature · 7 lines
2.51.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Applied
#2 lore raw
In reply to Chaoyi Chen
Quoted 6 lines · Chaoyi Chen

In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl. However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and remove sdmmc0_pwren to avoid conflicts.

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2

      commit: 7d939032bd7e203e1c907a8c35e3672eeee08246

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>