block: Use sysfs_emit in sysfs show functions
PATCH 1/1 block: Use sysfs_emit in sysfs show functions
Replace sprintf() with sysfs_emit() in sysfs show functions. sysfs_emit() is preferred for formatting sysfs output because it provides safer bounds checking. No functional changes.
Signed-off-by Thorsten Blum <[email protected]>
--- block/partitions/core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
block/partitions/core.c +6 -5
@@ -8,6 +8,7 @@#include <linux/major.h> #include <linux/slab.h> #include <linux/string.h> +#include <linux/sysfs.h> #include <linux/ctype.h> #include <linux/vmalloc.h> #include <linux/raid/detect.h>
@@ -177,31 +178,31 @@ static struct parsed_partitions *check_partition(struct gendisk *hd)static ssize_t part_partition_show (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"%d\n" ,bdev_partno (dev_to_bdev (dev))); +return sysfs_emit (buf,"%d\n" ,bdev_partno (dev_to_bdev (dev))); }static ssize_t part_start_show (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"%llu\n" ,dev_to_bdev (dev)->bd_start_sect); +return sysfs_emit (buf,"%llu\n" ,dev_to_bdev (dev)->bd_start_sect); }static ssize_t part_ro_show (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"%d\n" ,bdev_read_only (dev_to_bdev (dev))); +return sysfs_emit (buf,"%d\n" ,bdev_read_only (dev_to_bdev (dev))); }static ssize_t part_alignment_offset_show (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"%u\n" ,bdev_alignment_offset (dev_to_bdev (dev))); +return sysfs_emit (buf,"%u\n" ,bdev_alignment_offset (dev_to_bdev (dev))); }static ssize_t part_discard_alignment_show (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"%u\n" ,bdev_discard_alignment (dev_to_bdev (dev))); +return sysfs_emit (buf,"%u\n" ,bdev_discard_alignment (dev_to_bdev (dev))); } static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);
Signature · 2 lines
Thorsten Blum <[email protected]> GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4