Skip to contentSkip to conversation

integrity: digsig: Add blank line after declarations

PATCH In review Chi Wang 2 participants 2 messages Feb 27

Subsystems (4)
lore
Share & tools
lore

Chi Wang

author
#0 lore raw

PATCH 1/1 integrity: digsig: Add blank line after declarations

From: Chi Wang <[email protected]>

Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
+ int err = PTR_ERR(keyring[id]);
+ pr_err("no %s keyring: %d\n", keyring_name[id], err);

Add a blank line after the variable declaration to comply with the kernel coding style.

---
 security/integrity/digsig.c | 1 +
 1 file changed, 1 insertion(+)
security/integrity/digsig.c +1 -0
index aec350abad86..5e7ba7d3cf99 100644
@@ -49,6 +49,7 @@ static struct key *integrity_keyring_from_id(const unsigned int id)
 			request_key(&key_type_keyring, keyring_name[id], NULL);
 		if (IS_ERR(keyring[id])) {
 			int err = PTR_ERR(keyring[id]);
+
 			pr_err("no %s keyring: %d\n", keyring_name[id], err);
 			keyring[id] = NULL;
 			return ERR_PTR(err);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 11 lines · Chi Wang

From: Chi Wang <[email protected]>

Fixes checkpatch warning:
WARNING: Missing a blank line after declarations

(quoted diff) +2 -0
+                       int err = PTR_ERR(keyring[id]);
+                       pr_err("no %s keyring: %d\n", keyring_name[id], err);

Add a blank line after the variable declaration to comply with the kernel coding style.

Agreed checkpatch complains today, but probably not back in 2011 when the patch was upstreamed. Cosmetic changes are normally upstreamed only with other changes.

thanks,

Mimi