Skip to contentSkip to conversation

staging: axis-fifo: fix alignment to match open parenthesis

PATCH Superseded Lucas Faria Mendes 2 participants 2 messages Feb 27 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: axis-fifo: fix alignment to match open parenthesis

Fix checkpatch CHECK for alignment in the wait_event_interruptible() call. Align the continuation line to match the open parenthesis as required by the kernel coding style.

---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/axis-fifo/axis-fifo.c +2 -1
index aa90b27197cf..c64a7249feca 100644
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+					       >= words_to_write);
 		if (ret)
 			goto end_unlock;
 	}
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 14 lines · Lucas Faria Mendes

Fix checkpatch CHECK for alignment in the wait_event_interruptible() call. Align the continuation line to match the open parenthesis as required by the kernel coding style.

---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/axis-fifo/axis-fifo.c +0 -0
index aa90b27197cf..c64a7249feca 100644

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_write(struct file *f, const char __user *buf, · line 250

Quoted 6 lines
drivers/staging/axis-fifo/axis-fifo.c +2 -1
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+					       >= words_to_write);

Now it looks worse :(

This is one of those lines you just can not win, sorry, it keeps going back and forth. Just leave it as is please.

thanks,

greg k-h