Skip to contentSkip to conversation

dt-bindings: greybus: Document google,arche-platform

PATCH In review Soham Kute 3 participants 4 messages Mar 1 Device tree bindings

lore
Share & tools
lore

Soham Kute

author
#0 lore raw

PATCH 1/1 dt-bindings: greybus: Document google,arche-platform

Document the Google Arche platform which enables the Unipro link between the application processor and the SVC in a Greybus-based system.

---
 .../greybus/google,arche-platform.yaml        | 71 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/greybus/google,arche-platform.yaml
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +71 -0
new file mode 100644
index 000000000000..6e176efc264a
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/greybus/google,arche-platform.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Arche Platform
+
+maintainers:
+  - Vaibhav Hiremath <[email protected]>
+
+description:
+  The Arche platform driver enables the Unipro link between the
+  application processor and the SVC (Supervisory Controller) in
+  a Greybus-based system.
+
+properties:
+  compatible:
+    const: google,arche-platform
+
+  svc,reset-gpios:
+    description: GPIO used to reset the SVC
+    maxItems: 1
+
+  svc,sysboot-gpios:
+    description: GPIO used for SVC sysboot signal
+    maxItems: 1
+
+  svc,refclk-req-gpios:
+    description: GPIO used to request the SVC reference clock
+    maxItems: 1
+
+  svc,wake-detect-gpios:
+    description: Bidirectional GPIO for wake/detect signal between AP and SVC
+    maxItems: 1
+
+  clocks:
+    description: SVC reference clock
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: svc_ref_clk
+
+  svc,reset-active-high:
+    description: Present if the SVC reset GPIO is active high
+    type: boolean
+
+additionalProperties: false
+
+required:
+  - compatible
+  - svc,reset-gpios
+  - svc,sysboot-gpios
+  - svc,refclk-req-gpios
+  - svc,wake-detect-gpios
+  - clocks
+  - clock-names
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    arche-platform {
+        compatible = "google,arche-platform";
+        svc,reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
+        svc,sysboot-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
+        svc,refclk-req-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;
+        svc,wake-detect-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>;
+        clocks = <&svc_ref_clk>;
+        clock-names = "svc_ref_clk";
+    };
MAINTAINERS +1 -0
index e08767323763..46cb6825f4d6 100644
@@ -10886,6 +10886,7 @@ S:	Maintained
 F:	drivers/staging/greybus/arche-apb-ctrl.c
 F:	drivers/staging/greybus/arche-platform.c
 F:	drivers/staging/greybus/arche_platform.h
+F:	Documentation/devicetree/bindings/greybus/google,arche-platform.yaml
 
 GREYBUS SDIO/GPIO/SPI PROTOCOLS DRIVERS
 M:	Rui Miguel Silva <[email protected]>
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Soham Kute

Document the Google Arche platform which enables the Unipro link between the application processor and the SVC in a Greybus-based system.

---
 .../greybus/google,arche-platform.yaml        | 71 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/greybus/google,arche-platform.yaml

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/greybus/google,arche-platform.example.dtb: arche-platform (google,arche-platform): 'svc,refclk-req-gpios', 'svc,reset-gpios', 'svc,sysboot-gpios', 'svc,wake-detect-gpios' do not match any of the regexes: '^#.*', '^(at25|bm|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio-key|gpio|gpmc|hdmi|i2c-gpio),.*', '^(keypad|m25p|max8952|max8997|max8998|mpmc),.*', '^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*', '^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*', '^(simple-audio-card|st-plgpio|st-spics|ts|vsc8531),.*', '^100ask,.*', '^70mai,.*', '^8dev,.*', '^9tripod,.*', '^GEFanuc,.*', '^IBM,.*', '^ORCL,.*', '^SUNW,.*', '^[a-zA-Z0-9#_][a-zA-Z0-9#+\\-._@]{0,63}$', '^[a-zA-Z0-9+\\-._]*@[0-9a-zA-Z,]*$', '^abb,.*', '^abilis,.*', '^abracon,.*', '^abt,.*', '^acbel,.*', '^acelink,.*', '^acer,.*', '^acme,.*', '^actions,.*', '^actiontec,.*', '^active-semi,.*', '^ad,.*', '^adafruit,.*', '^adapteva,.*', '^adaptrum,.*', '^adh,.*', '^adi,.*', '^adieng,.*', '^admatec,.*', '^advantech,.*', '^aeroflexgaisler,.*', '^aesop,.*', '^airoha,.*', '^al,.*', '^alcatel,.*', '^aldec,.*', '^alfa-network,.*', '^algoltek,.*', '^allegro,.*', '^allegromicro,.*', '^alliedtelesis,.*', '^alliedvision,.*', '^allo,.*', '^allwinner,.*', '^alphascale,.*', '^alps,.*', '^alt,.*', '^altr,.*', '^amarula,.*', '^amazon,.*', '^amcc,.*', '^amd,.*', '^amediatech,.*', '^amlogic,.*', '^ampere,.*', '^amphenol,.*', '^ampire,.*', '^ams,.*', '^amstaos,.*', '^analogix,.*', '^anbernic,.*', '^andestech,.*', '^anlogic,.*', '^anvo,.*', '^aoly,.*', '^aosong,.*', '^apm,.*', '^apple,.*', '^aptina,.*', '^arasan,.*', '^archermind,.*', '^arcom,.*', '^arctic,.*', '^arcx,.*', '^arduino,.*', '^argon40,.*', '^ariaboard,.*', '^aries,.*', '^arm,.*', '^armadeus,.*', '^armsom,.*', '^arrow,.*', '^artesyn,.*', '^asahi-kasei,.*', '^asc,.*', '^asix,.*', '^asl-tek,.*', '^aspeed,.*', '^asrock,.*', '^asteralabs,.*', '^asus,.*', '^atheros,.*', '^atlas,.*', '^atmel,.*', '^auo,.*', '^auvidea,.*', '^avago,.*', '^avia,.*', '^avic,.*', '^avnet,.*', '^awinic,.*', '^axentia,.*', '^axiado,.*', '^axis,.*', '^azoteq,.*', '^azw,.*', '^baikal,.*', '^bananapi,.*', '^beacon,.*', '^beagle,.*', '^belling,.*', '^bestar,.*', '^bhf,.*', '^bigtreetech,.*', '^bitmain,.*', '^blaize,.*', '^bluegiga,.*', '^blutek,.*', '^boe,.*', '^bosch,.*', '^boundary,.*', '^brcm,.*', '^broadmobi,.*', '^bsh,.*', '^bst,.*', '^bticino,.*', '^buffalo,.*', '^buglabs,.*', '^bur,.*', '^bytedance,.*', '^calamp,.*', '^calao,.*', '^calaosystems,.*', '^calxeda,.*', '^cameo,.*', '^canaan,.*', '^caninos,.*', '^capella,.*', '^cascoda,.*', '^catalyst,.*', '^cavium,.*', '^cct,.*', '^cdns,.*', '^cdtech,.*', '^cellwise,.*', '^ceva,.*', '^chargebyte,.*', '^checkpoint,.*', '^chefree,.*', '^chipidea,.*', '^chipone,.*', '^chipspark,.*', '^chongzhou,.*', '^chrontel,.*', '^chrp,.*', '^chunghwa,.*', '^chuwi,.*', '^ciaa,.*', '^cirrus,.*', '^cisco,.*', '^cix,.*', '^clockwork,.*', '^cloos,.*', '^cloudengines,.*', '^cnm,.*', '^cnxt,.*', '^colorfly,.*', '^compal,.*', '^compulab,.*', '^comvetia,.*', '^congatec,.*', '^coolpi,.*', '^coreriver,.*', '^corpro,.*', '^cortina,.*', '^cosmic,.*', '^crane,.*', '^creative,.*', '^crystalfontz,.*', '^csky,.*', '^csot,.*', '^csq,.*', '^csr,.*', '^ctera,.*', '^ctu,.*', '^cubietech,.*', '^cudy,.*', '^cui,.*', '^cypress,.*', '^cyx,.*', '^cznic,.*', '^dallas,.*', '^dataimage,.*', '^davicom,.*', '^deepcomputing,.*', '^dell,.*', '^delta,.*', '^densitron,.*', '^denx,.*', '^devantech,.*', '^dfi,.*', '^dfrobot,.*', '^dh,.*', '^difrnce,.*', '^digi,.*', '^digilent,.*', '^dimonoff,.*', '^diodes,.*', '^dioo,.*', '^djn,.*', '^dlc,.*', '^dlg,.*', '^dlink,.*', '^dmo,.*', '^domintech,.*', '^dongwoon,.*', '^dptechnics,.*', '^dragino,.*', '^dream,.*', '^ds,.*', '^dserve,.*', '^dynaimage,.*', '^ea,.*', '^ebang,.*', '^ebbg,.*', '^ebs-systart,.*', '^ebv,.*', '^eckelmann,.*', '^econet,.*', '^edgeble,.*', '^edimax,.*', '^edt,.*', '^ees,.*', '^eeti,.*', '^egnite,.*', '^einfochips,.*', '^eink,.*', '^elan,.*', '^element14,.*', '^elgin,.*', '^elida,.*', '^elimo,.*', '^elpida,.*', '^embedfire,.*', '^embest,.*', '^emcraft,.*', '^emlid,.*', '^emmicro,.*', '^empire-electronix,.*', '^emtrion,.*', '^enbw,.*', '^enclustra,.*', '^endian,.*', '^endless,.*', '^ene,.*', '^energymicro,.*', '^engicam,.*', '^engleder,.*', '^epcos,.*', '^epfl,.*', '^epson,.*', '^esp,.*', '^est,.*', '^eswin,.*', '^ettus,.*', '^eukrea,.*', '^everest,.*', '^everspin,.*', '^evervision,.*', '^exar,.*', '^excito,.*', '^exegin,.*', '^ezchip,.*', '^ezurio,.*', '^facebook,.*', '^fairchild,.*', '^fairphone,.*', '^faraday,.*', '^fascontek,.*', '^fastrax,.*', '^fcs,.*', '^feixin,.*', '^feiyang,.*', '^fii,.*', '^firefly,.*', '^fitipower,.*', '^flipkart,.*', '^focaltech,.*', '^forlinx,.*', '^foursemi,.*', '^foxlink,.*', '^freebox,.*', '^freecom,.*', '^frida,.*', '^friendlyarm,.*', '^fsl,.*', '^fujitsu,.*', '^fxtec,.*', '^galaxycore,.*', '^gameforce,.*', '^gardena,.*', '^gateway,.*', '^gateworks,.*', '^gcw,.*', '^ge,.*', '^geekbuying,.*', '^gef,.*', '^gehc,.*', '^gemei,.*', '^gemtek,.*', '^genesys,.*', '^genexis,.*', '^geniatech,.*', '^giantec,.*', '^giantplus,.*', '^glinet,.*', '^globalscale,.*', '^globaltop,.*', '^gmt,.*', '^gocontroll,.*', '^goldelico,.*', '^goodix,.*', '^google,.*', '^goramo,.*', '^gplus,.*', '^grinn,.*', '^grmn,.*', '^gumstix,.*', '^gw,.*', '^hannstar,.*', '^haochuangyi,.*', '^haoyu,.*', '^hardkernel,.*', '^hce,.*', '^headacoustics,.*', '^hechuang,.*', '^hideep,.*', '^himax,.*', '^hinlink,.*', '^hirschmann,.*', '^hisi,.*', '^hisilicon,.*', '^hit,.*', '^hitex,.*', '^hitron,.*', '^holt,.*', '^holtek,.*', '^honestar,.*', '^honeywell,.*', '^hoperf,.*', '^hoperun,.*', '^hp,.*', '^hpe,.*', '^hsg,.*', '^htc,.*', '^huawei,.*', '^hugsun,.*', '^huiling,.*', '^hwacom,.*', '^hxt,.*', '^hycon,.*', '^hydis,.*', '^hynitron,.*', '^hynix,.*', '^hyundai,.*', '^i2se,.*', '^ibm,.*', '^icplus,.*', '^idt,.*', '^iei,.*', '^ifi,.*', '^ifm,.*', '^ilitek,.*', '^imagis,.*', '^img,.*', '^imi,.*', '^inanbo,.*', '^incircuit,.*', '^incostartec,.*', '^indiedroid,.*', '^inet-tek,.*', '^infineon,.*', '^inforce,.*', '^ingenic,.*', '^ingrasys,.*', '^injoinic,.*', '^innocomm,.*', '^innolux,.*', '^inside-secure,.*', '^insignal,.*', '^inspur,.*', '^intel,.*', '^intercontrol,.*', '^invensense,.*', '^inventec,.*', '^inversepath,.*', '^iom,.*', '^irondevice,.*', '^isee,.*', '^isil,.*', '^issi,.*', '^ite,.*', '^itead,.*', '^itian,.*', '^ivo,.*', '^iwave,.*', '^jadard,.*', '^jasonic,.*', '^jdi,.*', '^jedec,.*', '^jenson,.*', '^jesurun,.*', '^jethome,.*', '^jianda,.*', '^jide,.*', '^joz,.*', '^jty,.*', '^jutouch,.*', '^kam,.*', '^karo,.*', '^keithkoep,.*', '^keymile,.*', '^khadas,.*', '^kiebackpeter,.*', '^kinetic,.*', '^kingdisplay,.*', '^kingnovel,.*', '^kionix,.*', '^kobo,.*', '^kobol,.*', '^koe,.*', '^kontron,.*', '^kosagi,.*', '^kvg,.*', '^kyo,.*', '^lacie,.*', '^laird,.*', '^lamobo,.*', '^lantiq,.*', '^lattice,.*', '^lckfb,.*', '^lctech,.*', '^leadtek,.*', '^leez,.*', '^lego,.*', '^lemaker,.*', '^lenovo,.*', '^lg,.*', '^lgphilips,.*', '^libretech,.*', '^licheepi,.*', '^linaro,.*', '^lincolntech,.*', '^lineartechnology,.*', '^linkease,.*', '^linksprite,.*', '^linksys,.*', '^linutronix,.*', '^linux,.*', '^linx,.*', '^liontron,.*', '^liteon,.*', '^litex,.*', '^lltc,.*', '^logicpd,.*', '^logictechno,.*', '^longcheer,.*', '^lontium,.*', '^loongmasses,.*', '^loongson,.*', '^lsi,.*', '^luckfox,.*', '^lunzn,.*', '^luxul,.*', '^lwn,.*', '^lxa,.*', '^m5stack,.*', '^macnica,.*', '^mantix,.*', '^mapleboard,.*', '^marantec,.*', '^marvell,.*', '^maxbotix,.*', '^maxim,.*', '^maxlinear,.*', '^maxtor,.*', '^mayqueen,.*', '^mbvl,.*', '^mcube,.*', '^meas,.*', '^mecer,.*', '^mediatek,.*', '^medion,.*', '^megachips,.*', '^mele,.*', '^melexis,.*', '^melfas,.*', '^mellanox,.*', '^memsensing,.*', '^memsic,.*', '^menlo,.*', '^mentor,.*', '^meraki,.*', '^merrii,.*', '^methode,.*', '^micrel,.*', '^microchip,.*', '^microcrystal,.*', '^micron,.*', '^microsoft,.*', '^microsys,.*', '^microtips,.*', '^mikroe,.*', '^mikrotik,.*', '^milianke,.*', '^milkv,.*', '^miniand,.*', '^minix,.*', '^mips,.*', '^miramems,.*', '^mitsubishi,.*', '^mitsumi,.*', '^mixel,.*', '^miyoo,.*', '^mntre,.*', '^mobileye,.*', '^modtronix,.*', '^moortec,.*', '^mosaixtech,.*', '^motorcomm,.*', '^motorola,.*', '^moxa,.*', '^mpl,.*', '^mps,.*', '^mqmaker,.*', '^mrvl,.*', '^mscc,.*', '^msi,.*', '^mstar,.*', '^mti,.*', '^multi-inno,.*', '^mundoreader,.*', '^murata,.*', '^mxic,.*', '^mxicy,.*', '^myir,.*', '^national,.*', '^neardi,.*', '^nec,.*', '^neofidelity,.*', '^neonode,.*', '^netcube,.*', '^netgear,.*', '^netlogic,.*', '^netron-dy,.*', '^netronix,.*', '^netxeon,.*', '^neweast,.*', '^newhaven,.*', '^newvision,.*', '^nexbox,.*', '^nextthing,.*', '^ni,.*', '^nicera,.*', '^nintendo,.*', '^nlt,.*', '^nokia,.*', '^nordic,.*', '^nothing,.*', '^novatech,.*', '^novatek,.*', '^novtech,.*', '^nuclei,.*', '^numonyx,.*', '^nutsboard,.*', '^nuvoton,.*', '^nvd,.*', '^nvidia,.*', '^nxp,.*', '^oceanic,.*', '^ocs,.*', '^oct,.*', '^okaya,.*', '^oki,.*', '^olimex,.*', '^olpc,.*', '^oneplus,.*', '^onething,.*', '^onie,.*', '^onion,.*', '^onnn,.*', '^ontat,.*', '^opalkelly,.*', '^openailab,.*', '^opencores,.*', '^openembed,.*', '^openpandora,.*', '^openrisc,.*', '^openwrt,.*', '^option,.*', '^oranth,.*', '^orisetech,.*', '^ortustech,.*', '^osddisplays,.*', '^osmc,.*', '^ouya,.*', '^overkiz,.*', '^ovti,.*', '^oxsemi,.*', '^ozzmaker,.*', '^panasonic,.*', '^parade,.*', '^parallax,.*', '^particle,.*', '^pda,.*', '^pegatron,.*', '^pericom,.*', '^pervasive,.*', '^phicomm,.*', '^phontech,.*', '^phytec,.*', '^picochip,.*', '^pinctrl-[0-9]+$', '^pine64,.*', '^pineriver,.*', '^pixcir,.*', '^plantower,.*', '^plathome,.*', '^plda,.*', '^plx,.*', '^ply,.*', '^pni,.*', '^pocketbook,.*', '^polaroid,.*', '^polyhex,.*', '^pool[0-3],.*', '^portwell,.*', '^poslab,.*', '^pov,.*', '^powertip,.*', '^powervr,.*', '^powkiddy,.*', '^pri,.*', '^primeview,.*', '^primux,.*', '^probox2,.*', '^prt,.*', '^pulsedlight,.*', '^purism,.*', '^puya,.*', '^qca,.*', '^qcom,.*', '^qemu,.*', '^qi,.*', '^qiaodian,.*', '^qihua,.*', '^qishenglong,.*', '^qnap,.*', '^quanta,.*', '^radxa,.*', '^raidsonic,.*', '^ralink,.*', '^ramtron,.*', '^raspberrypi,.*', '^raumfeld,.*', '^raydium,.*', '^raystar,.*', '^rda,.*', '^realtek,.*', '^relfor,.*', '^remarkable,.*', '^renesas,.*', '^rervision,.*', '^retronix,.*', '^revotics,.*', '^rex,.*', '^rfdigital,.*', '^richtek,.*', '^ricoh,.*', '^rikomagic,.*', '^riot,.*', '^riscv,.*', '^rockchip,.*', '^rocktech,.*', '^rohm,.*', '^ronbo,.*', '^ronetix,.*', '^roofull,.*', '^roseapplepi,.*', '^rve,.*', '^saef,.*', '^sakurapi,.*', '^samsung,.*', '^samtec,.*', '^sancloud,.*', '^sandisk,.*', '^satoz,.*', '^sbs,.*', '^schindler,.*', '^schneider,.*', '^schulercontrol,.*', '^sciosense,.*', '^sdmc,.*', '^seagate,.*', '^seeed,.*', '^seirobotics,.*', '^semtech,.*', '^senseair,.*', '^sensirion,.*', '^sensortek,.*', '^sercomm,.*', '^sff,.*', '^sgd,.*', '^sgmicro,.*', '^sgx,.*', '^sharp,.*', '^shift,.*', '^shimafuji,.*', '^shineworld,.*', '^shiratech,.*', '^si-en,.*', '^si-linux,.*', '^sielaff,.*', '^siemens,.*', '^sifive,.*', '^siflower,.*', '^sigma,.*', '^sii,.*', '^sil,.*', '^silabs,.*', '^silan,.*', '^silead,.*', '^silergy,.*', '^silex-insight,.*', '^siliconfile,.*', '^siliconmitus,.*', '^silvaco,.*', '^simtek,.*', '^sinlinx,.*', '^sinovoip,.*', '^sinowealth,.*', '^sipeed,.*', '^sirf,.*', '^sis,.*', '^sitronix,.*', '^skov,.*', '^skyworks,.*', '^smartfiber,.*', '^smartlabs,.*', '^smartrg,.*', '^smi,.*', '^smsc,.*', '^snps,.*', '^sochip,.*', '^socionext,.*', '^solidrun,.*', '^solomon,.*', '^somfy,.*', '^sony,.*', '^sophgo,.*', '^sourceparts,.*', '^spacemit,.*', '^spansion,.*', '^sparkfun,.*', '^spinalhdl,.*', '^sprd,.*', '^square,.*', '^ssi,.*', '^sst,.*', '^sstar,.*', '^st,.*', '^st-ericsson,.*', '^starfive,.*', '^starry,.*', '^startek,.*', '^starterkit,.*', '^ste,.*', '^stericsson,.*', '^storlink,.*', '^storm,.*', '^storopack,.*', '^summit,.*', '^sunchip,.*', '^sundance,.*', '^sunplus,.*', '^supermicro,.*', '^swir,.*', '^syna,.*', '^synaptics,.*', '^synology,.*', '^synopsys,.*', '^taos,.*', '^tbs,.*', '^tbs-biometrics,.*', '^tcg,.*', '^tcl,.*', '^tcs,.*', '^tcu,.*', '^tdo,.*', '^team-source-display,.*', '^technexion,.*', '^technologic,.*', '^techstar,.*', '^techwell,.*', '^teejet,.*', '^teltonika,.*', '^tempo,.*', '^tenda,.*', '^tenstorrent,.*', '^terasic,.*', '^tesla,.*', '^test,.*', '^tfc,.*', '^thead,.*', '^thine,.*', '^thingyjp,.*', '^thundercomm,.*', '^thwc,.*', '^ti,.*', '^tianma,.*', '^tlm,.*', '^tmt,.*', '^topeet,.*', '^topic,.*', '^topland,.*', '^toppoly,.*', '^topwise,.*', '^toradex,.*', '^toshiba,.*', '^toumaz,.*', '^tpk,.*', '^tplink,.*', '^tpo,.*', '^tq,.*', '^transpeed,.*', '^traverse,.*', '^tronfy,.*', '^tronsmart,.*', '^truly,.*', '^tsd,.*', '^turing,.*', '^tuxedo,.*', '^tyan,.*', '^tyhx,.*', '^u-blox,.*', '^u-boot,.*', '^ubnt,.*', '^ucrobotics,.*', '^udoo,.*', '^ufispace,.*', '^ugoos,.*', '^ultrarisc,.*', '^ultratronik,.*', '^uni-t,.*', '^uniwest,.*', '^upisemi,.*', '^urt,.*', '^usi,.*', '^usr,.*', '^utoo,.*', '^v3,.*', '^vaisala,.*', '^valve,.*', '^vamrs,.*', '^variscite,.*', '^vdl,.*', '^verisilicon,.*', '^vertexcom,.*', '^via,.*', '^vialab,.*', '^vicor,.*', '^videostrong,.*', '^virtio,.*', '^virtual,.*', '^vishay,.*', '^visionox,.*', '^vitesse,.*', '^vivante,.*', '^vivax,.*', '^vocore,.*', '^voipac,.*', '^voltafield,.*', '^vot,.*', '^vscom,.*', '^vxt,.*', '^wacom,.*', '^wanchanglong,.*', '^wand,.*', '^waveshare,.*', '^wd,.*', '^we,.*', '^welltech,.*', '^wetek,.*', '^wexler,.*', '^whwave,.*', '^wi2wi,.*', '^widora,.*', '^wiligear,.*', '^willsemi,.*', '^winbond,.*', '^wingtech,.*', '^winlink,.*', '^winsen,.*', '^winstar,.*', '^wirelesstag,.*', '^wits,.*', '^wlf,.*', '^wm,.*', '^wobo,.*', '^wolfvision,.*', '^x-powers,.*', '^xen,.*', '^xes,.*', '^xiaomi,.*', '^xicor,.*', '^xillybus,.*', '^xingbangda,.*', '^xinpeng,.*', '^xiphera,.*', '^xlnx,.*', '^xnano,.*', '^xunlong,.*', '^xylon,.*', '^yadro,.*', '^yamaha,.*', '^yes-optoelectronics,.*', '^yic,.*', '^yiming,.*', '^ylm,.*', '^yna,.*', '^yones-toptech,.*', '^ys,.*', '^ysoft,.*', '^yuridenki,.*', '^yuzukihd,.*', '^zarlink,.*', '^zealz,.*', '^zeitec,.*', '^zidoo,.*', '^zii,.*', '^zinitix,.*', '^zkmagic,.*', '^zte,.*', '^zyxel,.*'
from schema $id: http://devicetree.org/schemas/vendor-prefixes.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#2 lore raw
In reply to Soham Kute
Quoted 20 lines · Soham Kute

Document the Google Arche platform which enables the Unipro link between the application processor and the SVC in a Greybus-based system.

---
 .../greybus/google,arche-platform.yaml        | 71 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/greybus/google,arche-platform.yaml
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +3 -0
new file mode 100644
index 000000000000..6e176efc264a
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 13

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+$id: http://devicetree.org/schemas/greybus/google,arche-platform.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Arche Platform
+
+maintainers:
+  - Vaibhav Hiremath <[email protected]>
+
+description:
+  The Arche platform driver enables the Unipro link between the

You need to describe hardware, not drivers.

This wasn't tested, so limited review.

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 19

Quoted 6 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +6 -0
+  application processor and the SVC (Supervisory Controller) in
+  a Greybus-based system.
+
+properties:
+  compatible:
+    const: google,arche-platform

Your description is insufficient. Is this SoC? Is this device? Compatible is way too generic and "platform" is not correct in the compatible. Everything can be a platform.

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 21

Quoted 2 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +2 -0
+
+  svc,reset-gpios:

No, use standard properties.

There is no such company as svc.

Quoted 7 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +7 -0
+    description: GPIO used to reset the SVC
+    maxItems: 1
+
+  svc,sysboot-gpios:
+    description: GPIO used for SVC sysboot signal
+    maxItems: 1
+

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 38

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+  svc,refclk-req-gpios:
+    description: GPIO used to request the SVC reference clock
+    maxItems: 1
+
+  svc,wake-detect-gpios:
+    description: Bidirectional GPIO for wake/detect signal between AP and SVC
+    maxItems: 1
+
+  clocks:
+    description: SVC reference clock

What is SVC?

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 43

Quoted 5 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +5 -0
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: svc_ref_clk

Drop names

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+
+  svc,reset-active-high:
+    description: Present if the SVC reset GPIO is active high
+    type: boolean
+
+additionalProperties: false
+
+required:
+  - compatible
+  - svc,reset-gpios

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 63

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+  - svc,sysboot-gpios
+  - svc,refclk-req-gpios
+  - svc,wake-detect-gpios
+  - clocks
+  - clock-names
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    arche-platform {

Again, what is arche-platform?

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel sources for similar cases or you can grow the spec (via pull request to DT spec repo).

Quoted 13 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +8 -0
+        compatible = "google,arche-platform";
+        svc,reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
+        svc,sysboot-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
+        svc,refclk-req-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;
+        svc,wake-detect-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>;
+        clocks = <&svc_ref_clk>;
+        clock-names = "svc_ref_clk";
+    };
MAINTAINERS +0 -0
index e08767323763..46cb6825f4d6 100644

MAINTAINERS S: Maintained · line 10889

Quoted 4 lines
MAINTAINERS +1 -0
@@ -10886,6 +10886,7 @@ S:	Maintained
 F:	drivers/staging/greybus/arche-apb-ctrl.c
 F:	drivers/staging/greybus/arche-platform.c
 F:	drivers/staging/greybus/arche_platform.h
+F:	Documentation/devicetree/bindings/greybus/google,arche-platform.yaml

Don't send bindings to match staging code. This is not the correct process. You must come with proper bindings for hardware, following standard review process like there was nothing in the staging. It's second bindings this week, is this some sort of GSoC again without any supervision?

Best regards,
Krzysztof

author
#3 lore raw

Subject: Re: [PATCH] dt-bindings: greybus: Document google,arche-platform

Hi Krzysztof, Rob,

Apologies for the noise. I am a kernel newcomer and clearly jumped ahead of myself here. I wrote this binding based on reading the driver code rather than properly understanding the hardware first. That was the wrong approach.

I've noted all your points, the compatible string, generic node names, standard properties, and most importantly that bindings must describe hardware not drivers.

Sorry again for the premature submission.

Soham

Quoted 140 lines · Krzysztof Kozlowski
Quoted 20 lines · Soham Kute

Document the Google Arche platform which enables the Unipro link between the application processor and the SVC in a Greybus-based system.

---
 .../greybus/google,arche-platform.yaml        | 71 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/greybus/google,arche-platform.yaml
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +3 -0
new file mode 100644
index 000000000000..6e176efc264a
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 13

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+$id: http://devicetree.org/schemas/greybus/google,arche-platform.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Arche Platform
+
+maintainers:
+  - Vaibhav Hiremath <[email protected]>
+
+description:
+  The Arche platform driver enables the Unipro link between the

You need to describe hardware, not drivers.

This wasn't tested, so limited review.

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 19

Quoted 6 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +6 -0
+  application processor and the SVC (Supervisory Controller) in
+  a Greybus-based system.
+
+properties:
+  compatible:
+    const: google,arche-platform

Your description is insufficient. Is this SoC? Is this device? Compatible is way too generic and "platform" is not correct in the compatible. Everything can be a platform.

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 21

Quoted 2 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +2 -0
+
+  svc,reset-gpios:

No, use standard properties.

There is no such company as svc.

Quoted 7 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +7 -0
+    description: GPIO used to reset the SVC
+    maxItems: 1
+
+  svc,sysboot-gpios:
+    description: GPIO used for SVC sysboot signal
+    maxItems: 1
+

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 38

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+  svc,refclk-req-gpios:
+    description: GPIO used to request the SVC reference clock
+    maxItems: 1
+
+  svc,wake-detect-gpios:
+    description: Bidirectional GPIO for wake/detect signal between AP and SVC
+    maxItems: 1
+
+  clocks:
+    description: SVC reference clock

What is SVC?

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 43

Quoted 5 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +5 -0
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: svc_ref_clk

Drop names

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+
+  svc,reset-active-high:
+    description: Present if the SVC reset GPIO is active high
+    type: boolean
+
+additionalProperties: false
+
+required:
+  - compatible
+  - svc,reset-gpios

Documentation/devicetree/bindings/greybus/google,arche-platform.yaml line 63

Quoted 10 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +10 -0
+  - svc,sysboot-gpios
+  - svc,refclk-req-gpios
+  - svc,wake-detect-gpios
+  - clocks
+  - clock-names
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    arche-platform {

Again, what is arche-platform?

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel sources for similar cases or you can grow the spec (via pull request to DT spec repo).

Quoted 13 lines
Documentation/devicetree/bindings/greybus/google,arche-platform.yaml new file +8 -0
+        compatible = "google,arche-platform";
+        svc,reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
+        svc,sysboot-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
+        svc,refclk-req-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;
+        svc,wake-detect-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>;
+        clocks = <&svc_ref_clk>;
+        clock-names = "svc_ref_clk";
+    };
MAINTAINERS +0 -0
index e08767323763..46cb6825f4d6 100644

MAINTAINERS S: Maintained · line 10889

Quoted 4 lines
MAINTAINERS +1 -0
@@ -10886,6 +10886,7 @@ S:    Maintained
 F:   drivers/staging/greybus/arche-apb-ctrl.c
 F:   drivers/staging/greybus/arche-platform.c
 F:   drivers/staging/greybus/arche_platform.h
+F:   Documentation/devicetree/bindings/greybus/google,arche-platform.yaml

Don't send bindings to match staging code. This is not the correct process. You must come with proper bindings for hardware, following standard review process like there was nothing in the staging. It's second bindings this week, is this some sort of GSoC again without any supervision?

Best regards,
Krzysztof