Skip to contentSkip to conversation

i3c: master: dw-i3c: Fix missing of_node for virtual I2C adapter

PATCH Applied Peter Yin 3 participants 3 messages Mar 2 – Mar 11

Subsystems (2)
lore
Share & tools
lore

Peter Yin

author
#0 lore raw

PATCH v3 1/1 i3c: master: dw-i3c: Fix missing of_node for virtual I2C adapter

The DesignWare I3C master driver creates a virtual I2C adapter to provide backward compatibility with I2C devices. However, the current implementation does not associate this virtual adapter with any Device Tree node.

Propagate the of_node from the I3C master platform device to the virtual I2C adapter's device structure. This ensures that standard I2C aliases are correctly resolved and bus numbering remains consistent.

---

Changes in v3:
- Use device_set_of_node_from_dev() instead of direct of_node assignment.

Changes in v2:
- Move the fix from the ast2600-specific driver to the dw-i3c common.

 drivers/i3c/master/dw-i3c-master.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i3c/master/dw-i3c-master.c +2 -0
index d87bde3f7700..d334c217c7a3 100644
@@ -1659,6 +1659,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 		pm_runtime_get_noresume(&pdev->dev);
 
 	INIT_WORK(&master->hj_work, dw_i3c_hj_work);
+
+	device_set_of_node_from_dev(&master->base.i2c.dev, &pdev->dev);
 	ret = i3c_master_register(&master->base, &pdev->dev,
 				  &dw_mipi_i3c_ops, false);
 	if (ret)

--
2.43.0

reviewer Reviewed-by on v3 1/1
#1 lore raw
Quoted 11 lines · Peter Yin

The DesignWare I3C master driver creates a virtual I2C adapter to provide backward compatibility with I2C devices. However, the current implementation does not associate this virtual adapter with any Device Tree node.

Propagate the of_node from the I3C master platform device to the virtual I2C adapter's device structure. This ensures that standard I2C aliases are correctly resolved and bus numbering remains consistent.

---

Quoted 26 lines

Changes in v3:
- Use device_set_of_node_from_dev() instead of direct of_node assignment.

Changes in v2:
- Move the fix from the ast2600-specific driver to the dw-i3c common.

 drivers/i3c/master/dw-i3c-master.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i3c/master/dw-i3c-master.c +2 -1
index d87bde3f7700..d334c217c7a3 100644
@@ -1659,6 +1659,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 		pm_runtime_get_noresume(&pdev->dev);
 
 	INIT_WORK(&master->hj_work, dw_i3c_hj_work);
+
+	device_set_of_node_from_dev(&master->base.i2c.dev, &pdev->dev);
 	ret = i3c_master_register(&master->base, &pdev->dev,
 				  &dw_mipi_i3c_ops, false);
 	if (ret)
--

2.43.0

maintainer Applied
#2 lore raw
In reply to Peter Yin
Quoted 10 lines · Peter Yin

The DesignWare I3C master driver creates a virtual I2C adapter to provide backward compatibility with I2C devices. However, the current implementation does not associate this virtual adapter with any Device Tree node.

Propagate the of_node from the I3C master platform device to the virtual I2C adapter's device structure. This ensures that standard I2C aliases are correctly resolved and bus numbering remains consistent.

[...]

Applied, thanks!

[1/1] i3c: master: dw-i3c: Fix missing of_node for virtual I2C adapter

      https://git.kernel.org/i3c/c/f26ecaa0f0ab

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com