ASoC: tegra: Add Tegra238 sound card support

PATCH Superseded Sheetal . 4 participants 10 messages Mar 2 – Mar 13

Subsystems (4)

Device tree bindings Sound ASoC Tegra architecture support

lore

Share & tools

lore

Sheetal .

author

2026-03-02 08:54 UTC #0 lore raw

cover ASoC: tegra: Add Tegra238 sound card support

From: sheetal <[email protected]>

Add Tegra238 sound card support in the Tegra audio graph card driver, as Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to other Tegra platforms.

Sheetal (2):
ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card
ASoC: tegra: Add support for Tegra238 soundcard

 .../sound/nvidia,tegra-audio-graph-card.yaml        |  1 +
 sound/soc/tegra/tegra_audio_graph_card.c            | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

Signature · 1 line

2.34.1

Sheetal .

author

2026-03-02 08:54 UTC #1 lore raw

PATCH 1/2 ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card

From: Sheetal <[email protected]>

Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to other Tegra platforms. Add Tegra238 compatible string to the APE tegra-audio-graph-card bindings.

Signed-off-by Sheetal <[email protected]>

---
 .../devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml | 1 +
 1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml +1 -0

index da89523ccf5f..92bc3ef56f2c 100644
@@ -23,6 +23,7 @@ properties:
     enum:
       - nvidia,tegra210-audio-graph-card
       - nvidia,tegra186-audio-graph-card
+      - nvidia,tegra238-audio-graph-card
       - nvidia,tegra264-audio-graph-card
 
   clocks:

Signature · 1 line

2.34.1

Krzysztof Kozlowski

Acked-by on v1 1/2

2026-03-02 09:03 UTC #2 lore raw

Re: [PATCH 1/2] ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card

Quoted 7 lines · Sheetal .

From: Sheetal <[email protected]>
Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to other Tegra platforms. Add Tegra238 compatible string to the APE tegra-audio-graph-card bindings.
Signed-off-by Sheetal <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Sheetal .

author

2026-03-02 08:54 UTC #3 lore raw

PATCH 2/2 ASoC: tegra: Add support for Tegra238 soundcard

In reply to Sheetal .

From: Sheetal <[email protected]>

Tegra238 platforms use different clock rates for plla and plla_out0 clocks. Add Tegra238 support in the Tegra sound card driver to apply specific clock configurations.

Signed-off-by Aditya Bavanari <[email protected]>

Signed-off-by Sheetal <[email protected]>

---
 sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

sound/soc/tegra/tegra_audio_graph_card.c +12 -1

index 94b5ab77649b..b6dadd6a3d3d 100644
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
+// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
 //
 // tegra_audio_graph_card.c - Audio Graph based Tegra Machine Driver

@@ -231,6 +231,15 @@ static const struct tegra_audio_cdata tegra186_data = {
 	.plla_out0_rates[x11_RATE] = 45158400,
 };
 
+static const struct tegra_audio_cdata tegra238_data = {
+	/* PLLA */
+	.plla_rates[x8_RATE] = 1277952000,
+	.plla_rates[x11_RATE] = 1264435200,
+	/* PLLA_OUT0 */
+	.plla_out0_rates[x8_RATE] = 49152000,
+	.plla_out0_rates[x11_RATE] = 45158400,
+};
+
 static const struct tegra_audio_cdata tegra264_data = {
 	/* PLLA1 */
 	.plla_rates[x8_RATE] = 983040000,

@@ -245,6 +254,8 @@ static const struct of_device_id graph_of_tegra_match[] = {
 	  .data = &tegra210_data },
 	{ .compatible = "nvidia,tegra186-audio-graph-card",
 	  .data = &tegra186_data },
+	{ .compatible = "nvidia,tegra238-audio-graph-card",
+	  .data = &tegra238_data },
 	{ .compatible = "nvidia,tegra264-audio-graph-card",
 	  .data = &tegra264_data },
 	{},

Signature · 1 line

2.34.1

Krzysztof Kozlowski

2026-03-02 09:04 UTC #4 lore raw

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

Quoted 17 lines · Sheetal .

From: Sheetal <[email protected]>
Tegra238 platforms use different clock rates for plla and plla_out0 clocks. Add Tegra238 support in the Tegra sound card driver to apply specific clock configurations.
Signed-off-by Aditya Bavanari <[email protected]>
Signed-off-by Sheetal <[email protected]>
---
 sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
sound/soc/tegra/tegra_audio_graph_card.c +0 -0
index 94b5ab77649b..b6dadd6a3d3d 100644

sound/soc/tegra/tegra_audio_graph_card.c line 2

Quoted 3 lines

sound/soc/tegra/tegra_audio_graph_card.c +1 -1

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
+// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.

If updating it, you should rather drop it and use standard copyright. This tag is not supported in kernel in general and I document it only because it already spread all over.

Best regards,
Krzysztof

Jon Hunter

maintainer

2026-03-03 14:24 UTC #5 lore raw

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

Quoted 13 lines · Krzysztof Kozlowski

Quoted 12 lines · Sheetal .
From: Sheetal <[email protected]>
Tegra238 platforms use different clock rates for plla and plla_out0 clocks. Add Tegra238 support in the Tegra sound card driver to apply specific clock configurations.
Signed-off-by Aditya Bavanari <[email protected]>
Signed-off-by Sheetal <[email protected]>
---
  sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
  1 file changed, 12 insertions(+), 1 deletion(-)

Quoted 12 lines

sound/soc/tegra/tegra_audio_graph_card.c line 2
Quoted 8 lines
sound/soc/tegra/tegra_audio_graph_card.c +1 -1
index 94b5ab77649b..b6dadd6a3d3d 100644
@@ -1,5 +1,5 @@
  // SPDX-License-Identifier: GPL-2.0-only
-// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
+// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
If updating it, you should rather drop it and use standard copyright. This tag is not supported in kernel in general and I document it only because it already spread all over.

To be clear, you mean that 'SPDX-FileCopyrightText' is not supported? Where exactly do you document it for reference?

I know that Rob previously indicated that the 'Copyright' string in the above was redundant, but we have been told to keep this by the people at NVIDIA that specify how we should be formatting such tags when adding NVIDIA copyrights.

Jon

Signature · 1 line

nvpublic

Krzysztof Kozlowski

2026-03-03 14:54 UTC #6 lore raw

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

Quoted 28 lines · Jon Hunter

Quoted 13 lines · Krzysztof Kozlowski
Quoted 12 lines · Sheetal .
From: Sheetal <[email protected]>
Tegra238 platforms use different clock rates for plla and plla_out0 clocks. Add Tegra238 support in the Tegra sound card driver to apply specific clock configurations.
Signed-off-by Aditya Bavanari <[email protected]>
Signed-off-by Sheetal <[email protected]>
---
  sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
  1 file changed, 12 insertions(+), 1 deletion(-)
Quoted 12 lines
sound/soc/tegra/tegra_audio_graph_card.c line 2
Quoted 8 lines
sound/soc/tegra/tegra_audio_graph_card.c +1 -1
index 94b5ab77649b..b6dadd6a3d3d 100644
@@ -1,5 +1,5 @@
  // SPDX-License-Identifier: GPL-2.0-only
-// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
+// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
If updating it, you should rather drop it and use standard copyright. This tag is not supported in kernel in general and I document it only because it already spread all over.

Quoted 1 line

To be clear, you mean that 'SPDX-FileCopyrightText' is not supported?

Yes

Quoted 1 line

Where exactly do you document it for reference?

paste SPDX-FileCopyrightText in lore

Quoted 5 lines

I know that Rob previously indicated that the 'Copyright' string in the above was redundant, but we have been told to keep this by the people at NVIDIA that specify how we should be formatting such tags when adding NVIDIA copyrights.

For the kernel, for most of us, most likely legally it is redundant and Rob was right, but some companies insist on it and I don't want to discuss with them, because they never use actual arguments except "my legal told me I must do", so you can have it. That's not a problem.

Best regards,
Krzysztof

Jon Hunter

maintainer

2026-03-03 16:38 UTC #7 lore raw

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

On 03/03/2026 14:54, Krzysztof Kozlowski wrote:

...

Quoted 3 lines

Quoted 1 line
Where exactly do you document it for reference?
paste SPDX-FileCopyrightText in lore

Got it!

Quoted 9 lines

Quoted 4 lines
I know that Rob previously indicated that the 'Copyright' string in the above was redundant, but we have been told to keep this by the people at NVIDIA that specify how we should be formatting such tags when adding NVIDIA copyrights.
For the kernel, for most of us, most likely legally it is redundant and Rob was right, but some companies insist on it and I don't want to discuss with them, because they never use actual arguments except "my legal told me I must do", so you can have it. That's not a problem.

Before I had requested we change this everywhere but there was concern that we would have slightly different variants in different places. What I could ask if for the kernel we can just use ...

Although I see some instances in the kernel with 'NVIDIA CORPORATION & AFFILIATES' and so they may want ...

Anyway, would the above be acceptable?

Jon

Signature · 1 line

nvpublic

Krzysztof Kozlowski

2026-03-13 17:14 UTC #8 lore raw

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

Quoted 27 lines · Jon Hunter

On 03/03/2026 14:54, Krzysztof Kozlowski wrote:
...
Quoted 3 lines
Quoted 1 line
Where exactly do you document it for reference?
paste SPDX-FileCopyrightText in lore
Got it!
Quoted 9 lines
Quoted 4 lines
I know that Rob previously indicated that the 'Copyright' string in the above was redundant, but we have been told to keep this by the people at NVIDIA that specify how we should be formatting such tags when adding NVIDIA copyrights.
For the kernel, for most of us, most likely legally it is redundant and Rob was right, but some companies insist on it and I don't want to discuss with them, because they never use actual arguments except "my legal told me I must do", so you can have it. That's not a problem.
Before I had requested we change this everywhere but there was concern that we would have slightly different variants in different places. What I could ask if for the kernel we can just use ...
SPDX-FileCopyrightText: <date> NVIDIA CORPORATION. All rights reserved.

Quoted 7 lines

Although I see some instances in the kernel with 'NVIDIA CORPORATION & AFFILIATES' and so they may want ...
SPDX-FileCopyrightText: <date> NVIDIA CORPORATION & AFFILIATES. All
rights reserved.
Anyway, would the above be acceptable?

I suggest to drop the SPDX and use standard Copyright. I do not have preference what goes after the copyright, especially that some companies have odd choices and - as Greg KH once explained to me - it does not matter for us.

Best regards,
Krzysztof

Mark Brown

maintainer

2026-03-03 11:20 UTC #9 lore raw

Re: (subset) [PATCH 0/2] ASoC: tegra: Add Tegra238 sound card support

In reply to Sheetal .

Quoted 9 lines · Sheetal .

Add Tegra238 sound card support in the Tegra audio graph card driver, as Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to other Tegra platforms.
Sheetal (2):
ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card
ASoC: tegra: Add support for Tegra238 soundcard
[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card

      commit: a8df7892a9f42b2e2d5851f8835c734bd7fe8ad4

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark