package/iniparser: new package

PATCH Superseded [email protected] 2 participants 3 messages Mar 3 – Mar 4

lore

Share & tools

lore

[email protected]

author

2026-03-03 09:51 UTC #0 lore raw

PATCH 1/1 package/iniparser: new package

From: Chen Pei <[email protected]>

The iniparser is a simple C library offering ini file parsing services.

ndctl[1] requires it.

[1] https://github.com/pmem/ndctl

Signed-off-by Chen Pei <[email protected]>

---
 package/Config.in                |  1 +
 package/iniparser/Config.in      |  7 +++++++
 package/iniparser/iniparser.hash |  3 +++
 package/iniparser/iniparser.mk   | 14 ++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/iniparser/Config.in
 create mode 100644 package/iniparser/iniparser.hash
 create mode 100644 package/iniparser/iniparser.mk

package/Config.in +1 -0

index 20c9a2e155..d1dce9c4d7 100644
@@ -2336,6 +2336,7 @@ menu "Text and terminal handling"
 	source "package/fstrcmp/Config.in"
 	source "package/icu/Config.in"
 	source "package/inih/Config.in"
+	source "package/iniparser/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libecoli/Config.in"
 	source "package/libedit/Config.in"

package/iniparser/Config.in new file +7 -0

new file mode 100644
index 0000000000..56764c04e6
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_INIPARSER
+	bool "iniparser"
+	help
+	  iniparser is a simple C library offering ini file
+	  parsing services.
+
+	  https://gitlab.com/iniparser/iniparser

package/iniparser/iniparser.hash new file +3 -0

new file mode 100644
index 0000000000..27a5fa81aa
@@ -0,0 +1,3 @@
+# locally computed
+sha256  67575ed032a544d5359610e5f697af786371bbc3eb01311218ef8adfd3e5e329  iniparser-v4.2.6.tar.gz
+sha256  da809b67f3cc571433b7b97d4253ae1f9d8817770aa859aad202df6bde1d5fde  LICENSE

package/iniparser/iniparser.mk new file +14 -0

new file mode 100644
index 0000000000..9034a1cb78
@@ -0,0 +1,14 @@
+################################################################################
+#
+# iniparser
+#
+################################################################################
+
+INIPARSER_VERSION = v4.2.6
+INIPARSER_SITE = https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
+INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
+INIPARSER_INSTALL_STAGING = YES
+INIPARSER_LICENSE = MIT
+INIPARSER_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))

Signature · 6 lines

2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Julien Olivain via buildroot

2026-03-03 18:08 UTC #1 lore raw

Hi Chen,

Thanks for the patch. I have two minor comments, see below.

Quoted 10 lines · On 03/03/2026 10:50, [email protected] wrote:

From: Chen Pei <[email protected]>
The iniparser is a simple C library offering ini file parsing services.
ndctl[1] requires it.
[1] https://github.com/pmem/ndctl
Signed-off-by Chen Pei <[email protected]>
---

[...]

Quoted 14 lines

package/iniparser/iniparser.mk new file +8 -0

new file mode 100644
index 0000000000..9034a1cb78
@@ -0,0 +1,14 @@
+################################################################################
+#
+# iniparser
+#
+################################################################################
+
+INIPARSER_VERSION = v4.2.6
+INIPARSER_SITE =

Quoted 2 lines

https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
+INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz

Could you move the "v" from the _VERSION to _SITE and update _SOURCE, please? This will allow our version monitoring scripts to work better. We should preferably have:

INIPARSER_VERSION = 4.2.6
INIPARSER_SITE = https://gitlab.com/iniparser/iniparser/-/archive/v$(INIPARSER_VERSION)
INIPARSER_SOURCE = iniparser-v$(INIPARSER_VERSION).tar.gz

Note: your initial submission was also reporting an error, which should be fixed indirectly with the change I propose. Please make sure to run the command "utils/docker-run make check-package" before sending patches. See:
https://nightly.buildroot.org/manual.html#_preparing_a_patch_series

Quoted 7 lines

package/iniparser/iniparser.mk new file +5 -1

+INIPARSER_INSTALL_STAGING = YES
+INIPARSER_LICENSE = MIT
+INIPARSER_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))
--

2.50.1

Also, quoting the Buildroot documentation at:
https://nightly.buildroot.org/manual.html#DEVELOPERS
"""
We ask developers adding new packages, new boards, or generally new functionality in Buildroot, to register themselves in the DEVELOPERS file. As an example, we expect a developer contributing a new package to include in his patch the appropriate modification to the DEVELOPERS file. """

Note that will received emails from the autobuilders in case of build failures, and from other developers using the get-developers script.

Could you add a new entry in the DEVELOPERS file registering yourself to this new package?

Could you send an updated v2 patch with those changes, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

[email protected]

author

2026-03-04 07:05 UTC #2 lore raw

Quoted 62 lines · On Tue, 03 Mar 2026 19:08:41 +0100, [email protected] wrote:

Quoted 10 lines
From: Chen Pei <[email protected]>
The iniparser is a simple C library offering ini file parsing services.
ndctl[1] requires it.
[1] https://github.com/pmem/ndctl
Signed-off-by Chen Pei <[email protected]>
---
[...]
Quoted 15 lines
package/iniparser/iniparser.mk new file +8 -0
new file mode 100644
index 0000000000..9034a1cb78
@@ -0,0 +1,14 @@
+################################################################################
+#
+# iniparser
+#
+################################################################################
+
+INIPARSER_VERSION = v4.2.6
+INIPARSER_SITE = 
Quoted 2 lines
https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
+INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
Could you move the "v" from the _VERSION to _SITE and update _SOURCE, please? This will allow our version monitoring scripts to work better. We should preferably have:
INIPARSER_VERSION = 4.2.6
INIPARSER_SITE =
https://gitlab.com/iniparser/iniparser/-/archive/v$(INIPARSER_VERSION)
INIPARSER_SOURCE = iniparser-v$(INIPARSER_VERSION).tar.gz
Note: your initial submission was also reporting an error, which should be fixed indirectly with the change I propose. Please make sure to run the command "utils/docker-run make check-package" before sending patches. See:
https://nightly.buildroot.org/manual.html#_preparing_a_patch_series
Quoted 7 lines
package/iniparser/iniparser.mk new file +5 -1
+INIPARSER_INSTALL_STAGING = YES
+INIPARSER_LICENSE = MIT
+INIPARSER_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))
--
2.50.1
Also, quoting the Buildroot documentation at:
https://nightly.buildroot.org/manual.html#DEVELOPERS
"""
We ask developers adding new packages, new boards, or generally new functionality in Buildroot, to register themselves in the DEVELOPERS file. As an example, we expect a developer contributing a new package to include in his patch the appropriate modification to the DEVELOPERS file.
"""

Quoted 9 lines

Note that will received emails from the autobuilders in case of build failures, and from other developers using the get-developers script.
Could you add a new entry in the DEVELOPERS file registering yourself to this new package?
Could you send an updated v2 patch with those changes, please?

Hi, Julien,

Thank you for your review and reminder. I will send an v2 patch, update iniparser.mk, and add a new entry in the DEVELOPERS.

Thanks,
Pei

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot