Skip to contentSkip to conversation

Rewrite ftrace_regression01.sh with new C API

PATCH In review lufei 6 participants 16 messages Mar 4 – Apr 28

lore
Share & tools
lore

lufei

author
#0 lore raw

PATCH 1/2 Rewrite ftrace_regression01.sh with new C API

This is regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

---
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 .../tracing/ftrace_test/ftrace_regression.h   | 34 ++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 85 +++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 ------------------
 4 files changed, 121 insertions(+), 83 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +34 -0
new file mode 100644
index 000000000..c19d3d8fd
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * Copyright (c) 2026 lufei <[email protected]>
+ *
+ * Shared header for ftrace regression tests.
+ */
+
+#ifndef FTRACE_REGRESSION_H
+#define FTRACE_REGRESSION_H
+
+#include "tst_test.h"
+#include "tst_safe_file_ops.h"
+#include <string.h>
+
+#define FTRACE_FILE_CONTAINS_BUF_SIZE (1024 * 1024)
+
+/**
+ * file_contains - Check if a file contains the given string
+ * path: Path to the file
+ * str: String to search for
+ *
+ * Returns: 1 if file contains str, 0 otherwise
+ */
+static inline int file_contains(const char *path, const char *str)
+{
+	char buf[FTRACE_FILE_CONTAINS_BUF_SIZE];
+
+	buf[0] = '\0';
+	SAFE_FILE_SCANF(path, "%1048575[^\x01]", buf);
+	return strstr(buf, str) != NULL;
+}
+
+#endif /* FTRACE_REGRESSION_H */
+
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +85 -0

85 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#1 lore raw

PATCH 2/2 Rewrite ftrace_regression02.sh with new C API

This test is for checking signal:signal_generate gives 2 more fields:
grp res.

---
 .../tracing/ftrace_test/ftrace_regression02.c | 73 +++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +73 -0
new file mode 100644
index 000000000..aa3500090
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2015 Red Hat Inc.
+ * Copyright (c) 2026 lufei <[email protected]>
+ */
+
+/*\
+ *
+ * Check signal:signal_generate gives 2 more fields: grp res
+ *
+ */
+
+#include <unistd.h>
+#include <stdio.h>
+#include "ftrace_regression.h"
+
+#define DEBUGFS_DIR "debugfs"
+#define SET_EVENT DEBUGFS_DIR "/tracing/set_event"
+#define TRACING_ON DEBUGFS_DIR "/tracing/tracing_on"
+#define TRACE_FILE DEBUGFS_DIR "/tracing/trace"
+
+#define LOOP 100
+
+static void setup(void)
+{
+	SAFE_MKDIR(DEBUGFS_DIR, 0755);
+	SAFE_MOUNT(NULL, DEBUGFS_DIR, "debugfs", 0, NULL);
+}
+
+static void run(void)
+{
+	int i;
+
+	SAFE_FILE_PRINTF(SET_EVENT, "signal:signal_generate");
+	SAFE_FILE_PRINTF(TRACING_ON, "1");
+	SAFE_FILE_PRINTF(TRACE_FILE, "\n");
+
+	for (i = 0; i < LOOP; i++)
+		tst_cmd((const char *[]){"ls", "-l", "/proc", NULL},
+			"/dev/null", "/dev/null", 0);
+
+	if (file_contains(TRACE_FILE, "grp=") && file_contains(TRACE_FILE, "res="))
+		tst_res(TPASS, "Finished running the test");
+	else
+		tst_res(TFAIL, "Pattern grp=[0-9] res=[0-9] not found in trace");
+}
+
+static void cleanup(void)
+{
+	SAFE_UMOUNT(DEBUGFS_DIR);
+}
+
+static struct tst_test test = {
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.setup = setup,
+	.test_all = run,
+	.cleanup = cleanup,
+	.needs_cmds = (struct tst_cmd[]) {
+		{.cmd = "ls"},
+		{}
+	},
+	.save_restore = (const struct tst_path_val[]) {
+		{"/proc/sys/kernel/stack_tracer_enabled", NULL, TST_SR_TCONF},
+		{}
+	},
+	.tags = (const struct tst_tag[]) {
+		{"linux-git", "6c303d3"},
+		{"linux-git", "163566f"},
+		{}
+	},
+};
+
Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
In reply to lufei

Hi lufei,

A few issues need fixing before this can be merged.

[PATCH 1/2]

Quoted 4 lines

+/*\
+ * [Description]
+ *
+ * Regression test for panic while using userstacktrace.

Drop the [Description] tag, it's deprecated.

Quoted 1 line

+#define FTRACE_FILE_CONTAINS_BUF_SIZE (1024 * 1024)

[...]

testcases/kernel/tracing/ftrace_test/ftrace_regression.h line 26

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +3 -0
+static inline int file_contains(const char *path, const char *str)
+{
+	char buf[FTRACE_FILE_CONTAINS_BUF_SIZE];

This puts 1 MiB on the stack. Use SAFE_MALLOC/free or a static buffer instead.

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 58

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +2 -0
+		if (!file_contains(TRACE_OPTIONS, "userstacktrace"))
+			tst_brk(TBROK, "Failed to set userstacktrace");

strstr("nouserstacktrace", "userstacktrace") is true, so this check always passes even when the option is disabled. The original shell version used grep -q "^userstacktrace" which anchored to line start.

[PATCH 2/2]

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +0 -0

The old ftrace_regression02.sh is not deleted by this patch. You need to remove it, same as you did for ftrace_regression01.sh in patch 1/2.

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c

Quoted 4 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +4 -0
+	.save_restore = (const struct tst_path_val[]) {
+		{"/proc/sys/kernel/stack_tracer_enabled", NULL, TST_SR_TCONF},
+		{}
+	},

This test doesn't use stack_tracer_enabled. Looks like copy-paste from ftrace_regression01. Remove it.

The original shell test gated on kernel >= 3.2. Add .min_kver = "3.2" to preserve that check.

[Both patches]

The runtest/tracing entries still reference the .sh files:

ftrace_regression01 ftrace_regression01.sh
ftrace_regression02 ftrace_regression02.sh

Update them to point to the C binaries.

The Makefile has INSTALL_TARGETS := *.sh ftrace_stress/* which won't install the new C binaries. It needs updating as well.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#3 lore raw

PATCH v2 1/1 Rewrite ftrace_regression tests with new C API

In reply to lufei

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 testcases/kernel/tracing/ftrace_test/Makefile |  3 +-
 .../tracing/ftrace_test/ftrace_regression.h   | 65 +++++++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 83 +++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -------------------
 .../tracing/ftrace_test/ftrace_regression02.c | 70 ++++++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 --------------
 7 files changed, 222 insertions(+), 149 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01	ftrace_regression01.sh
-ftrace_regression02	ftrace_regression02.sh
+ftrace_regression01	ftrace_regression01
+ftrace_regression02	ftrace_regression02
 ftrace-stress-test	ftrace_stress_test.sh 90
 dynamic_debug01		dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/Makefile +2 -1
index e4a913a56..618cce7e1 100644
@@ -2,6 +2,7 @@ top_srcdir              ?= ../../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
-INSTALL_TARGETS         := *.sh ftrace_stress/*
+INSTALL_TARGETS         := *.sh ftrace_stress/* ftrace_regression01 \
+				ftrace_regression02
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +65 -0

65 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +83 -0

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +70 -0

70 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh deleted +0 -63

63 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Re: [LTP] [PATCH v2] Rewrite ftrace_regression tests with new C API

Hi lufei,

Quoted 2 lines

+/**
+ * file_contains_line - Check if a file ocntains specific line, strictly

Typo: "ocntains" -> "contains".

testcases/kernel/tracing/ftrace_test/ftrace_regression.h line 33

Quoted 6 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +6 -0
+static inline int file_contains(const char *path, const char *str)
+{
+	char *buf = SAFE_MALLOC(FTRACE_FILE_BUF_SIZE);
+
+	buf[0] = '\0';
+	SAFE_FILE_SCANF(path, "%1048575[^\x01]", buf);

The hardcoded width 1048575 must be kept in sync with FTRACE_FILE_BUF_SIZE - 1 manually. Also, allocating 1 MB on each call is heavy — file_contains() is called twice in ftrace_regression02. Consider a simpler file reading approach.

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +0 -0
new file mode 100644

[...]

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +3 -0
+	for (i = 0; i < LOOP; i++) {
+		SAFE_FILE_PRINTF(STACK_TRACER_PATH, "1");
+		SAFE_FILE_PRINTF(TRACE_OPTIONS, "userstacktrace");

[...]

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +2 -0
+		SAFE_FILE_PRINTF(page_fault_path, "1");
+	}

The old shell script saved and restored the page fault enable value after the loop. This version writes "1" but never restores it. Unmounting debugfs does not reset kernel tracing state. Please add the page_fault_path to .save_restore or save/restore it manually.

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +0 -0
new file mode 100644

[...]

Quoted 5 lines

+/*\
+ *
+ * Check signal:signal_generate gives 2 more fields: grp res
+ *
+ */

Remove the blank lines before/after the description inside the /*\ block.

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 42

Quoted 1 line
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +1 -0
+	if (file_contains(TRACE_FILE, "grp=") && file_contains(TRACE_FILE, "res="))

The old test used 'grp=[0-9] res=[0-9]' which verified both fields appear on the same line with digit values. This only checks for substrings independently, which is less strict.

Also, there is no .gitignore in the ftrace_test directory. Please add one with entries for ftrace_regression01 and ftrace_regression02.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#5 lore raw

PATCH v3 1/1 Rewrite ftrace_regression tests with new C API

In reply to lufei

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 testcases/kernel/tracing/ftrace_test/Makefile |  3 +-
 .../tracing/ftrace_test/ftrace_regression.h   | 49 +++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 88 +++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -----------------
 .../tracing/ftrace_test/ftrace_regression02.c | 68 ++++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 -------------
 8 files changed, 211 insertions(+), 149 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01	ftrace_regression01.sh
-ftrace_regression02	ftrace_regression02.sh
+ftrace_regression01	ftrace_regression01
+ftrace_regression02	ftrace_regression02
 ftrace-stress-test	ftrace_stress_test.sh 90
 dynamic_debug01		dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/Makefile +2 -1
index e4a913a56..618cce7e1 100644
@@ -2,6 +2,7 @@ top_srcdir              ?= ../../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
-INSTALL_TARGETS         := *.sh ftrace_stress/*
+INSTALL_TARGETS         := *.sh ftrace_stress/* ftrace_regression01 \
+				ftrace_regression02
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +49 -0

49 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +88 -0

88 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +68 -0

68 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh deleted +0 -63

63 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#6 lore raw

Re: [LTP] [PATCH v3] Rewrite ftrace_regression tests with new C API

Hi lufei,

Quoted 7 lines

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

Thanks for the rewrite. Few things should be changed.

testcases/kernel/tracing/ftrace_test/Makefile top_srcdir ?= ../../../.. · line 6

Quoted 8 lines

+++ b/testcases/kernel/tracing/ftrace_test/Makefile

testcases/kernel/tracing/ftrace_test/Makefile +2 -1
@@ -2,6 +2,7 @@ top_srcdir              ?= ../../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
-INSTALL_TARGETS         := *.sh ftrace_stress/*
+INSTALL_TARGETS         := *.sh ftrace_stress/* ftrace_regression01 \
+				ftrace_regression02

It's nice to actually run make install to verify it works:

$ make install
../../../../include/mk/env_post.mk:65: warning: overriding recipe for target '/opt/ltp/testcases/bin/ftrace_regression01'
../../../../include/mk/env_post.mk:64: warning: ignoring old recipe for target '/opt/ltp/testcases/bin/ftrace_regression01'
../../../../include/mk/env_post.mk:65: warning: overriding recipe for target '/opt/ltp/testcases/bin/ftrace_regression02'
../../../../include/mk/env_post.mk:64: warning: ignoring old recipe for target '/opt/ltp/testcases/bin/ftrace_regression02'

=> ftrace_regression01 ftrace_regression02 should not be added (C sources are already included).

...

Quoted 14 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +1 -0
+#endif /* FTRACE_REGRESSION_H */
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +7 -0
new file mode 100644
index 000000000..b76d5bf7e
@@ -0,0 +1,88 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2015 Red Hat Inc.
+ * Copyright (c) 2026 lufei <[email protected]>
+ */
+
+/*\

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 17

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +10 -0
+ * Regression test for panic while using userstacktrace.
+ *
+ * BUG: unable to handle kernel paging request at 00000000417683c0
+ *      IP: [<ffffffff8105c834>] update_curr+0x124/0x1e0
+ *      Thread overran stack, or stack corrupted
+ *      Oops: 0000 [#1] SMP
+ *      last sysfs file: ../system/cpu/cpu15/cache/index2/shared_cpu_map
+ *
+ * The bug was fixed by:
+ *      1dbd195 (tracing: Fix preempt count leak)

Please use longer hash (12 chars).

Quoted 11 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +11 -0
+ */
+
+#include <unistd.h>
+#include <stdio.h>
+#include "ftrace_regression.h"
+
+#define DEBUGFS_DIR "debugfs"
+#define STACK_TRACER_PATH "/proc/sys/kernel/stack_tracer_enabled"
+#define TRACE_OPTIONS DEBUGFS_DIR "/tracing/trace_options"
+#define EXC_PAGE_FAULT DEBUGFS_DIR "/tracing/events/exceptions/page_fault_kernel/enable"
+#define MM_PAGE_FAULT DEBUGFS_DIR "/tracing/events/kmem/mm_kernel_pagefault/enable"

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 38

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +10 -0
+
+#define LOOP 10
+
+static const char *page_fault_path;
+static int page_fault_origin;
+
+static void setup(void)
+{
+	SAFE_MKDIR(DEBUGFS_DIR, 0755);
+	SAFE_MOUNT(NULL, DEBUGFS_DIR, "debugfs", 0, NULL);

Maybe have helpers for mounting/unmounting debugfs in the header?

Quoted 18 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +18 -0
+
+	if (access(EXC_PAGE_FAULT, F_OK) == 0)
+		page_fault_path = EXC_PAGE_FAULT;
+	else if (access(MM_PAGE_FAULT, F_OK) == 0)
+		page_fault_path = MM_PAGE_FAULT;
+	else
+		tst_brk(TCONF, "Page fault event not available");
+
+	SAFE_FILE_SCANF(page_fault_path, "%d", &page_fault_origin);
+}
+
+static void run(void)
+{
+	int i;
+
+	for (i = 0; i < LOOP; i++) {
+		SAFE_FILE_PRINTF(STACK_TRACER_PATH, "1");
+		SAFE_FILE_PRINTF(TRACE_OPTIONS, "userstacktrace");

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 66

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +10 -0
+
+		if (!file_contains(TRACE_OPTIONS, "^userstacktrace"))
+			tst_brk(TBROK, "Failed to set userstacktrace");
+
+		SAFE_FILE_PRINTF(page_fault_path, "1");
+	}
+
+	SAFE_FILE_PRINTF(page_fault_path, "%d", page_fault_origin);
+
+	tst_res(TPASS, "Finished running the test");

Rewrite is not blind converting shell into C, but opportunity to improve the test. Can we, please, have a meaningful message what passed?

Quoted 59 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +22 -0
+}
+
+static void cleanup(void)
+{
+	SAFE_UMOUNT(DEBUGFS_DIR);
+}
+
+static struct tst_test test = {
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.setup = setup,
+	.test_all = run,
+	.cleanup = cleanup,
+	.save_restore = (const struct tst_path_val[]) {
+		{STACK_TRACER_PATH, NULL, TST_SR_TCONF},
+		{}
+	},
+	.tags = (const struct tst_tag[]) {
+		{"linux-git", "1dbd195"},
+		{}
+	},
+};
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +31 -0
new file mode 100644
index 000000000..498db29e5
@@ -0,0 +1,68 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2015 Red Hat Inc.
+ * Copyright (c) 2026 lufei <[email protected]>
+ */
+
+/*\
+ * Check signal:signal_generate gives 2 more fields: grp=[0-9] res=[0-9]
+ */
+
+#include <unistd.h>
+#include <stdio.h>
+#include "ftrace_regression.h"
+
+#define DEBUGFS_DIR "debugfs"
+#define SET_EVENT DEBUGFS_DIR "/tracing/set_event"
+#define TRACING_ON DEBUGFS_DIR "/tracing/tracing_on"
+#define TRACE_FILE DEBUGFS_DIR "/tracing/trace"
+
+#define LOOP 100
+
+static void setup(void)
+{
+	SAFE_MKDIR(DEBUGFS_DIR, 0755);
+	SAFE_MOUNT(NULL, DEBUGFS_DIR, "debugfs", 0, NULL);
+}
+
+static void run(void)
+{
+	int i;
+

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 41

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +9 -0
+	SAFE_FILE_PRINTF(SET_EVENT, "signal:signal_generate");
+	SAFE_FILE_PRINTF(TRACING_ON, "1");
+	SAFE_FILE_PRINTF(TRACE_FILE, "\n");
+
+	for (i = 0; i < LOOP; i++)
+		tst_cmd((const char *[]){"ls", "-l", "/proc", NULL},
+			"/dev/null", "/dev/null", 0);
 
+	if (file_contains(TRACE_FILE, "grp=[0-9]") && file_contains(TRACE_FILE, "res=[0-9]"))
+		tst_res(TPASS, "Finished running the test");

Also here, please, better tpass message.

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +10 -0
+	else
+		tst_res(TFAIL, "Pattern grp=[0-9] res=[0-9] not found in trace");
+}
+
+static void cleanup(void)
+{
+	SAFE_UMOUNT(DEBUGFS_DIR);
+}
+
+static struct tst_test test = {

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 61

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +10 -0
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.setup = setup,
+	.test_all = run,
+	.cleanup = cleanup,
+	.needs_cmds = (struct tst_cmd[]) {
+		{.cmd = "ls"},
+		{}
+	},
+	.min_kver = "3.2",

We now support kernel >= 4.4, this should be removed.
https://linux-test-project.readthedocs.io/en/latest/users/supported_systems.html#kernel-version

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 64

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +3 -0
+	.tags = (const struct tst_tag[]) {
+		{"linux-git", "6c303d3"},
+		{"linux-git", "163566f"},

And longer hash.

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +3 -0
+		{}
+	},
+};
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#7 lore raw

Re: [LTP] [PATCH v3] Rewrite ftrace_regression tests with new C API

In reply to lufei

Hi all,
...

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +0 -0

...

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 38

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +3 -0
+	for (i = 0; i < LOOP; i++)
+		tst_cmd((const char *[]){"ls", "-l", "/proc", NULL},
+			"/dev/null", "/dev/null", 0);

It should probably be SAFE_CMD().

@Cyril are we ok with 'ls' as external dependency, or do we want to have test to have simple binary helper run as child to not depend on userspace?

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#8 lore raw

Re: [LTP] [PATCH v3] Rewrite ftrace_regression tests with new C API

Hi!

Quoted 7 lines

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 38

Quoted 3 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +3 -0
+	for (i = 0; i < LOOP; i++)
+		tst_cmd((const char *[]){"ls", "-l", "/proc", NULL},
+			"/dev/null", "/dev/null", 0);

It should probably be SAFE_CMD().

@Cyril are we ok with 'ls' as external dependency, or do we want to have test to have simple binary helper run as child to not depend on userspace?

Hmm, I guess that even tooling such as rapido[1] have ls in the initrd so I guess that ls is just going to be there.

[1] https://github.com/rapido-linux/rapido

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#9 lore raw

PATCH v4 1/1 Rewrite ftrace_regression tests with new C API

In reply to lufei

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 .../tracing/ftrace_test/ftrace_regression.h   | 61 ++++++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 82 ++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -------------------
 .../tracing/ftrace_test/ftrace_regression02.c | 56 +++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 --------------
 7 files changed, 203 insertions(+), 148 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01	ftrace_regression01.sh
-ftrace_regression02	ftrace_regression02.sh
+ftrace_regression01	ftrace_regression01
+ftrace_regression02	ftrace_regression02
 ftrace-stress-test	ftrace_stress_test.sh 90
 dynamic_debug01		dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +61 -0

61 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +82 -0

82 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +56 -0

56 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh deleted +0 -63

63 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#10 lore raw

PATCH v5 1/1 Rewrite ftrace_regression tests with new C API

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 .../tracing/ftrace_test/ftrace_regression.h   | 62 ++++++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 82 ++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -------------------
 .../tracing/ftrace_test/ftrace_regression02.c | 56 +++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 --------------
 7 files changed, 204 insertions(+), 148 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01	ftrace_regression01.sh
-ftrace_regression02	ftrace_regression02.sh
+ftrace_regression01	ftrace_regression01
+ftrace_regression02	ftrace_regression02
 ftrace-stress-test	ftrace_stress_test.sh 90
 dynamic_debug01		dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +62 -0

62 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +82 -0

82 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +56 -0

56 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh deleted +0 -63

63 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#11 lore raw

Re: [LTP] Rewrite ftrace_regression tests with new C API

Hi lufei,

Quoted 4 lines · lufei

[PATCH] Rewrite ftrace_regression tests with new C API

+++ b/testcases/kernel/tracing/ftrace_test/ftrace_regression.h +/* SPDX-License-Identifier: GPL-2.0-or-later

SPDX must use the single-line style: // SPDX-License-Identifier: GPL-2.0-or-later

Quoted 2 lines

+ create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
+ create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c

This adds two new test cases in a single commit. Please split into one commit per test; ftrace_regression.h can go with the first.

[...]

---
Note:

Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v5 1/1
#12 lore raw

Re: [LTP] [PATCH v5] Rewrite ftrace_regression tests with new C API

In reply to lufei

Hi Lufei,

Thanks for the refactoring, see comment inline below:

Quoted 176 lines · lufei

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 .../tracing/ftrace_test/ftrace_regression.h   | 62 ++++++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 82 ++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -------------------
 .../tracing/ftrace_test/ftrace_regression02.c | 56 +++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 --------------
 7 files changed, 204 insertions(+), 148 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01    ftrace_regression01.sh
-ftrace_regression02    ftrace_regression02.sh
+ftrace_regression01    ftrace_regression01
+ftrace_regression02    ftrace_regression02
 ftrace-stress-test     ftrace_stress_test.sh 90
 dynamic_debug01                dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +62 -0
new file mode 100644
index 000000000..ab18e3768
@@ -0,0 +1,62 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * Copyright (c) 2026 lufei <[email protected]>
+ *
+ * Shared header for ftrace regression tests.
+ */
+
+#ifndef FTRACE_REGRESSION_H
+#define FTRACE_REGRESSION_H
+
+#include "tst_test.h"
+#include "tst_safe_file_ops.h"
+#include "tst_safe_stdio.h"
+
+#include <regex.h>
+#include <stdio.h>
+
+#define FTRACE_LINE_BUF_SIZE 1024
+#define DEBUGFS_DIR "debugfs"
+
+/**
+ * file_contains - Check if a file contains specific regex pattern.
+ */
+static inline int file_contains(const char *path, const char *pattern)
+{
+       FILE *fp = SAFE_FOPEN(path, "r");
+       char *buf = SAFE_MALLOC(FTRACE_LINE_BUF_SIZE);
+       bool found = false;
+
+       regex_t re;
+
+       if (regcomp(&re, pattern, REG_EXTENDED | REG_NOSUB) != 0) {
+               SAFE_FCLOSE(fp);
+               free(buf);
+               return found;
+       }
+
+       while (fgets(buf, FTRACE_LINE_BUF_SIZE, fp)) {
+               if (regexec(&re, buf, 0, NULL, 0) == 0) {
+                       found = true;
+                       break;
+               }
+       }
+
+       regfree(&re);
+       SAFE_FCLOSE(fp);
+       free(buf);
+       return found;
+}
+
+static inline void mount_debugfs(void)
+{
+       SAFE_MKDIR(DEBUGFS_DIR, 0755);
+       SAFE_MOUNT(NULL, DEBUGFS_DIR, "debugfs", 0, NULL);
+}
+
+static inline void umount_debugfs(void)
+{
+       SAFE_UMOUNT(DEBUGFS_DIR);
+}
+
+#endif /* FTRACE_REGRESSION_H */
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +55 -0
new file mode 100644
index 000000000..be2327582
@@ -0,0 +1,82 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2015 Red Hat Inc.
+ * Copyright (c) 2026 lufei <[email protected]>
+ */
+
+/*\
+ * Regression test for panic while using userstacktrace.
+ *
+ * BUG: unable to handle kernel paging request at 00000000417683c0
+ *      IP: [<ffffffff8105c834>] update_curr+0x124/0x1e0
+ *      Thread overran stack, or stack corrupted
+ *      Oops: 0000 [#1] SMP
+ *      last sysfs file: ../system/cpu/cpu15/cache/index2/shared_cpu_map
+ *
+ * The bug was fixed by:
+ *      1dbd195 (tracing: Fix preempt count leak)
+ */
+
+#include <unistd.h>
+#include "ftrace_regression.h"
+
+#define STACK_TRACER_PATH "/proc/sys/kernel/stack_tracer_enabled"
+#define TRACE_OPTIONS DEBUGFS_DIR "/tracing/trace_options"
+#define EXC_PAGE_FAULT DEBUGFS_DIR "/tracing/events/exceptions/page_fault_kernel/enable"
+#define MM_PAGE_FAULT DEBUGFS_DIR "/tracing/events/kmem/mm_kernel_pagefault/enable"
+
+#define LOOP 10
+
+static const char *page_fault_path;
+static int page_fault_origin;
+
+static void setup(void)
+{
+       mount_debugfs();
+
+       if (access(EXC_PAGE_FAULT, F_OK) == 0)
+               page_fault_path = EXC_PAGE_FAULT;
+       else if (access(MM_PAGE_FAULT, F_OK) == 0)
+               page_fault_path = MM_PAGE_FAULT;
+       else
+               tst_brk(TCONF, "Page fault event not available");
+
+       SAFE_FILE_SCANF(page_fault_path, "%d", &page_fault_origin);
+}
+
+static void run(void)
+{
+       int i;
+
+       for (i = 0; i < LOOP; i++) {
+               SAFE_FILE_PRINTF(STACK_TRACER_PATH, "1");
+               SAFE_FILE_PRINTF(TRACE_OPTIONS, "userstacktrace");
+
+               if (!file_contains(TRACE_OPTIONS, "^userstacktrace"))

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 65

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +10 -0
+                       tst_brk(TBROK, "Failed to set userstacktrace");
+
+               SAFE_FILE_PRINTF(page_fault_path, "1");
+       }
+
+       SAFE_FILE_PRINTF(page_fault_path, "%d", page_fault_origin);
+
+       tst_res(TPASS, "Test passed for setting userstacktrace "
+                       "bug(preempt count leak) not reproduced"
+                       );

No need put the ")" in a new line.

tst_res(TPASS, "Test passed for setting userstacktrace "

-                       "bug(preempt count leak) not reproduced"
-                       );
+                       "bug(preempt count leak) not reproduced");
Quoted 124 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +17 -0
+}
+
+static struct tst_test test = {
+       .needs_root = 1,
+       .needs_tmpdir = 1,
+       .setup = setup,
+       .test_all = run,
+       .cleanup = umount_debugfs,
+       .save_restore = (const struct tst_path_val[]) {
+               {STACK_TRACER_PATH, NULL, TST_SR_TCONF},
+               {}
+       },
+       .tags = (const struct tst_tag[]) {
+               {"linux-git", "1dbd1951f39e"},
+               {}
+       },
+};
testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83
deleted file mode 100755
index d6969cfc6..000000000
@@ -1,83 +0,0 @@
-#! /bin/sh
-
-###########################################################################
-##                                                                       ##
-## Copyright (c) 2015, Red Hat Inc.                                      ##
-##                                                                       ##
-## This program is free software: you can redistribute it and/or modify  ##
-## it under the terms of the GNU General Public License as published by  ##
-## the Free Software Foundation, either version 3 of the License, or     ##
-## (at your option) any later version.                                   ##
-##                                                                       ##
-## This program is distributed in the hope that it will be useful,       ##
-## but WITHOUT ANY WARRANTY; without even the implied warranty of        ##
-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the          ##
-## GNU General Public License for more details.                          ##
-##                                                                       ##
-## You should have received a copy of the GNU General Public License     ##
-## along with this program. If not, see <http://www.gnu.org/licenses/>.  ##
-##                                                                       ##
-## Author: Li Wang <[email protected]>                                   ##
-##                                                                       ##
-###########################################################################
-##                                                                       ##
-## Summary:  panic while using userstacktrace                            ##
-##                                                                       ##
-## BUG: unable to handle kernel paging request at 00000000417683c0       ##
-##      IP: [<ffffffff8105c834>] update_curr+0x124/0x1e0                 ##
-##      PGD 41a796067 PUD 0                                              ##
-##      Thread overran stack, or stack corrupted                         ##
-##      Oops: 0000 [#1] SMP                                              ##
-##      last sysfs file: ../system/cpu/cpu15/cache/index2/shared_cpu_map ##
-##                                                                       ##
-## The bug was fixed by:                                                 ##
-##      1dbd195 (tracing: Fix preempt count leak)                        ##
-##                                                                       ##
-###########################################################################
-
-export TCID="ftrace_regression01"
-export TST_TOTAL=1
-
-. ftrace_lib.sh
-
-LOOP=10
-
-TSTACK_TRACE_PATH="/proc/sys/kernel/stack_tracer_enabled"
-EXC_PAGE_FAULT_ENABLE="$TRACING_PATH/events/exceptions/page_fault_kernel/enable"
-MM_PAGE_FAULT_ENABLE="$TRACING_PATH/events/kmem/mm_kernel_pagefault/enable"
-
-ftrace_userstacktrace_test()
-{
-       if [ ! -e "$TSTACK_TRACE_PATH" ]; then
-               tst_brkm TCONF "Stack Tracer is not cofigured in This kernel"
-       fi
-
-       for i in $(seq $LOOP); do
-               echo 1 >  $TSTACK_TRACE_PATH
-               echo userstacktrace > $TRACING_PATH/trace_options
-               grep -q "^userstacktrace"  $TRACING_PATH/trace_options
-               if [ $? -ne 0 ]; then
-                       tst_brkm TBROK "Failed to set userstacktrace"
-               fi
-
-               if [ -f "$EXC_PAGE_FAULT_ENABLE" ]; then
-                       exc_page_fault_enable=`cat $EXC_PAGE_FAULT_ENABLE`
-                       echo 1 > $EXC_PAGE_FAULT_ENABLE
-               else
-                       mm_page_fault_enable=`cat $MM_PAGE_FAULT_ENABLE`
-                       echo 1 > $MM_PAGE_FAULT_ENABLE
-               fi
-       done
-
-       if [ -f "$EXC_PAGE_FAULT_ENABLE" ]; then
-               echo "$exc_page_fault_enable" > $EXC_PAGE_FAULT_ENABLE
-       else
-               echo "$mm_page_fault_enable" > $MM_PAGE_FAULT_ENABLE
-       fi
-
-       tst_resm TPASS "Finished running the test"
-}
-
-ftrace_userstacktrace_test
-
-tst_exit
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +12 -0
new file mode 100644
index 000000000..b4aac7ad0
@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2015 Red Hat Inc.
+ * Copyright (c) 2026 lufei <[email protected]>
+ */
+
+/*\
+ * Check signal:signal_generate gives 2 more fields: grp=[0-9] res=[0-9]
+ */
+
+#include "ftrace_regression.h"
+

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 22

Quoted 10 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +10 -0
+#define SET_EVENT DEBUGFS_DIR "/tracing/set_event"
+#define TRACING_ON DEBUGFS_DIR "/tracing/tracing_on"
+#define TRACE_FILE DEBUGFS_DIR "/tracing/trace"
+
+#define LOOP 100
+
+static void run(void)
+{
+       int i;
+       const char *const cmd_ls[] = {"ls", "-l", "/proc", NULL};

Here I'd suggest using a stable directory for listing, since in /proc there are many pid DIRs that temporarily exist, so it easy to hit race condition in testing.

    const char *const cmd_ls[] = {"ls", "-l", "/sys/kernel/tracing/", NULL};

In my strace output:

[pid 4696] 1777276263.339591 (+ 0.000048) statx(AT_FDCWD, "/proc/4677", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, 0x7ffc8cdef8f0) = -1 ENOENT (No such file or directory) <0.000016>
...
ftrace_regression02.c:30: TBROK: ls failed (1)

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 28

Quoted 6 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +6 -0
+
+       SAFE_FILE_PRINTF(SET_EVENT, "signal:signal_generate");
+       SAFE_FILE_PRINTF(TRACING_ON, "1");
+       SAFE_FILE_PRINTF(TRACE_FILE, "\n");
+
+       // to generate trace

Please use /* */ in LTP code comments.

Otherwise looks good to me:

--
Regards,
Li Wang

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#13 lore raw

Re: [LTP] [PATCH v5] Rewrite ftrace_regression tests with new C API

Hi!

Review

Quoted 12 lines

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 65

Quoted 5 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +5 -0
+       SAFE_FILE_PRINTF(page_fault_path, "%d", page_fault_origin);
+
+       tst_res(TPASS, "Test passed for setting userstacktrace "
+                       "bug(preempt count leak) not reproduced"
+                       );

No need put the ")" in a new line.

tst_res(TPASS, "Test passed for setting userstacktrace "

(quoted diff) +1 -2
-                       "bug(preempt count leak) not reproduced"
-                       );
+                       "bug(preempt count leak) not reproduced");

Or even better, keep the message short and to the point with just:

	tst_res(TPASS, "Preempt count leak bug not reproduced");
Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#14 lore raw

PATCH v6 1/1 Rewrite ftrace_regression tests with new C API

In reply to lufei

Rewritten from old shell scripts.

ftrace_regression01: regression test for panic bug while using userstacktrace, set userstacktrace in loop and check if success.

ftrace_regression02: for checking signal:signal_generate gives 2 more fields: grp res.

---
 runtest/tracing                               |  4 +-
 .../kernel/tracing/ftrace_test/.gitignore     |  2 +
 .../tracing/ftrace_test/ftrace_regression.h   | 62 ++++++++++++++
 .../tracing/ftrace_test/ftrace_regression01.c | 80 ++++++++++++++++++
 .../ftrace_test/ftrace_regression01.sh        | 83 -------------------
 .../tracing/ftrace_test/ftrace_regression02.c | 56 +++++++++++++
 .../ftrace_test/ftrace_regression02.sh        | 63 --------------
 7 files changed, 202 insertions(+), 148 deletions(-)
 create mode 100644 testcases/kernel/tracing/ftrace_test/.gitignore
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression.h
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression01.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh
 create mode 100644 testcases/kernel/tracing/ftrace_test/ftrace_regression02.c
 delete mode 100755 testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh
runtest/tracing +2 -2
index 674e2ad97..2a4a92c5f 100644
@@ -1,6 +1,6 @@
 #DESCRIPTION:Tracing testing
-ftrace_regression01	ftrace_regression01.sh
-ftrace_regression02	ftrace_regression02.sh
+ftrace_regression01	ftrace_regression01
+ftrace_regression02	ftrace_regression02
 ftrace-stress-test	ftrace_stress_test.sh 90
 dynamic_debug01		dynamic_debug01.sh
 fanotify25 fanotify25
testcases/kernel/tracing/ftrace_test/.gitignore new file +2 -0
new file mode 100644
index 000000000..b0153e9fa
@@ -0,0 +1,2 @@
+ftrace_regression01
+ftrace_regression02
testcases/kernel/tracing/ftrace_test/ftrace_regression.h new file +62 -0

62 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +80 -0

80 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression01.sh deleted +0 -83

83 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +56 -0

56 lines not on this page · raw message

testcases/kernel/tracing/ftrace_test/ftrace_regression02.sh deleted +0 -63

63 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#15 lore raw

Re: [LTP] Rewrite ftrace_regression tests with new C API

Hi lufei,

Quoted 3 lines · lufei

Rewrite ftrace_regression tests with new C API

Rewritten from old shell scripts.

Please explain why the conversion is being done — "Rewritten from old shell scripts" only states what, not why. Also, this bundles two independent test rewrites; please split into one commit per test.

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 53

Quoted 7 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +7 -0
+static void run(void)
+{
+	int i;
+
+	for (i = 0; i < LOOP; i++) {
+		SAFE_FILE_PRINTF(STACK_TRACER_PATH, "1");
+		SAFE_FILE_PRINTF(TRACE_OPTIONS, "userstacktrace");

trace_options is modified but never saved/restored. The original ftrace_lib.sh saved old_trace_options and restored it in restore_old_setting(). Add TRACE_OPTIONS to .save_restore.

testcases/kernel/tracing/ftrace_test/ftrace_regression01.c line 61

Quoted 1 line
testcases/kernel/tracing/ftrace_test/ftrace_regression01.c new file +1 -0
+	SAFE_FILE_PRINTF(page_fault_path, "%d", page_fault_origin);

This restore only runs on the normal path. If run() aborts via tst_brk() inside the loop the enable flag is left set. Use .save_restore or a dedicated cleanup() instead.

[...]

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 22

Quoted 4 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +4 -0
+static void run(void)
+{
+	int i;
+	const char *const cmd_ls[] = {"ls", "-l", "/sys/kernel/tracing/", NULL};

/sys/kernel/tracing/ is not guaranteed to exist on all configs. The original used /proc; keep that or add an access() check with TCONF.

testcases/kernel/tracing/ftrace_test/ftrace_regression02.c line 25

Quoted 2 lines
testcases/kernel/tracing/ftrace_test/ftrace_regression02.c new file +2 -0
+	SAFE_FILE_PRINTF(SET_EVENT, "signal:signal_generate");
+	SAFE_FILE_PRINTF(TRACING_ON, "1");

Neither SET_EVENT nor TRACING_ON is restored. Add both to .save_restore.

---
Pre-existing issues noticed in the surrounding code (not introduced by this patch):

- ftrace_lib.sh:109 — typo "function_pofile_enabled" (should be "function_profile_enabled") prevents restoring profile state

---
Note:

Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp