Skip to contentSkip to conversation

tests/kms_properties: Add skip on headless machines

PATCH Superseded sumit kishore 3 participants 3 messages Mar 5

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_properties: Add skip on headless machines

Print debug messages for sub-tests which are expected to skip on headless display systems.

---
 tests/kms_properties.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
tests/kms_properties.c +17 -0
index 86d05c6d4..01f0d5867 100644
@@ -73,6 +73,19 @@ struct additional_test {
 			  uint32_t prop_id, uint64_t prop_value, bool atomic);
 };
 
+static void is_headless_display(igt_display_t *display)
+{
+	igt_output_t *output;
+	bool display_connected = false;
+
+	for_each_connected_output(display, output) {
+		display_connected = true;
+		break;
+	}
+
+	igt_skip_on_f(!display_connected, "No active display connected, skipping sub-test\n");
+}
+
 static void prepare_pipe(igt_display_t *display, igt_crtc_t *crtc,
 			 igt_output_t *output, struct igt_fb *fb)
 {
@@ -377,6 +390,8 @@ static void plane_properties(igt_display_t *display, bool atomic)
 	igt_output_t *output;
 	igt_crtc_t *crtc;
 
+	is_headless_display(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
 
@@ -400,6 +415,8 @@ static void crtc_properties(igt_display_t *display, bool atomic)
 	igt_crtc_t *crtc;
 	igt_output_t *output;
 
+	is_headless_display(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
 
Signature · 1 line
2.43.0
#1 lore raw

Hi Sumit,

Quoted 10 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of sumit kishore
Sent: Thursday, March 5, 2026 12:53 PM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>; Kishore, Sumit <[email protected]>
Subject: [PATCH i-g-t v1] tests/kms_properties: Add skip on headless machines

Quoted 4 lines

Print debug messages for sub-tests which are expected to skip on headless display systems.

*Sumit
*Kishore

Quoted 11 lines
---
 tests/kms_properties.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
tests/kms_properties.c index renamed from tests/kms_properties.c +0 -0

86d05c6d4..01f0d5867 100644

tests/kms_properties.c +0 -0
@@ -73,6 +73,19 @@ struct additional_test {
 			  uint32_t prop_id, uint64_t prop_value, bool
 atomic);  };

tests/kms_properties.c struct additional_test { · line 84

Quoted 10 lines
tests/kms_properties.c +9 -0
 
+static void is_headless_display(igt_display_t *display) {
+	igt_output_t *output;
+	bool display_connected = false;
+
+	for_each_connected_output(display, output) {
+		display_connected = true;
+		break;
+	}
+

The same review comments mentioned for the below patch apply here as well.
https://patchwork.freedesktop.org/patch/708585/?series=162500&rev=1

Regards,
Pranay

Quoted 26 lines
tests/kms_properties.c +4 -0
+	igt_skip_on_f(!display_connected, "No active display connected,
+skipping sub-test\n"); }
+
 static void prepare_pipe(igt_display_t *display, igt_crtc_t *crtc,
 			 igt_output_t *output, struct igt_fb *fb)  { @@ -377,6
+390,8 @@ static void plane_properties(igt_display_t *display, bool atomic)
 	igt_output_t *output;
tests/kms_properties.c +4 -1
 	igt_crtc_t *crtc;
 
+	is_headless_display(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
@@ -400,6 +415,8 @@ static void crtc_properties(igt_display_t *display, bool
 atomic)
 	igt_crtc_t *crtc;
 	igt_output_t *output;
 
+	is_headless_display(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
 
--

2.43.0

#2 lore raw

✗ Fi.CI.BUILD: failure for tests/kms_properties: Add skip on headless machines

In reply to sumit kishore
== Series Details ==

== Series Details ==

Series: tests/kms_properties: Add skip on headless machines
URL : https://patchwork.freedesktop.org/series/162630/
State : failure

== Summary ==

Applying: tests/kms_properties: Add skip on headless machines Using index info to reconstruct a base tree...
M tests/kms_properties.c
Falling back to patching base and 3-way merge... Auto-merging tests/kms_properties.c
CONFLICT (content): Merge conflict in tests/kms_properties.c Patch failed at 0001 tests/kms_properties: Add skip on headless machines When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".