Skip to contentSkip to conversation

KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()

PATCH Applied Zenghui Yu 2 participants 2 messages Mar 6

Subsystems (2)
lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

PATCH 1/1 KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()

From: "Zenghui Yu (Huawei)" <[email protected]>

We already have an ISB in __kvm_at() to make the address translation result visible to subsequent reads of PAR_EL1. Remove the redundant one right after it.

---
 arch/arm64/kvm/at.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/kvm/at.c +0 -2
index 6588ea251ed7..c5c5644b1878 100644
@@ -1504,8 +1504,6 @@ int __kvm_at_s1e2(struct kvm_vcpu *vcpu, u32 op, u64 vaddr)
 			fail = true;
 		}
 
-		isb();
-
 		if (!fail)
 			par = read_sysreg_par();
 
Signature · 1 line
2.53.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Zenghui Yu

We already have an ISB in __kvm_at() to make the address translation result visible to subsequent reads of PAR_EL1. Remove the redundant one right after it.

Applied to fixes, thanks!

[1/1] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()

      commit: 3599c714c08c324f0fcfa392bfb857c92c575400

Cheers,

	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.