media: synopsys: fix link failure against GENERIC_PHY_MIPI_DPHY
PATCH 1/1 media: synopsys: fix link failure against GENERIC_PHY_MIPI_DPHY
From: Arnd Bergmann <[email protected]>
The newly added driver uses the generic mipi dphy driver but is missing a Kconfig dependency:
ld.lld-22: error: undefined symbol: phy_mipi_dphy_get_default_config_for_hsclk
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by dw-mipi-csi2rx.c:240 (
/home/arnd/arm-soc/drivers/media/platform/synopsys/dw-mipi-csi2rx.c:240)
drivers/media/platform/synopsys/dw-mipi-csi2rx.o:(dw_mipi_csi2rx_enable_streams) in archive vmlinux.a
This is in a library module that needs to be selected by each user, so add the missing 'select' here.
--- drivers/media/platform/synopsys/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/media/platform/synopsys/Kconfig +1 -0
@@ -7,6 +7,7 @@ config VIDEO_DW_MIPI_CSI2RX depends on VIDEO_DEV depends on V4L_PLATFORM_DRIVERS depends on PM && COMMON_CLK + select GENERIC_PHY_MIPI_DPHY select MEDIA_CONTROLLER select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API
Signature · 1 line
2.39.5
Hi Arnd,
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The newly added driver uses the generic mipi dphy driver but is missing a
Kconfigdependency:ld.lld-22: error: undefined symbol:
phy_mipi_dphy_get_default_config_for_hsclk
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by dw-mipi-csi2rx.c:240 (
/home/arnd/arm-soc/drivers/media/platform/synopsys/dw-mipi-csi2rx.c:240)
drivers/media/platform/synopsys/dw-mipi-csi2rx.o:(dw_mipi_csi2rx_enable_streams) in archive vmlinux.aThis is in a library module that needs to be selected by each user, so add the missing 'select' here.
Fixes 355a11004066 ("media: synopsys: add driver for the designware mipi csi-2 receiver")Signed-off-by Arnd Bergmann <[email protected]>
Thanks for the patch, but this issue has been addressed here [0] and I think Sakari has applied this series already.
Best regards,
Michael
Quoted 9 lines
--- drivers/media/platform/synopsys/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/media/platform/synopsys/Kconfig +0
-0
drivers/media/platform/synopsys/Kconfig config VIDEO_DW_MIPI_CSI2RX · line 13
Quoted 7 lines
drivers/media/platform/synopsys/Kconfig +1
-0@@ -7,6 +7,7 @@ config VIDEO_DW_MIPI_CSI2RX depends on VIDEO_DEV depends on V4L_PLATFORM_DRIVERS depends on PM && COMMON_CLK + select GENERIC_PHY_MIPI_DPHY select MEDIA_CONTROLLER select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API