Skip to contentSkip to conversation

staging: media: atomisp: i2c: replace msleep() with usleep_range()

PATCH In review Mark Adamenko 2 participants 2 messages Mar 7 – Mar 10

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: i2c: replace msleep() with usleep_range()

checkpatch.pl flags a warning for msleep() being called for 5 milliseconds. Replace the msleep() call with usleep_range(), as is already done in the same function.

---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1 -1
index d3414312e1de..db5e007efc56 100644
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
 			goto fail_power;
 	}
 
-	msleep(5);
+	usleep_range(5000, 6000);
 	return 0;
 
 fail_clk:
Signature · 1 line
2.53.0
#1 lore raw

Hi Mark,

This is a patch to the (atomisp-)gc2235 driver, not to atomisp itself.

Quoted 14 lines · Mark Adamenko

checkpatch.pl flags a warning for msleep() being called for 5 milliseconds. Replace the msleep() call with usleep_range(), as is already done in the same function.

---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +0 -0
index d3414312e1de..db5e007efc56 100644

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c static int power_up(struct v4l2_subdev *sd) · line 436

Quoted 5 lines
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1 -1
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
 			goto fail_power;
 	}
 
-	msleep(5);
+	usleep_range(5000, 6000);

I'd use fsleep() here.

Quoted 3 lines
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +0 -0
 	return 0;
 
 fail_clk:
Signature · 3 lines
Regards,

Sakari Ailus