Skip to contentSkip to conversation

i2c: tegra: enable compile testing on all archs

PATCH Applied Johan Hovold 2 participants 3 messages Mar 9 – Mar 30 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: tegra: enable compile testing on all archs

Commit 4a2d5f663dab ("i2c: Enable compile testing for more drivers") enabled compile testing of the Tegra i2c driver only for architectures that explicitly provide readsX() and writesX().

This limitation appears to have been too restrictive since the generic implementation of these primitives added by commit 9ab3a7a0d2b4 ("asm-generic/io.h: Implement generic {read,write}s*()") predates the commit in question.

Allow compile testing of the driver on all architectures.

Cc Krzysztof Kozlowski <[email protected]>
---
 drivers/i2c/busses/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/Kconfig +1 -2
index e11d50750e63..33b06fa70f91 100644
@@ -1211,8 +1211,7 @@ config I2C_SYNQUACER
 
 config I2C_TEGRA
 	tristate "NVIDIA Tegra internal I2C controller"
-	depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
-	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
+	depends on ARCH_TEGRA || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  I2C controller embedded in NVIDIA Tegra SOCs
Signature · 1 line
2.52.0
#1 lore raw
Quoted 9 lines · Johan Hovold

Commit 4a2d5f663dab ("i2c: Enable compile testing for more drivers") enabled compile testing of the Tegra i2c driver only for architectures that explicitly provide readsX() and writesX().

This limitation appears to have been too restrictive since the generic implementation of these primitives added by commit 9ab3a7a0d2b4 ("asm-generic/io.h: Implement generic {read,write}s*()") predates the commit in question.

Quoted 5 lines

Allow compile testing of the driver on all architectures.

Cc Krzysztof Kozlowski <[email protected]>

---

Can this one be picked up for 7.1?

Johan

Applied
#2 lore raw
In reply to Johan Hovold
Quoted 9 lines · Johan Hovold

Commit 4a2d5f663dab ("i2c: Enable compile testing for more drivers") enabled compile testing of the Tegra i2c driver only for architectures that explicitly provide readsX() and writesX().

This limitation appears to have been too restrictive since the generic implementation of these primitives added by commit 9ab3a7a0d2b4 ("asm-generic/io.h: Implement generic {read,write}s*()") predates the commit in question.

Quoted 4 lines

Allow compile testing of the driver on all architectures.

Cc Krzysztof Kozlowski <[email protected]>

I wanted to give Krzysztof the opportunity to ack, but I can pick it up now.

Applied to for-next, thanks!