parisc: Fix cacheflush() syscall to flush correct cache
PATCH 1/1 parisc: Fix cacheflush() syscall to flush correct cache
From: Helge Deller <[email protected]>
Somehow the assembly flush instruction was swapped for I- and D-cache flags in the cacheflush() syscall:SYSCALL_DEFINE3(cacheflush, ...)
{
if (cache & DCACHE) {
"fic ...\n"
}
if (cache & ICACHE && error == 0) {
"fdc ...\n"
}Fix it by using fdc for DCACHE, and fic for ICACHE flushing.
Noticed-by Felix Lechner <[email protected]>
Fixes c6d96328fecd ("parisc: Add cacheflush() syscall")
Signed-off-by Helge Deller <[email protected]>
--- arch/parisc/kernel/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/kernel/cache.c +2 -2
@@ -953,7 +953,7 @@ SYSCALL_DEFINE3(cacheflush, unsigned long, addr, unsigned long, bytes,#else "1: cmpb,<<,n %0,%2,1b\n" #endif -" fic,m %3(%4,%0)\n" +" fdc,m %3(%4,%0)\n" "2: sync\n" ASM_EXCEPTIONTABLE_ENTRY_EFAULT (1b ,2b ,"%1" ) : "+r" (start), "+r" (error)
@@ -968,7 +968,7 @@ SYSCALL_DEFINE3(cacheflush, unsigned long, addr, unsigned long, bytes,#else "1: cmpb,<<,n %0,%2,1b\n" #endif -" fdc,m %3(%4,%0)\n" +" fic,m %3(%4,%0)\n" "2: sync\n" ASM_EXCEPTIONTABLE_ENTRY_EFAULT (1b ,2b ,"%1" ) : "+r" (start), "+r" (error)
Signature · 1 line
2.53.0
When generating generating PA 1.x compatible code, the fic instruction needs a 3-bit s field (i.e., implicit space register selection isn't supported).
Dave
Quoted 44 lines · Helge Deller
From: Helge Deller <[email protected]>
Somehow the assembly flush instruction was swapped for I- and D-cache flags in the
cacheflush()syscall:SYSCALL_DEFINE3(cacheflush, ...){ if (cache & DCACHE) { "fic ...\n" } if (cache & ICACHE && error == 0) { "fdc ...\n" }Fix it by using fdc for DCACHE, and fic for ICACHE flushing.
Noticed-by Felix Lechner <[email protected]>Fixes c6d96328fecd ("parisc: Add cacheflush() syscall")Signed-off-by Helge Deller <[email protected]>--- arch/parisc/kernel/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/parisc/kernel/cache.c +2
-2@@ -953,7 +953,7 @@ SYSCALL_DEFINE3(cacheflush, unsigned long, addr, unsigned long, bytes,#else "1: cmpb,<<,n %0,%2,1b\n" #endif -" fic,m %3(%4,%0)\n" +" fdc,m %3(%4,%0)\n" "2: sync\n" ASM_EXCEPTIONTABLE_ENTRY_EFAULT (1b ,2b ,"%1" ) : "+r" (start), "+r" (error)@@ -968,7 +968,7 @@ SYSCALL_DEFINE3(cacheflush, unsigned long, addr, unsigned long, bytes,#else "1: cmpb,<<,n %0,%2,1b\n" #endif -" fdc,m %3(%4,%0)\n" +" fic,m %3(%4,%0)\n" "2: sync\n" ASM_EXCEPTIONTABLE_ENTRY_EFAULT (1b ,2b ,"%1" ) : "+r" (start), "+r" (error)
Signature · 1 line
John David Anglin [email protected]