Skip to contentSkip to conversation

arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace

PATCH Applied Chris Morgan 2 participants 2 messages Mar 10 – Mar 12

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Chris Morgan

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace

From: Chris Morgan <[email protected]>

The Gameforce Ace's joystick axes were set incorrectly initially, getting the X/Y and RX/RY axes backwards. Additionally, correct the RY axis so that it is inverted.

All axes tested with evtest and outputting correct values.

Fixes 4e946c447a04 ("arm64: dts: rockchip: Add GameForce Ace")
Reported-by sydarn <[email protected]>
Signed-off-by Chris Morgan <[email protected]>
---
 arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts +5 -5
index e8ad525ba3f9..b69d7aa0b2f1 100644
@@ -60,8 +60,8 @@ axis@0 {
 			reg = <0>;
 			abs-flat = <40>;
 			abs-fuzz = <30>;
-			abs-range = <0 4095>;
-			linux,code = <ABS_RX>;
+			abs-range = <4095 0>;
+			linux,code = <ABS_RY>;
 		};
 
 		axis@1 {

@@ -69,7 +69,7 @@ axis@1 {
 			abs-flat = <40>;
 			abs-fuzz = <30>;
 			abs-range = <0 4095>;
-			linux,code = <ABS_RY>;
+			linux,code = <ABS_RX>;
 		};
 
 		axis@2 {

@@ -77,7 +77,7 @@ axis@2 {
 			abs-flat = <40>;
 			abs-fuzz = <30>;
 			abs-range = <0 4095>;
-			linux,code = <ABS_Y>;
+			linux,code = <ABS_X>;
 		};
 
 		axis@3 {

@@ -85,7 +85,7 @@ axis@3 {
 			abs-flat = <40>;
 			abs-fuzz = <30>;
 			abs-range = <0 4095>;
-			linux,code = <ABS_X>;
+			linux,code = <ABS_Y>;
 		};
 	};
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 8 lines · Chris Morgan

The Gameforce Ace's joystick axes were set incorrectly initially, getting the X/Y and RX/RY axes backwards. Additionally, correct the RY axis so that it is inverted.

All axes tested with evtest and outputting correct values.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace

      commit: 2ed11ad1c2b4c191cb2ed6741be127eb99f8634f

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>