Skip to contentSkip to conversation

Add hugemmap37, migrated task-size-overrun.c from libhugetlbfs v3

PATCH In review Pavithra 2 participants 2 messages Mar 11 – Mar 27

lore
Share & tools
lore

Pavithra

author
#0 lore raw

PATCH 1/1 Add hugemmap37, migrated task-size-overrun.c from libhugetlbfs v3

Changes in v3:
- Modified code to use LTP_ALIGN() macro.
- Modified code to take last line from /proc/self/maps that is not [vsyscall]
- Changed logic to calculate high
- Removed assert

---
 runtest/hugetlb                               |   1 +
 testcases/kernel/mem/.gitignore               |   1 +
 .../kernel/mem/hugetlb/hugemmap/hugemmap37.c  | 158 ++++++++++++++++++
 3 files changed, 160 insertions(+)
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c
runtest/hugetlb +1 -0
index 0896d3c94..8aaafeee3 100644
@@ -36,6 +36,7 @@ hugemmap30 hugemmap30
 hugemmap31 hugemmap31
 hugemmap32 hugemmap32
 hugemmap34 hugemmap34
+hugemmap37 hugemmap37
 hugemmap05_1 hugemmap05 -m
 hugemmap05_2 hugemmap05 -s
 hugemmap05_3 hugemmap05 -s -m
testcases/kernel/mem/.gitignore +1 -0
index b4455de51..38d428fe8 100644
@@ -36,6 +36,7 @@
 /hugetlb/hugemmap/hugemmap31
 /hugetlb/hugemmap/hugemmap32
 /hugetlb/hugemmap/hugemmap34
+/hugetlb/hugemmap/hugemmap37
 /hugetlb/hugeshmat/hugeshmat01
 /hugetlb/hugeshmat/hugeshmat02
 /hugetlb/hugeshmat/hugeshmat03
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +158 -0

158 lines not on this page · raw message

Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Pavithra,

The commit message body describes "Changes in v3" but doesn't explain why this test is being migrated. The v3 changelog belongs below the --- line; the body should describe what the test does and why it's useful.

Quoted 3 lines

+/*
+ * Copyright (C) 2005-2006 David Gibson & Adam Litke, IBM Corporation.
+ */

This is a new file, so it needs a copyright line with the current year and your name, e.g.:
Copyright (c) 2026 Pavithra <[email protected]>

Quoted 2 lines

+/*\
+ *[Descripiton]

Typo ("Descripiton"), and [Description] is deprecated — remove the tag entirely. The doc text alone is sufficient.

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 30

Quoted 2 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +2 -0
+#define MAPS_BUF_SZ 4096
+#define _LARGEFILE64_SOURCE

_LARGEFILE64_SOURCE must be defined before any includes to take effect. It also appears unused here — drop it.

Quoted 1 line

+static int fd;

Must be initialized to -1. Zero is a valid fd (stdin).

Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1 -0
+	tst_res(TINFO, "Last map: at 0x%lx-0x%lx\n", start, end);

[...]

Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1 -0
+	tst_res(TINFO, "Binary searching for task size PFNs 0x%lx..0x%lx\n", low, high);

[...]

Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1 -0
+		tst_res(TINFO, "Map succeeded at 0x%lx\n", addr);

[...]

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 116

Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1 -0
+	tst_res(TINFO, "TASK_SIZE = 0x%lx\n", task_size);

Drop the trailing \n in all tst_res() calls — the framework adds newlines automatically.

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 126

Quoted 4 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +4 -0
+	p = mmap((void *)straddle_addr, 2*hpage_size, PROT_READ|PROT_WRITE,
+		MAP_SHARED, fd, 0);
+	if (p == (void *)straddle_addr)
+		tst_res(TFAIL, "Apparently suceeded in mapping across TASK_SIZE boundary");

If mmap succeeds at a different address, the mapping is never unmapped (resource leak). Also need to munmap when it does land at straddle_addr after reporting TFAIL. Typo: "suceeded" -> "succeeded".

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 133

Quoted 4 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +4 -0
+	p = mmap((void *)straddle_addr, 2*hpage_size, PROT_READ|PROT_WRITE,
+		MAP_SHARED|MAP_FIXED, fd, 0);
+	if (p != MAP_FAILED)
+		tst_res(TFAIL, "Apparently suceeded in mapping across TASK_SIZE boundary");

Same here — munmap the mapping after TFAIL. Same typo.

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 135

Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1 -0
+	tst_res(TPASS, "Test passed!");

This fires unconditionally, even after TFAIL was reported above. Each sub-case (non-MAP_FIXED and MAP_FIXED) should have its own TPASS/TFAIL pair, so the result is per-case rather than a blanket pass.

testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 148

Quoted 5 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +5 -0
+static void cleanup(void)
+{
+	if (fd > 0)
+		SAFE_CLOSE(fd);
+}

Use "fd != -1", not "fd > 0". The > 0 check silently skips fd 0.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp