Skip to contentSkip to conversation

xfs_io: fix fsmap help

PATCH In review Christoph Hellwig 3 participants 3 messages Mar 11

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_io: fix fsmap help

By default fsmap prints the reverse mapping for all devices. Update the help text to correctly reflect that.

---
 io/fsmap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
io/fsmap.c +3 -2
index 005d32e500a0..0182154fee47 100644
@@ -24,7 +24,8 @@ fsmap_help(void)
 "\n"
 " Prints the block mapping for the filesystem hosting the current file"
 "\n"
-" fsmap prints the map of disk blocks used by the whole filesystem.\n"
+" fsmap prints the map of disk blocks used on a given file system filesystem.\n"
+" By default, the blocks for all devices are printed.\n"
 " When possible, owner and offset information will be included in the\n"
 " space report.\n"
 "\n"
@@ -32,7 +33,7 @@ fsmap_help(void)
 "     extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
 " The owner field is either an inode number or a special value.\n"
 " All the file offsets and disk blocks are in units of 512-byte blocks.\n"
-" -d -- query only the data device (default).\n"
+" -d -- query only the data device.\n"
 " -l -- query only the log device.\n"
 " -r -- query only the realtime device.\n"
 " -n -- query n extents at a time.\n"
Signature · 1 line
2.47.3
#2 lore raw
In reply to Christoph Hellwig
Quoted 13 lines · Christoph Hellwig

By default fsmap prints the reverse mapping for all devices. Update the help text to correctly reflect that.

---
 io/fsmap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
io/fsmap.c +0 -0
index 005d32e500a0..0182154fee47 100644

io/fsmap.c fsmap_help(void) · line 27

Quoted 5 lines
io/fsmap.c +1 -1
@@ -24,7 +24,8 @@ fsmap_help(void)
 "\n"
 " Prints the block mapping for the filesystem hosting the current file"
 "\n"
-" fsmap prints the map of disk blocks used by the whole filesystem.\n"
+" fsmap prints the map of disk blocks used on a given file system filesystem.\n"
                                               redundant ^^^^^^^^^^^

Otherwise this reads ok to me.

--D

Quoted 17 lines
io/fsmap.c +2 -1
+" By default, the blocks for all devices are printed.\n"
 " When possible, owner and offset information will be included in the\n"
 " space report.\n"
 "\n"
@@ -32,7 +33,7 @@ fsmap_help(void)
 "     extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
 " The owner field is either an inode number or a special value.\n"
 " All the file offsets and disk blocks are in units of 512-byte blocks.\n"
-" -d -- query only the data device (default).\n"
+" -d -- query only the data device.\n"
 " -l -- query only the log device.\n"
 " -r -- query only the realtime device.\n"
 " -n -- query n extents at a time.\n"
Signature · 1 line
2.47.3