shut down devices asynchronously
Subsystems (3)
v11 cover shut down devices asynchronously
This patchset allows the kernel to shutdown devices asynchronously and unrelated async devices to be shut down in parallel to each other.
Only devices which explicitly enable it are shut down asynchronously. The default is for a device to be shut down from the synchronous shutdown loop.
This can dramatically reduce system shutdown/reboot time on systems that have multiple devices that take many seconds to shut down (like certain NVMe drives). On one system tested, the shutdown time went from 11 minutes without this patch to 55 seconds with the patch. And on another system from 80 seconds to 11.
Changes from V10:
Reworked to more closely match the design used for async suspend
* No longer uses async subsystem cookies for synchronization
* Minimized changes to struct device
* Enable async shutdown for pci and scsi devices which support async suspend
Changes from V9:
Address resource and timing issues when spawning a unique async thread for every device during shutdown:
* Make the asynchronous threads able to shut down multiple devices, instead of spawning a unique thread for every device.
* Modify core kernel async code with a custom wake function so it doesn't wake up a thread waiting to synchronize on a cookie until the cookie has reached the desired value, instead of waking up every waiting thread to check the cookie every time an async thread ends.
Changes from V8:
Deal with shutdown hangs resulting when a parent/supplier device is
later in the devices_kset list than its children/consumers:
* Ignore sync_state_only devlinks for shutdown dependencies
* Ignore shutdown_after for devices that don't want async shutdown
* Add a sanity check to revert to sync shutdown for any device that would otherwise wait for a child/consumer shutdown that hasn't already been scheduled
Changes from V7:
Do not expose driver async_shutdown_enable in sysfs. Wrapped a long line.
Changes from V6:
Removed a sysfs attribute that allowed the async device shutdown to be "on" (with driver opt-out), "safe" (driver opt-in), or "off"... what was previously "safe" is now the only behavior, so drivers now only need to have the option to enable or disable async shutdown.
Changes from V5:
Separated into multiple patches to make review easier. Reworked some code to make it more readable
Made devices wait for consumers to shut down, not just children
(suggested by David Jeffery)
Changes from V4:
Change code to use cookies for synchronization rather than async domains Allow async shutdown to be disabled via sysfs, and allow driver opt-in or
opt-out of async shutdown (when not disabled), with ability to control driver opt-in/opt-out via sysfs
Changes from V3:
Bug fix (used "parent" not "dev->parent" in device_shutdown)
Changes from V2:
Removed recursive functions to schedule children to be shutdown before
parents, since existing device_shutdown loop will already do this
Changes from V1:
Rewritten using kernel async code (suggested by Lukas Wunner)
Stuart Hayes (2):
driver core: don't always lock parent in shutdown driver core: separate function to shutdown one device
David Jeffery (3):
driver core: async device shutdown infrastructure
pci: enable async shutdown support
scsi: enable async shutdown support
drivers/base/base.h | 2 + drivers/base/core.c | 165 +++++++++++++++++++++++++++++++------- drivers/pci/probe.c | 1 + drivers/scsi/hosts.c | 3 + drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 4 + include/linux/device.h | 13 +++ 7 files changed, 160 insertions(+), 29 deletions(-)
Signature · 1 line
2.53.0
Quoted 100 lines · David Jeffery
This patchset allows the kernel to shutdown devices asynchronously and unrelated async devices to be shut down in parallel to each other.
Only devices which explicitly enable it are shut down asynchronously. The default is for a device to be shut down from the synchronous shutdown loop.
This can dramatically reduce system shutdown/reboot time on systems that have multiple devices that take many seconds to shut down (like certain NVMe drives). On one system tested, the shutdown time went from 11 minutes without this patch to 55 seconds with the patch. And on another system from 80 seconds to 11.
Changes from V10:
Reworked to more closely match the design used for async suspend
* No longer uses async subsystem cookies for synchronization
* Minimized changes to struct device
* Enable async shutdown for pci and scsi devices which support async suspendChanges from V9:
Address resource and timing issues when spawning a unique async thread for every device during shutdown:
* Make the asynchronous threads able to shut down multiple devices, instead of spawning a unique thread for every device.
* Modify core kernel async code with a custom wake function so it doesn't wake up a thread waiting to synchronize on a cookie until the cookie has reached the desired value, instead of waking up every waiting thread to check the cookie every time an async thread ends.Changes from V8:
Deal with shutdown hangs resulting when a parent/supplier device is
later in thedevices_ksetlist than its children/consumers:
* Ignoresync_state_onlydevlinks for shutdown dependencies
* Ignoreshutdown_afterfor devices that don't want async shutdown
* Add a sanity check to revert to sync shutdown for any device that would otherwise wait for a child/consumer shutdown that hasn't already been scheduledChanges from V7:
Do not expose driver
async_shutdown_enablein sysfs. Wrapped a long line.Changes from V6:
Removed a sysfs attribute that allowed the async device shutdown to be "on" (with driver opt-out), "safe" (driver opt-in), or "off"... what was previously "safe" is now the only behavior, so drivers now only need to have the option to enable or disable async shutdown.
Changes from V5:
Separated into multiple patches to make review easier. Reworked some code to make it more readable
Made devices wait for consumers to shut down, not just children
(suggested by David Jeffery)Changes from V4:
Change code to use cookies for synchronization rather than async domains Allow async shutdown to be disabled via sysfs, and allow driver opt-in or
opt-out of async shutdown (when not disabled), with ability to control driver opt-in/opt-out via sysfsChanges from V3:
Bug fix (used "parent" not "
dev->parent" indevice_shutdown)Changes from V2:
Removed recursive functions to schedule children to be shutdown before
parents, since existingdevice_shutdownloop will already do thisChanges from V1:
Rewritten using kernel async code (suggested by Lukas Wunner)
Stuart Hayes (2):
driver core: don't always lock parent in shutdown driver core: separate function to shutdown one deviceDavid Jeffery (3):
driver core: async device shutdown infrastructure
pci: enable async shutdown support
scsi: enable async shutdown supportdrivers/base/base.h | 2 + drivers/base/core.c | 165 +++++++++++++++++++++++++++++++------- drivers/pci/probe.c | 1 + drivers/scsi/hosts.c | 3 + drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 4 + include/linux/device.h | 13 +++ 7 files changed, 160 insertions(+), 29 deletions(-)
Quoted 3 lines
--
2.53.0
Adding missed Stuart Hayes and Laurence Oberman addresses.