clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
Subsystems (3)
PATCH 1/1 clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
From: John Crispin <[email protected]>
The XO clock source is always-on in hardware and cannot be gated. Without CLK_IS_CRITICAL, runtime PM of downstream consumers (such as the CMN PLL driver) cascades a disable up to gcc_xo_clk_src, causing a branch status timeout warning.
The IPQ8074 GCC driver already marks this clock as CLK_IS_CRITICAL. Apply the same fix to IPQ6018.
--- drivers/clk/qcom/gcc-ipq6018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/gcc-ipq6018.c +1 -1
@@ -400,7 +400,7 @@ static struct clk_branch gcc_xo_clk_src = { .fw_name = "xo", }, .num_parents = 1, - .flags = CLK_SET_RATE_PARENT, + .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL, .ops = &clk_branch2_ops, }, },
Signature · 1 line
2.53.0
Quoted 7 lines · Christian Marangi
From: John Crispin <[email protected]>
The XO clock source is always-on in hardware and cannot be gated. Without
CLK_IS_CRITICAL, runtime PM of downstream consumers (such as the CMN PLL driver) cascades a disable up togcc_xo_clk_src, causing a branch status timeout warning.
Quoted 6 lines
The IPQ8074 GCC driver already marks this clock as
CLK_IS_CRITICAL. Apply the same fix to IPQ6018.Signed-off-by John Crispin <[email protected]>Signed-off-by Christian Marangi <[email protected]>---
Konrad
Quoted 9 lines · Christian Marangi
The XO clock source is always-on in hardware and cannot be gated. Without
CLK_IS_CRITICAL, runtime PM of downstream consumers (such as the CMN PLL driver) cascades a disable up togcc_xo_clk_src, causing a branch status timeout warning.The IPQ8074 GCC driver already marks this clock as
CLK_IS_CRITICAL. Apply the same fix to IPQ6018.[...]
Applied, thanks!
[1/1] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
commit: 27c7ec7ad7dbc7baeede6ca7429f294bc33cae13
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>