Skip to contentSkip to conversation

regulator: pf1550: Remove redundant regmap assignment

PATCH In review Felix Gu 3 participants 3 messages Mar 12

Subsystems (3)
lore
Share & tools
lore

Felix Gu

author
#0 lore raw

PATCH 1/1 regulator: pf1550: Remove redundant regmap assignment

The config.regmap is already correctly initialized using dev_get_regmap() on the parent device. Remove the redundant second assignment that was overwriting it with pf1550->regmap.

Fixes 7320d41c29bb ("regulator: pf1550: Add support for regulator")
---
 drivers/regulator/pf1550-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/pf1550-regulator.c +0 -1
index 037b8ec94066..1d1726528460 100644
@@ -360,7 +360,6 @@ static int pf1550_regulator_probe(struct platform_device *pdev)
 				     "failed to get parent regmap\n");
 
 	config.dev = pf1550->dev;
-	config.regmap = pf1550->regmap;
 	info->dev = &pdev->dev;
 	info->pf1550 = pf1550;
 

---
base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260312-1550-327017c6f56c

Best regards,

Signature · 1 line
Felix Gu <[email protected]>
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Felix Gu

The config.regmap is already correctly initialized using dev_get_regmap() on the parent device. Remove the redundant second assignment that was overwriting it with pf1550->regmap.

Fixes 7320d41c29bb ("regulator: pf1550: Add support for regulator")

Nit: This is not bug fix and it is code cleanup. Needn't fixes tag here

Quoted 26 lines
---
 drivers/regulator/pf1550-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/pf1550-regulator.c +0 -2
index 037b8ec94066..1d1726528460 100644
@@ -360,7 +360,6 @@ static int pf1550_regulator_probe(struct platform_device *pdev)
 				     "failed to get parent regmap\n");
 
 	config.dev = pf1550->dev;
-	config.regmap = pf1550->regmap;
 	info->dev = &pdev->dev;
 	info->pf1550 = pf1550;
 
 
---

base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260312-1550-327017c6f56c

Best regards,
--
Felix Gu <[email protected]>

maintainer
#2 lore raw
In reply to Felix Gu
Quoted 3 lines · Felix Gu

The config.regmap is already correctly initialized using dev_get_regmap() on the parent device. Remove the redundant second assignment that was overwriting it with pf1550->regmap.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: pf1550: Remove redundant regmap assignment

      commit: e80c626ae06ed9c502ebda4a7e0b390af9ccf6b0

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark