Skip to contentSkip to conversation

dt-bindings: bus: ti,da850-mstpri: Convert to YAML

PATCH In review Zeynep Dicle 2 participants 3 messages Mar 13 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: bus: ti,da850-mstpri: Convert to YAML

Convert the TI DA850 master peripheral priority binding from txt to YAML format to enable automated validation of device tree sources.

---
 .../bindings/bus/ti,da850-mstpri.txt          | 20 -------------
 .../bindings/bus/ti,da850-mstpri.yaml         | 28 +++++++++++++++++++
 2 files changed, 28 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt
 create mode 100644 Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml
Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt deleted +0 -20
deleted file mode 100644
index 72daefc6b..000000000
@@ -1,20 +0,0 @@
-* Device tree bindings for Texas Instruments da8xx master peripheral
-  priority driver
-
-DA8XX SoCs feature a set of registers allowing to change the priority of all
-peripherals classified as masters.
-
-Documentation:
-OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf
-
-Required properties:
-
-- compatible:		"ti,da850-mstpri" - for da850 based boards
-- reg:			offset and length of the mstpri registers
-
-Example for da850-lcdk is shown below.
-
-mstpri {
-	compatible = "ti,da850-mstpri";
-	reg = <0x14110 0x0c>;
-};
Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml new file +28 -0
new file mode 100644
index 000000000..b89bfebd1
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/ti,da850-mstpri.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Texas Instruments DA850 Master Peripheral Priority
+maintainers:
+  - Bartosz Golaszewski <[email protected]>
+description: |
+  DA8XX SoCs feature a set of registers allowing to change the priority of all
+  peripherals classified as masters.
+properties:
+  compatible:
+    const: ti,da850-mstpri
+  reg:
+    maxItems: 1
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    mstpri@14110 {
+        compatible = "ti,da850-mstpri";
+        reg = <0x14110 0x0c>;
+    };
Signature · 1 line
2.43.0
#1 lore raw
Quoted 8 lines · Zeynep Dicle

+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/ti,da850-mstpri.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml new file +4 -0
+title: Texas Instruments DA850 Master Peripheral Priority
+maintainers:
+  - Bartosz Golaszewski <[email protected]>
+description: |

Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml line 19

Quoted 10 lines
Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml new file +10 -0
+  DA8XX SoCs feature a set of registers allowing to change the priority of all
+  peripherals classified as masters.
+properties:
+  compatible:
+    const: ti,da850-mstpri
+  reg:
+    maxItems: 1
+required:
+  - compatible
+  - reg

I don't believe this passed your GSoC mentors review. Please don't send AI output but actually follow existing kernel/DT style.

Best regards,
Krzysztof

#2 lore raw
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · Zeynep Dicle

+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/ti,da850-mstpri.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml new file +9 -0
+title: Texas Instruments DA850 Master Peripheral Priority
+maintainers:
+  - Bartosz Golaszewski <[email protected]>
+description: |
+  DA8XX SoCs feature a set of registers allowing to change the priority of all
+  peripherals classified as masters.
+properties:
+  compatible:
+    const: ti,da850-mstpri
Quoted 8 lines

Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml line 19

Quoted 5 lines
Documentation/devicetree/bindings/bus/ti,da850-mstpri.yaml new file +5 -0
+  reg:
+    maxItems: 1
+required:
+  - compatible
+  - reg

I don't believe this passed your GSoC mentors review. Please don't send AI output but actually follow existing kernel/DT style.

And let me remind, that what you sent is not better what Rob already prepared a year ago:

https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt-convert&id=9f0479e32bcd132e85899b40185c62754ff93aed

So what is the point of posting unsupervised and poor AI output if we have it all done?

Best regards,
Krzysztof