Skip to contentSkip to conversation

thunderbolt: dma_port: kmalloc_array + kzalloc to flex

PATCH Applied Rosen Penev 2 participants 2 messages Mar 13 – Mar 18

Subsystems (2)
USB Thunderbolt driver
lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH 1/1 thunderbolt: dma_port: kmalloc_array + kzalloc to flex

Use a single allocation with a flexible array member. Simplifies allocation and freeing.

Signed-off-by Rosen Penev <[email protected]>
---
 drivers/thunderbolt/dma_port.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)
drivers/thunderbolt/dma_port.c +3 -12
index 334fefe21255..c7c2942fa7be 100644
@@ -55,7 +55,7 @@ struct tb_dma_port {
 	struct tb_switch *sw;
 	u8 port;
 	u32 base;
-	u8 *buf;
+	u8 buf[];
 };
 
 /*

@@ -209,16 +209,10 @@ struct tb_dma_port *dma_port_alloc(struct tb_switch *sw)
 	if (port < 0)
 		return NULL;
 
-	dma = kzalloc_obj(*dma);
+	dma = kzalloc_flex(*dma, buf, MAIL_DATA_DWORDS);
 	if (!dma)
 		return NULL;
 
-	dma->buf = kmalloc_array(MAIL_DATA_DWORDS, sizeof(u32), GFP_KERNEL);
-	if (!dma->buf) {
-		kfree(dma);
-		return NULL;
-	}
-
 	dma->sw = sw;
 	dma->port = port;
 	dma->base = DMA_PORT_CAP;

@@ -232,10 +226,7 @@ struct tb_dma_port *dma_port_alloc(struct tb_switch *sw)
  */
 void dma_port_free(struct tb_dma_port *dma)
 {
-	if (dma) {
-		kfree(dma->buf);
-		kfree(dma);
-	}
+	kfree(dma);
 }
 
 static int dma_port_wait_for_completion(struct tb_dma_port *dma,
Signature · 1 line
2.53.0