Skip to contentSkip to conversation

crypto: crc32c - Remove more outdated usage information

PATCH Applied Eric Biggers 2 participants 3 messages Mar 14 – Mar 17 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: crc32c - Remove more outdated usage information

Remove information from the crypto/crc32c.c file comment that is no longer applicable now that nearly all users of CRC-32C are simply using the crc32c() library function instead. This continues the cleanup from commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").

---

This patch is targeting crc-next.

 crypto/crc32c.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
crypto/crc32c.c +1 -13
index 1eff54dde2f74..c6c9c727b25b4 100644
@@ -1,10 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * Cryptographic API.
- *
- * CRC32C chksum
+ * crypto_shash support for CRC-32C
  *
  *@Article{castagnoli-crc,
  * author =       { Guy Castagnoli and Stefan Braeuer and Martin Herrman},
  * title =        {{Optimization of Cyclic Redundancy-Check Codes with 24
  *                 and 32 Parity Bits}},
@@ -13,20 +11,10 @@
  * volume =       {41},
  * number =       {6},
  * pages =        {},
  * month =        {June},
  *}
- * Used by the iSCSI driver, possibly others, and derived from
- * the iscsi-crc.c module of the linux-iscsi driver at
- * http://linux-iscsi.sourceforge.net.
- *
- * Following the example of lib/crc32, this function is intended to be
- * flexible and useful for all users.  Modules that currently have their
- * own crc32c, but hopefully may be able to use this one are:
- *  net/sctp (please add all your doco to here if you change to
- *            use this one!)
- *  <endoflist>
  *
  * Copyright (c) 2004 Cisco Systems, Inc.
  * Copyright (c) 2008 Herbert Xu <[email protected]>
  */
 

base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204

Signature · 1 line
2.53.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eric Biggers

Remove information from the crypto/crc32c.c file comment that is no longer applicable now that nearly all users of CRC-32C are simply using the crc32c() library function instead. This continues the cleanup from commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").

Quoted 8 lines

---

This patch is targeting crc-next.

 crypto/crc32c.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
Quoted 41 lines
crypto/crc32c.c +1 -13
index 1eff54dde2f74..c6c9c727b25b4 100644
@@ -1,10 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * Cryptographic API.
- *
- * CRC32C chksum
+ * crypto_shash support for CRC-32C
  *
  *@Article{castagnoli-crc,
  * author =       { Guy Castagnoli and Stefan Braeuer and Martin Herrman},
  * title =        {{Optimization of Cyclic Redundancy-Check Codes with 24
  *                 and 32 Parity Bits}},
@@ -13,20 +11,10 @@
  * volume =       {41},
  * number =       {6},
  * pages =        {},
  * month =        {June},
  *}
- * Used by the iSCSI driver, possibly others, and derived from
- * the iscsi-crc.c module of the linux-iscsi driver at
- * http://linux-iscsi.sourceforge.net.
- *
- * Following the example of lib/crc32, this function is intended to be
- * flexible and useful for all users.  Modules that currently have their
- * own crc32c, but hopefully may be able to use this one are:
- *  net/sctp (please add all your doco to here if you change to
- *            use this one!)
- *  <endoflist>
  *
  * Copyright (c) 2004 Cisco Systems, Inc.
  * Copyright (c) 2008 Herbert Xu <[email protected]>
  */
 

base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204

Signature · 1 line
2.53.0
author Applied
#2 lore raw
In reply to Eric Biggers
Quoted 5 lines · Eric Biggers

Remove information from the crypto/crc32c.c file comment that is no longer applicable now that nearly all users of CRC-32C are simply using the crc32c() library function instead. This continues the cleanup from commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").

Quoted 7 lines

---

This patch is targeting crc-next.

 crypto/crc32c.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

- Eric