Skip to contentSkip to conversation

Docs/mm/damon: document exclusivity of special-purpose modules

PATCH Applied SeongJae Park 1 participant 1 message Mar 15

Subsystems (4)
Memory management Documentation MM misc DAMON
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

PATCH v2 1/1 Docs/mm/damon: document exclusivity of special-purpose modules

From: Liew Rui Yan <[email protected]>

Add a section in design.rst to explain that DAMON special-purpose kernel modules (LRU_SORT, RECLAIM, STAT) run in an exclusive manner and return -EBUSY if another is already running.

Update lru_sort.rst, reclaim.rst and stat.rst by adding cross-references to this exclusivity rule at the end of their respective Example sections.

This change is motivated from another discussion [1].

[1] https://lore.kernel.org/damon/[email protected]/T/#t

Signed-off-by Liew Rui Yan <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Signed-off-by SeongJae Park <[email protected]>

---
Change from v1
(https://lore.kernel.org/[email protected])
- Drop contents directive fix
- Reword description

 Documentation/admin-guide/mm/damon/lru_sort.rst | 5 +++++
 Documentation/admin-guide/mm/damon/reclaim.rst  | 5 +++++
 Documentation/admin-guide/mm/damon/stat.rst     | 5 +++++
 Documentation/mm/damon/design.rst               | 4 ++++
 4 files changed, 19 insertions(+)
Documentation/admin-guide/mm/damon/lru_sort.rst +5 -0
index 73980bacc3a02..56690646cf398 100644
@@ -351,3 +351,8 @@ the LRU-list based page granularity reclamation. ::
     # echo 400 > wmarks_mid
     # echo 200 > wmarks_low
     # echo Y > enabled
+
+Note that this module (damon_lru_sort) cannot run simultaneously with other
+DAMON-based special-purpose modules.  Refer to :ref:`DAMON design special
+purpose modules exclusivity <damon_design_special_purpose_modules_exclusivity>`
+for more details.
Documentation/admin-guide/mm/damon/reclaim.rst +5 -0
index 552a7786b0829..6f580f637134a 100644
@@ -318,6 +318,11 @@ granularity reclamation. ::
     # echo 200 > wmarks_low
     # echo Y > enabled
 
+Note that this module (damon_reclaim) cannot run simultaneously with other
+DAMON-based special-purpose modules.  Refer to :ref:`DAMON design special
+purpose modules exclusivity <damon_design_special_purpose_modules_exclusivity>`
+for more details.
+
 .. [1] https://research.google/pubs/pub48551/
 .. [2] https://lwn.net/Articles/787611/
 .. [3] Documentation/mm/free_page_reporting.rst
Documentation/admin-guide/mm/damon/stat.rst +5 -0
index e5a5a2c4f803a..c4b14daeb2dd6 100644
@@ -45,6 +45,11 @@ You can enable DAMON_STAT by setting the value of this parameter as ``Y``.
 Setting it as ``N`` disables DAMON_STAT.  The default value is set by
 ``CONFIG_DAMON_STAT_ENABLED_DEFAULT`` build config option.
 
+Note that this module (damon_stat) cannot run simultaneously with other
+DAMON-based special-purpose modules.  Refer to :ref:`DAMON design special
+purpose modules exclusivity <damon_design_special_purpose_modules_exclusivity>`
+for more details.
+
 .. _damon_stat_aggr_interval_us:
 
 aggr_interval_us
Documentation/mm/damon/design.rst +4 -0
index 29fff20b3c2a9..dc37402c0fee9 100644
@@ -853,6 +853,10 @@ more detail, please read the usage documents for those
 (:doc:`/admin-guide/mm/damon/stat`, :doc:`/admin-guide/mm/damon/reclaim` and
 :doc:`/admin-guide/mm/damon/lru_sort`).
 
+.. _damon_design_special_purpose_modules_exclusivity:
+
+Note that these modules currently run in an exclusive manner.  If one of those
+is already running, others will return ``-EBUSY`` upon start requests.
 
 Sample DAMON Modules
 --------------------

base-commit: 1e6fb24fdfceeb8dfa1a97a0270e4aeffa0a6d6d

Signature · 1 line
2.47.3