mfd/ASoC: WM8400: select SND_SOC_WM8400 from MFD_WM8400
Subsystems (3)
PATCH 1/1 mfd/ASoC: WM8400: select SND_SOC_WM8400 from MFD_WM8400
The MFD driver wm8400-core.c unconditionally registers a platform device named 'wm8400-codec' via wm8400_register_codec(). The codec driver in sound/soc/codecs/wm8400.c binds to this device by name, but SND_SOC_WM8400 is a hidden symbol with no prompt and nothing was selecting it in normal configurations, so the driver never built.
Fix this by adding 'select SND_SOC_WM8400' to MFD_WM8400, which encodes the implicit dependency that already existed at runtime. Also remove the FIXME comment that noted this gap.
--- drivers/mfd/Kconfig | 1 + sound/soc/codecs/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -0
@@ -2127,6 +2127,7 @@ config MFD_WM8400 select MFD_CORE depends on I2C=y select REGMAP_I2C + select SND_SOC_WM8400 help Support for the Wolfson Microelecronics WM8400 PMIC and audio CODEC. This driver provides common support for accessing
sound/soc/codecs/Kconfig +0 -1
@@ -2496,7 +2496,6 @@ config SND_SOC_WM8350 config SND_SOC_WM8400 tristate - # FIXME nothing selects SND_SOC_WM8400?? depends on MFD_WM8400 config SND_SOC_WM8510
Signature · 1 line
2.34.1
Mark Brown
maintainerQuoted 9 lines · Piyush Patle
The MFD driver
wm8400-core.cunconditionally registers a platform device named 'wm8400-codec' viawm8400_register_codec(). The codec driver insound/soc/codecs/wm8400.cbinds to this device by name, butSND_SOC_WM8400is a hidden symbol with no prompt and nothing was selecting it in normal configurations, so the driver never built.Fix this by adding 'select
SND_SOC_WM8400' toMFD_WM8400, which encodes the implicit dependency that already existed at runtime. Also remove the FIXME comment that noted this gap.
This doesn't accomplish anything, the driver will do nothing unless a sound card binds to it. This is very standard for older CODEC drivers, the comment just shouldn't be there.