Skip to contentSkip to conversation

staging: media: av7110: coding style fixes: too many tabs

PATCH In review Sudarshan Srinivasan 3 participants 4 messages Mar 16 – Mar 19

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: av7110: coding style fixes: too many tabs

This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring

---
 drivers/staging/media/av7110/av7110.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/av7110/av7110.c +1 -2
index 607992100baf..f4709b2c4f41 100644
@@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
 						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
 						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
 						ret = av7110_av_start_play(av7110, RP_AV);
-						if (!ret)
-							demux->playing = 1;
+						demux->playing = (ret) ? true : false
 					}
 				break;
 			default:
Signature · 1 line
2.43.0
#1 lore raw
Quoted 13 lines · Sudarshan Srinivasan

This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring

---
 drivers/staging/media/av7110/av7110.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/av7110/av7110.c +0 -0
index 607992100baf..f4709b2c4f41 100644

drivers/staging/media/av7110/av7110.c static int av7110_start_feed(struct dvb_demux_feed *feed) · line 961

Quoted 6 lines
drivers/staging/media/av7110/av7110.c +1 -2
@@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
 						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
 						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
 						ret = av7110_av_start_play(av7110, RP_AV);
-						if (!ret)
-							demux->playing = 1;
+						demux->playing = (ret) ? true : false

This isn't an improvement. Sorry.

regards,
dan carpenter

#2 lore raw

PATCH v2 1/1 staging: media: av7110: coding style fixes: too many tabs

In reply to Sudarshan Srinivasan

This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring

---
 drivers/staging/media/av7110/av7110.c | 33 +++++++++++++++++++--------
 1 file changed, 23 insertions(+), 10 deletions(-)
drivers/staging/media/av7110/av7110.c +23 -10
index 607992100baf..15460ca026dc 100644
@@ -932,6 +932,28 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
 	return ret;
 }
 
+static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
+			       struct dvb_demux *demux,
+			       struct av7110 *av7110)
+{
+		int ret = 0;
+
+		if (feed->pes_type >= 2)
+			return 0;
+
+		if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
+			return 0;
+
+		dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
+		dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
+
+		ret = av7110_av_start_play(av7110, RP_AV);
+		if (!ret)
+			demux->playing = true;
+
+		return ret;
+}
+
 static int av7110_start_feed(struct dvb_demux_feed *feed)
 {
 	struct dvb_demux *demux = feed->demux;
@@ -951,16 +973,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
 		    (feed->pes_type <= DMX_PES_PCR)) {
 			switch (demux->dmx.frontend->source) {
 			case DMX_MEMORY_FE:
-				if (feed->ts_type & TS_DECODER)
-					if (feed->pes_type < 2 &&
-					    !(demux->pids[0] & 0x8000) &&
-					    !(demux->pids[1] & 0x8000)) {
-						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
-						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
-						ret = av7110_av_start_play(av7110, RP_AV);
-						if (!ret)
-							demux->playing = 1;
-					}
+				ret = handle_ts_memory_fe(feed, demux, av7110);
 				break;
 			default:
 				ret = dvb_feed_start_pid(feed);
Signature · 1 line
2.43.0
maintainer
#3 lore raw
Quoted 63 lines · Sudarshan Srinivasan

This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring

---
 drivers/staging/media/av7110/av7110.c | 33 +++++++++++++++++++--------
 1 file changed, 23 insertions(+), 10 deletions(-)
drivers/staging/media/av7110/av7110.c +23 -10
index 607992100baf..15460ca026dc 100644
@@ -932,6 +932,28 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
 	return ret;
 }
 
+static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
+			       struct dvb_demux *demux,
+			       struct av7110 *av7110)
+{
+		int ret = 0;
+
+		if (feed->pes_type >= 2)
+			return 0;
+
+		if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
+			return 0;
+
+		dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
+		dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
+
+		ret = av7110_av_start_play(av7110, RP_AV);
+		if (!ret)
+			demux->playing = true;
+
+		return ret;
+}
+
 static int av7110_start_feed(struct dvb_demux_feed *feed)
 {
 	struct dvb_demux *demux = feed->demux;
@@ -951,16 +973,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
 		    (feed->pes_type <= DMX_PES_PCR)) {
 			switch (demux->dmx.frontend->source) {
 			case DMX_MEMORY_FE:
-				if (feed->ts_type & TS_DECODER)
-					if (feed->pes_type < 2 &&
-					    !(demux->pids[0] & 0x8000) &&
-					    !(demux->pids[1] & 0x8000)) {
-						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
-						dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
-						ret = av7110_av_start_play(av7110, RP_AV);
-						if (!ret)
-							demux->playing = 1;
-					}
+				ret = handle_ts_memory_fe(feed, demux, av7110);
 				break;
 			default:
 				ret = dvb_feed_start_pid(feed);
Signature · 1 line
2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot