Migrating the libhugetlbfs/testcases/truncate_sigbus_versus_oom.c test
PATCH v5 1/1 Migrating the libhugetlbfs/testcases/truncate_sigbus_versus_oom.c test
In this test case, we are verifying the bug fix commit that is attached as a part of the test case structure,
Some kernel have a bug in the positioning of the test against i_size. This bug means that attempting to instantiate a page beyond the end of a hugepage file can result in an OOM and SIGKILL instead of the correct SIGBUS.
---
v5:
1. Addressed typo issue from discription of the test.
2. Removed [Description] tag
3. Removed unused variable.
4. Moved struct sigaction sa this variable in to setup function.
--- runtest/hugetlb | 1 + testcases/kernel/mem/.gitignore | 1 + .../kernel/mem/hugetlb/hugemmap/hugemmap37.c | 92 +++++++++++++++++++ 3 files changed, 94 insertions(+) create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c
runtest/hugetlb +1 -0
@@ -36,6 +36,7 @@ hugemmap30 hugemmap30 hugemmap31 hugemmap31 hugemmap32 hugemmap32 hugemmap34 hugemmap34 +hugemmap37 hugemmap37 hugemmap05_1 hugemmap05 -m hugemmap05_2 hugemmap05 -s hugemmap05_3 hugemmap05 -s -m
testcases/kernel/mem/.gitignore +1 -0
@@ -36,6 +36,7 @@ /hugetlb/hugemmap/hugemmap31 /hugetlb/hugemmap/hugemmap32 /hugetlb/hugemmap/hugemmap34 +/hugetlb/hugemmap/hugemmap37 /hugetlb/hugeshmat/hugeshmat01 /hugetlb/hugeshmat/hugeshmat02 /hugetlb/hugeshmat/hugeshmat03
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +92 -0
92 lines not on this page · raw message
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Samir,
Thanks for the migration. This is just a first line review on the major issues related to this patch. Probably more will come with time if these issues won't be achieved.
Quoted 2 lines
Subject: [PATCH] Migrating the
libhugetlbfs/testcases/truncate_sigbus_versus_oom.ctest
The subject should use imperative mood, e.g.:
hugemmap37: Migrate truncate_sigbus_versus_oom from libhugetlbfs
Quoted 3 lines
In this test case, we are verifying the bug fix commit that is attached as a part of the test case structure,
Some kernel have a bug in the positioning of the test against
"Some kernel have" -> "Some kernels have". The first sentence ends with a dangling comma and is vague. Consider dropping it entirely — the second paragraph already explains the test clearly.
[...]
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 65
Quoted 3 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +3
-0+void setup (void ) +{ +struct sigaction sa;
Two issues here:
1) setup() and cleanup() are missing the 'static' keyword.
2) 'sa' is uninitialized — sa_mask and other fields contain garbage. Zero-initialize it:
struct sigaction sa = {};
sigemptyset(&sa.sa_mask);testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 68
Quoted 2 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +2
-0+ sa.sa_flags =SA_SIGINFO ; + sa.sa_handler = sigbus_handler;
SA_SIGINFO tells the kernel to use sa_sigaction (3-argument handler), but you assign to sa_handler (1-argument). This is undefined behavior per POSIX. Since sigbus_handler() takes a single int, drop SA_SIGINFO:
sa.sa_flags = 0;
sa.sa_handler = sigbus_handler;Review
Quoted 2 lines
(quoted diff) +2
-0+ totpages = SAFE_READ_MEMINFO(MEMINFO_HPAGE_FREE); + hpage_size = tst_get_hugepage_size();
The totpages assignment here is dead code — it gets overwritten in run_test() before use. Remove it from setup().
[...]
Quoted 2 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +2
-0+ fd =tst_creat_unlinked (MNTPOINT ,0 ,0600 ); + p =SAFE_MMAP (NULL , hpage_size,PROT_READ |PROT_WRITE ,MAP_SHARED , fd,0 );
[...]
Quoted 1 line
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +1
-0+ fdx =tst_creat_unlinked (MNTPOINT ,0 ,0600 );
[...]
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 46
Quoted 2 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +2
-0+ q =SAFE_MMAP (NULL , totpages * hpage_size,PROT_READ |PROT_WRITE ,MAP_SHARED , + fdx,0 );
fd and fdx are opened each iteration but only closed in cleanup(). On -i N runs the previous fds leak. Similarly, p and q are mmap'd but never munmapped, leaking virtual memory each iteration.
Close the fds and munmap both regions at the end of run_test(), resetting fd/fdx to -1.
[...]
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c line 79
Quoted 6 lines
testcases/kernel/mem/hugetlb/hugemmap/hugemmap37.c new file +6
-0+void cleanup (void ) +{ +if (fd >0 ) +SAFE_CLOSE (fd); +if (fdx >0 ) +SAFE_CLOSE (fdx);
if (fd != -1) and fd should be initialized to -1. zero is a valid value.
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp