Skip to contentSkip to conversation

staging: media: atomisp: remove unnecessary parentheses in return statement

PATCH In review Teng Liu 2 participants 2 messages Mar 17 – Apr 18

Subsystems (4)
lore
Share & tools
lore

Teng Liu

author
#0 lore raw

PATCH 1/1 staging: media: atomisp: remove unnecessary parentheses in return statement

Remove unnecessary parentheses around the return value in ia_css_pipeline_get_pipe_io_status(). return is not a function, so parentheses are not required.

This addresses the following checkpatch error:
ERROR: return is not a function, parentheses are not required

---
 .../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c +1 -1
index 0470871f8..fba567de4 100644
@@ -446,7 +446,7 @@ bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline)
 
 struct sh_css_sp_pipeline_io_status *ia_css_pipeline_get_pipe_io_status(void)
 {
-	return(&sh_css_sp_group.pipe_io_status);
+	return &sh_css_sp_group.pipe_io_status;
 }
 
 bool ia_css_pipeline_is_mapped(unsigned int key)
Signature · 1 line
2.53.0
#1 lore raw

Hi Teng,

Quoted 17 lines · Teng Liu

Remove unnecessary parentheses around the return value in ia_css_pipeline_get_pipe_io_status(). return is not a function, so parentheses are not required.

This addresses the following checkpatch error:
ERROR: return is not a function, parentheses are not required

---
 .../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c +0 -0
index 0470871f8..fba567de4 100644

drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline) · line 449

Quoted 5 lines
drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c +1 -1
@@ -446,7 +446,7 @@ bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline)
 
 struct sh_css_sp_pipeline_io_status *ia_css_pipeline_get_pipe_io_status(void)
 {
-	return(&sh_css_sp_group.pipe_io_status);
+	return &sh_css_sp_group.pipe_io_status;

Is it the only such case in the driver?

Quoted 3 lines
drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c +0 -0
 }
 
 bool ia_css_pipeline_is_mapped(unsigned int key)
Signature · 3 lines
Regards,

Sakari Ailus