tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
Subsystems (2)
PATCH v2 1/1 tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
The function scx_ops_error() was droped, but the
comment here is left pointing to the old name.
Update to be consistent with current API.
Signed-off-by Ke Zhao <[email protected]>
---
v2:
- Corrected the new function name to scx_bpf_error instead of scx_error.
tools/sched_ext/scx_flatcg.bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/sched_ext/scx_flatcg.bpf.c +1 -1
@@ -919,7 +919,7 @@ void BPF_STRUCT_OPS(fcg_cgroup_move, struct task_struct *p,struct fcg_cgrp_ctx *from_cgc, *to_cgc;s64 delta; -/* find_cgrp_ctx() triggers scx_ops_error() on lookup failures */ +/* find_cgrp_ctx() triggers scx_bpf_error() on lookup failures */ if (!(from_cgc =find_cgrp_ctx (from)) || !(to_cgc =find_cgrp_ctx (to)))return ;
Signature · 1 line
2.43.0
Hi Ke,
Quoted 1 line · Ke Zhao
The function
scx_ops_error()was droped, but the
Nit:
- s/droped/dropped/
- Use scx_ops_error() and fcg_cgroup_move() (with parentheses) in the subject to denote functions.
Signature · 2 lines
Thanks, Cheng-Yang