Skip to contentSkip to conversation

staging: rtl8723bs: coding style cleanups

PATCH In review Malavya Raval 2 participants 2 messages Mar 18 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: coding style cleanups

Renaming CamelCase variables and macros to snake_case and fixing formatting issues in the rtl8723bs staging driver to align with kernel coding style standards.

---

drivers/staging/rtl8723bs/core/rtw_ap.c +3 -3
index 864cd8b6d..284c49bf4 100644
@@ -720,10 +720,10 @@ void start_bss_network(struct adapter *padapter)
 
                /* disable dynamic functions, such as high power, DIG */
                /* Save_DM_Func_Flag(padapter); */
-               /* Switch_DM_Func(padapter, DYNAMIC_FUNC_DISABLE, false); */
+               /* switch_dm_func(padapter, DYNAMIC_FUNC_DISABLE, false); */
 
                /* turn on all dynamic functions */
-               Switch_DM_Func(padapter, DYNAMIC_ALL_FUNC_ENABLE, true);
+               switch_dm_func(padapter, DYNAMIC_ALL_FUNC_ENABLE, true);
 
                /* rtw_hal_set_hwreg(padapter, HW_VAR_INITIAL_GAIN, (u8 *)(&initialgain)); */
        }
@@ -2001,7 +2001,7 @@ void rtw_ap_restore_network(struct adapter *padapter)
 
                if (psta->state & _FW_LINKED) {
                rtw_sta_media_status_rpt(padapter, psta, 1);
-               Update_RA_Entry(padapter, psta);
+               update_ra_entry(padapter, psta);
                /* pairwise key */
                /* per sta pairwise key and settings */
                if ((psecuritypriv->dot11PrivacyAlgrthm == _TKIP_) ||
drivers/staging/rtl8723bs/core/rtw_cmd.c +113 -113

388 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_io.c +7 -2
index 965c3cfea..75fa48ab8 100644
@@ -75,6 +75,7 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
 
        return RTW_STATUS_CODE(ret);
        }
+
 int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
 {
        /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
@@ -88,6 +89,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
        ret = _write16(pintfhdl, addr, val);
        return RTW_STATUS_CODE(ret);
        }
+
 int rtw_write32(struct adapter *adapter, u32 addr, u32 val)
 {
        /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
@@ -114,7 +116,9 @@ u32 rtw_write_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
        return _write_port(pintfhdl, addr, cnt, pmem);
        }
 
-int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapter *padapter, struct _io_ops *pops))
+int rtw_init_io_priv(struct adapter *padapter,
+       void (*set_intf_ops)(struct adapter *padapter,
+       struct _io_ops *pops))
 {
        struct io_priv *piopriv = &padapter->iopriv;
        struct intf_hdl *pintf = &piopriv->intf;
@@ -132,7 +136,8 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt
        }
 
        /*
-        * Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR
+        * Increase and check if the continual_io_error of this @param dvobjprive is
+        * larger than MAX_CONTINUAL_IO_ERR
         * @return true:
         * @return false:
         */
drivers/staging/rtl8723bs/core/rtw_mlme.c +1 -1
index 1ef48bf65..b27a726d8 100644
@@ -1174,7 +1174,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf)
 
        spin_lock_bh(&pmlmepriv->lock);
 
-       pmlmepriv->LinkDetectInfo.TrafficTransitionCount = 0;
+       pmlmepriv->LinkDetectInfo.traffic_transition_count = 0;
        pmlmepriv->LinkDetectInfo.LowPowerTransitionCount = 0;
 
        if (pnetwork->join_res > 0) {
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +83 -83

479 lines not on this page · raw message

#1 lore raw
Quoted 7 lines · Malavya Raval

Renaming CamelCase variables and macros to snake_case and fixing formatting issues in the rtl8723bs staging driver to align with kernel coding style standards.

---

Please submit one patch with one change. In this case, each variable requires a separate patch.

Also, always check your patch before submitting:

	./scripts/checkpatch.pl --strict path/to/patch

Thanks,
Nikolay